update-manager battery warning has two buttons with the same accelerator

The key for the "Continue" button should be Enter, and the key for the "Cancel" button should be Esc. Neither button should have any other key equivalents.

Taking away the accelerators or making them unique, either way I think it should changed.

By the way, right now the enter key is equivalent to 'Close' and the esc key is equivalent to 'Continue', which is opposite to the behavior that Matthew described.

While people are looking at this, the behaviour in the dialog box that warns about Partial Upgrades is also odd. In that dialog, there are two buttons: "_Partial Upgrade" and "_Cancel". If you highlight the former and press Enter, the Cancel action is invoked.

I fixed the behavior for ESC and fixed the duplicated accelerator labels.

I did not remove the accelerator labels yet because:
- every other dialog that uses a stock "gtk-close" button has a accelerator
- if continue has no accelerator there is no way to quickly trigger it (with a single keystroke). the user would have to use tab->enter
- if we make the default focus of the dialog continue (so that it is triggered on ENTER) instead of "close" that contradicts the intention of the dialog (that the user should explicitely say that he want to continue)
- if we focus "close" but trigger a "continue" on ENTER than that would behave differently from every other dialog in gnome

I attach a small test-code snippest do demonstrate the ENTER default behavior.

(I do not disagree with the change itself, but I think if we want it, we should make it consistent).

I fixed the behavior for ESC and fixed the duplicated accelerator labels.

I did not remove the accelerator labels yet because:
- every other dialog that uses a stock "gtk-close" button has a accelerator
- if continue has no accelerator there is no way to quickly trigger it (with a single keystroke). the user would have to use tab->enter
- if we make the default focus of the dialog continue (so that it is triggered on ENTER) instead of "close" that contradicts the intention of the dialog (that the user should explicitely say that he want to continue)
- if we focus "close" but trigger a "continue" on ENTER than that would behave differently from every other dialog in gnome

I attach a small test-code snippest do demonstrate the ENTER default behavior.

(I do not disagree with the change itself, but I think if we want it, we should make it consistent).

This bug was fixed in the package update-manager - 1:0.125.2

---------------
update-manager (1:0.125.2) karmic; urgency=low

  [ Michael Vogt ]
  * DistUpgrade/DistUpgradeCache.py:
    - add check for 5Mb safety buffer in /tmp, this ensures that
      dkms can run and ensure we do not run when /tmp is mounted
      in overflow mode (LP: #427035)
  * data/glade/UpdateManager.ui:
    - remove dialog title for the battery warning and fix button
      order (thanks to Matthew Paul Thomas)
  * data/glade/UpdateManager.ui:
    - fix duplicated accelerator keys (LP: #425817)
  * UpdateManager/UpdateManager.py:
    - close app when ESC is pressed in the battery warning
  * UpdateManager/UpdateManager.py:
    - ensure that the changelog always matches the currently selected
      pkg by fixing race during download (LP: #424918)
  * UpdateManager/backend/InstallBackendAptdaemon.py:
    - do not hang when cancel is clicked (LP: #426718)
  * add sed patch facility and patch the gnome debconf frontend
    before the upgrade starts so that it can not crash when
    perl moves from 5.8.0 to 5.10.0 (LP: #387112)
  * data/glade/UpdateManager.ui:
    - use bigger default width (LP: #418201)

  [ Brian Murray ]
  * typo fixes (thanks to Brian Murray, LP: #423409)

 -- Michael Vogt <email address hidden> Tue, 15 Sep 2009 10:50:24 +0200