Financial reports to review for 6.0

Bug #551630 reported by Luc Maurer @ Camptocamp
46
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Critical
OpenERP R&D Addons Team 3

Bug Description

Hello,

As discuss during the community days, all financial reports have to be reviewed.

The list of modification has been created by Quentin, please ask him for more information => here are the most important things to change :

== Account balance ==

 * Wizard
     * add currency balance amount => check box
     * add comparison with other fiscal year
     * filter => only by date / by periode / none => from ... to for both date and period (period really based on period and not on dates)
     * filter => dependant to the fiscal year (only see period related to the fiscal year selected)

* Calculation
     * sum of all entries related to the account into the date filter selection

== General ledger ==
 * Wizard
     * add “with opening balance" => to have a new line with the sum of all entries that are before the begin date/periode
     * Use the “Display history” check box => add a new select field (see quentin notes)
     * add cumulative balance column

Calculation
     * list of all entries related to the account into the date filter selection

== Partner balance ==
* Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Also available on the partner (automatic selection of the partner) => important if multi selection

* Calculation
     * selection of client vs supplier based on the internal account type
     * sum of all entries related to the account into the date filter selection group by partners

== Partner ledger ==
 * Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Add choice “open amount only / paid amount only / all entries”
     * Add sort option (date, entry number, amount, due date)
     * Also available on the partner (automatic selection of the partner)

* Calculation
     * add store field “last pmt date” => define if paid or date at a specific date
     * selection of client vs supplier based on the internal account type
     * list of entries group by client

Related branches

Changed in openobject-addons:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → 5.0.8
assignee: nobody → OpenERP Core Team (openerp)
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

I mark this bug as critical. I know some of the requirement are may be to be done as blueprint, but at least, we should be able to print out our general ledger & partner ledger for more than 50'000 entries !!!!

Please, before marking this bug as "whishlist", consider everything discussed in the Community meeting. OpenERP promise to fix at least the wrong calculation & the performance issues => WE STRONGLY NEED THIS.

We'll be here to answer every questions related to this topic, don't hesitate to ask. I also suggest to have a look into the Ferdinand's work about storing the period sums to avoid performance issues.

Thanks for considering this point.

Regards,

Revision history for this message
qdp (OpenERP) (qdp) wrote :

Hello Joel and Luc,

indeed the performance and calculation issues will be fixed in the stable version as promised, but we will be too short for 5.0.8 (should be released tomorrow). I set it for 5.0.9

Other points will be done in the trunk version only.

Regards,
Quentin

Changed in openobject-addons:
milestone: 5.0.8 → 5.0.9
Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote :

Just two notes:

  - There is already a bug describing the General Ledger Performance problems (https://bugs.launchpad.net/openobject-client-kde/+bug/514808). A small script for creating accounting entries for testing purposes (useful for creating thousands of moves) is attached there.

  - The performance problem is not only about the time it takes to generate the reports (with 10000 account moves it takes >30 minutes to generate a general ledger report), but also about the fact that there is no feedback to the user and that the operation will eventually timeout (leaving the user no way to get his report). I really think we should have a real 'progress status' dialog for large computations that might timeout otherwise. It's not that hard to implement it server-side for wizards*, and with a bit of work on the client side we could make it work for reports.

------------

(*) We just need to start the calculations on a background thread, and return the client a "still working (XX% done)" like form. The client might then ask the wizard to refresh (currently this can be done manually using a "keep waiting" like wizard button, but we might implement an autorefresh on the clients).
When the job is complete (the wizard computation is done or the report file has been generated) the wizard instead of returning a "still working" form, would return a "done" form or the generated report file or whatever is the output.

Is not nice if the user has to press a 'refresh' button, but this actually works and prevents timeouts. We used a trick like this to display the progress on the "spanish fiscal year closing" wizard when it takes more than 20 seconds (see this image: http://www.pexego.es/imagenes/openerp/cierre/c08.png and see the implementation here: http://bazaar.launchpad.net/~openerp-spain-team/openerp-spain/5.0/annotate/head%3A/l10n_es/l10n_ES_cierre_ejercicio/wizard/wizard_run.py)

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

I think the performance issue should be released ASAP. This means, if not for 5.0.8, we should make a release earlier for those kind of huge troubles !

My customers won't wait 1 month more to have his general ledger printed !!

Anthony Lesuisse said he would even fix this himself to ensure this is done as quick as possible. We would really appreciate this effort.

Thanks in advance,

Joël

Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello Joel,

I have attached a patch for General Ledger Report improvement in the following bug:
https://bugs.launchpad.net/openobject-addons/+bug/415789

Can you check and notify me?

Thanks.

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi vra,

Thanks for your work. This seems to be much more fast now ! I think we cannot make better with rml...

A pitty we won't get the other asked modification for stable... This will simply means we need to re-code those reports our-self. Customers can't work with the actual report :(

We don't even have the cumulated balance on the general ledger...

Well, this is not you fault I think, so thanks for the work. Do you think we can have a compromise ? Like, porting the future report 6.0 as module for 5.0, and make them soon ? This seems fair to me regarding to the release policy...

This would be great as we really need those missing features to be able to use those reports on production instances...

Regards,

Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote :

As reported on https://bugs.launchpad.net/openobject-client-kde/+bug/514808 the new patch seems to halve the times.

The general ledger for 10000 moves that used to take 30 minutes, now takes 18 minutes. (This still gives timeout on the GTK/web clients).

Changed in openobject-addons:
milestone: 5.0.9 → 5.0.10
Revision history for this message
Luc Maurer @ Camptocamp (lmaurer-c2c) wrote :

Hello Everybody,

Many thanks for the work on the speed improvement it will help....

BUT, sorry Quentin, it is not possible to wait for the 6.0 version for the report content improvements => now some reports (specially the partner ledger) does simply not give the correct numbers => it is really a bug. Today it is simply not possible to use OpenERP for the ending process.......

Camptocamp has create ALL financial reports for the 4.2 version, I don't want to rebuilt them on each version......

As I know, there is no changes between the 5.0 and 6.0 version concerning the entries mechanism => please make the improvement for the 5.0 version and I am sure it will be easy to port it to the 6.0 version without many problems.

The advantage will be that we could test it with the 5.0 version in a production context and we will be sure it will work for the 6.0 version.......

PLEASE REALLY CONSIDER THIS BUG AS A 5.0 BUG => it is really important for the credibility of openerp in the future....

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi all,

I must say that I (obviously) agree with Luc ;) ! Joke put a side, I think that this issue is not a little one. People won't invest in an ERP which doesn't provide the right numbers or not conform to the law...

From that point, all financial report are not ok regarding to the law (at least in CH and FR).

As Luc said, we already did the job for 4.2, and it was a huge work ! I link to this post the concerned module in a zip file (contains 4 modules for 4.2). This could help to improve the existing (how do we compute stuff, what kind of option are we using in the wizard, etc...). I also put the c2c_fiscal_year_close module we did, as financial report are very related to this topic. Note that report in c2c_finance_report_extended are more complete even if they don't run with RML but with our c2c_reporting_tools module...

From there, and with a certain will of course, I think it's possible to have something good for 5.0 without spending weeks on them, just by taking what we've done !

So, I ask you OpenERP SA to consider this as a strong request from Partner side ! More over, you said you'll fix every troubles regarding Country related Accounting law & OpenERP, so we are in this case now !

Thanks in advance to consider our request seriously ! We will help as much as we can to help you if you need guidance through this process... just ask.

Best regards,

Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote :

By the way, I just noticed that the "Print Journal" ("Print General Journal", "Print Central Journal") reports where not mentioned.

Those reports are broken too:

  - If I select several journals (like all of them), and I select several periods (all of the periods of one fiscal year):
    => If any of those journals doesn't have moves at all, it will just raise an "No records found for your selection!" exception and won't allow me to continue.
    => If all the journals have at least a move on any period, and any of the journal-period pairs doesn't have moves, it will print an unparsed report (ouch!) and errors like this one will be printed on the log:
        [2010-04-07 16:56:55,282] ERROR:report:[18]: report :
        [2010-04-07 16:56:55,283] ERROR:report:[19]: Traceback (most recent call last):
        [2010-04-07 16:56:55,283] ERROR:report:[20]: File "/home/datos/Proyectos/openerp/openobject-server/current/bin/report/render/rml2pdf/utils.py", line 114, in _process_text
        [2010-04-07 16:56:55,283] ERROR:report:[21]: txt = eval(expr,self.localcontext)
        [2010-04-07 16:56:55,283] ERROR:report:[22]: File "<string>", line 1, in <module>
        [2010-04-07 16:56:55,283] ERROR:report:[23]: IndexError: list index out of range
        [2010-04-07 16:56:55,284] ERROR:report:[24]:
        [2010-04-07 16:56:55,284] ERROR:report:[25]: list index out of range
        [2010-04-07 16:56:55,284] ERROR:report:[26]: expr: formatLang(sum_credit(line[0].period_id.id, line[0].journal_id.id))

I think this is what should be done:

== Print *** Journal ==
 * Wizard
     * Let the user select journals without moves.
     * Add an option to print the moves by journal (like it does now) or together like there was a single journal (needed on countries like Spain [though we currently can work it around by using the account_financial_reports module])

* Calculation
     * Ignore journals without moves, and journal/periods without moves (don't try to print them).
     * If the "by journal" option was selected, print the moves grouped by journal. If not, print all the moves without grouping, but add a 'journal' column with a reference to the journal code.

Changed in openobject-addons:
milestone: 5.0.10 → 5.0.11
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

I'll report another bug for the stable release, this one will remain for the future 6.0 and I'll add details ASAP

Changed in openobject-addons:
milestone: 5.0.11 → 6.0
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :
Download full text (6.8 KiB)

Hi,

This is a Bug report on Financial reporting of OpenERP that has to be fixed for 5.0 in order to be "usable" in a real accounting context. All the following comments has been discussed with Fabien Pinckaers, Luc Maurer, Quentin De Paoli, and me.

We decided to fix those minimal requirements (fixes or improvements) in the stable and all "nice-to-have" for the 6.0. This bug report will be for 6.0. Here you find the one for 5.0 : https://bugs.launchpad.net/openobject-addons/+bug/583666

1. All financial reports
---------------------------
---------------------------

Wizard changes for all financial report
------------------------------------------------
Filter :
Filters have to be refactorized and period filters isn't working. Every reports should have same filtering options.
We need those filter :
- 'start date end date' and 'start period and end period'.
- No need for both options (the m2m period+date) => only by date / by period / none => by default “none”
- Period really based on period and not on dates => actually the filter by period does not consider period, but date of periods…. Select must be done on periode_id IN (ids).

IMPROVE SPEED
-----------------------
100'000 Account move line should be printed out in less than the OpenERP-Client timeout !

Especially in :
- the General Ledger
- the Aged Partner Balance

2.Account balance
------------------------
------------------------

Mandatory/bugs => 5.0.11
----------------------------------
Wizard:
Change filter like chapter 1

For 6.0 version
-------------------------
Wizard:
- add an option to have a new column “currency balance amount” => amount and currency code => check box
- add comparison with other fiscal year

Presentation:
- Add “currency balance amount” and “currency code” columns if related check box is active

3.General ledger
---------------------
---------------------

Mandatory/bugs => 5.0.11
----------------------------------
Presentation:
- Replace “balance amount” by “cumulative balance amount” and make a cumulative total for each line

For 6.0 version
-------------------
- add “with opening balance" => to have a new line with the sum of all entries that are before the begin date/periode used for the filter
- Use the “Display history” check box => add a new select field (see quentin notes)

4.Partner balance
---------------------------
---------------------------

Mandatory/bugs => 5.0.11
----------------------------------
Wizard:
- Set the default value for “fiscal year” = actual fiscal year (year that contain the actual date).
- add "balance date" => by default = actual date
- add new option for the moves selection : “partner with movement / balance <> 0 / all” => by default = “balance <>0”
- add a new check box “with starting balance” => by default “true” that report the starting balance
- Make it also available on the partner (automatic selection of the partner) => important to have good informations (take care if multi-selection to select all)

Presentation :
- same layout than general ledger and account balance

Calculation:
- selection of client vs supplier accounts based on the internal account type
- add a new computed field “rec_max_date” o...

Read more...

summary: - Financial reports to review
+ Financial reports to review for 6.0
Revision history for this message
Ferdinand (office-chricar) wrote :

Please have a look at
* stable_5.0-extra-addons/account_financial_report with a lot of nice and usable reports

* https://code.launchpad.net/~openerp-commiter/openobject-addons/chricar_price_unit
account/account.py
here I have added computations for all necessary fields for yearly reports - this computation should be solved in a central place ad be used by all reports
(currently not yet working is multi-period selection)

IMPORTANT - this solution returns correct fiscal year numbers - especially initial balance regardless if previous fiscal years are open or closed !!
Nobody wants to close fiscal years until all closing work has been done
(may be some bugs ares still present)

Revision history for this message
Ferdinand (office-chricar) wrote :

BTW I use /bin/tools/translate.py from trunk in V5 and it seems to improve performance a lot as it seems to solve
https://bugs.launchpad.net/openobject-server/+bug/581800
please check/confirm

Revision history for this message
Eric Caudal - www.elico-corp.com (elicoidal) wrote :

I had to create for myself simple financial reports:
https://code.launchpad.net/~elicoidal

What I missed a lot in openerp is :
- a simple way to get a statement of income and financial position with different level of details
- flexible attributes for the accounts to build those reports (I created 2 levels within the user_type attribute)
- basic information in header such as date, accounted periods and report title.
- multicompany capabilities

Which I try to tweak in the above module

Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

I have tested V6 Financial reports and all my comments are in the attached doc file. Two things I would like to add:

1 - As I am new in the community, please keep in mind that I might have missed some information (although I had good catch up sessions with Luc & Joel).

2 - I have an accountant background and I have written this document from a business perceptive (What an finance person need to see on these reports)...

The list is long and could have been much longer but let's do it step by step.

Frederic at CamptoCamp

Revision history for this message
Ferdinand (office-chricar) wrote :

Hmm
 I just wonder
* c2c is supposed to produce new reports using their new reporting system - do you analyse old or new reports

* the module account_financial_report produces usable reports

* initial balance - every report must have initial balance (except P&L obviously) , regardless if previous periods are closed or not
** all these figures should be produced in account/account.py to be reused in all apps.
** see https://code.launchpad.net/~openerp-commiter/openobject-addons/chricar_price_unit

* tree structured reports
** these are currently not usable, because the structure is only defined by indents which nobody can follow over many pages
*** it is a MUST to have automatic structured numbering for each level
Example for indent numbering (as discussed with N. Bessi)
1.
1.2.
1.2.1.
1.2.2.
1.3.
1.3.1.
1.3.1.1

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :
Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

Frederic,

You did a great job. I reviewed your document and send to the developers for implementation.

I put my comments in dark bold in document. Keep in mind that if I strikeout some lines, it's not because it's a bad idea but simply because it does not fit our goals for v6.0. New features may be implemented for v6.1.

Thanks for the contribution.

Revision history for this message
Carlos Liebana (carlos-liebana) wrote : RE: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to review for 6.0
Download full text (3.5 KiB)

Off topic but related: About reports, in general, maybe it's about time to redesign them (in design terms). IMHO and also from the feedback of our implementations, standard reports (invoices, quotations, etc) in v5 are ugly.

-----Mensaje original-----
De: <email address hidden> [mailto:<email address hidden>] En nombre de Fabien (Open ERP)
Enviado el: lunes, 13 de septiembre de 2010 13:02
Para: <email address hidden>
Asunto: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to review for 6.0

Frederic,

You did a great job. I reviewed your document and send to the developers
for implementation.

I put my comments in dark bold in document. Keep in mind that if I
strikeout some lines, it's not because it's a bad idea but simply
because it does not fit our goals for v6.0. New features may be
implemented for v6.1.

Thanks for the contribution.

--
Financial reports to review for 6.0
https://bugs.launchpad.net/bugs/551630
You received this bug notification because you are a member of OpenERP
Accounting Experts, which is a direct subscriber.

Status in OpenObject Addons Modules: Confirmed

Bug description:
Hello,

As discuss during the community days, all financial reports have to be reviewed.

The list of modification has been created by Quentin, please ask him for more information => here are the most important things to change :

== Account balance ==

 * Wizard
     * add currency balance amount => check box
     * add comparison with other fiscal year
     * filter => only by date / by periode / none => from ... to for both date and period (period really based on period and not on dates)
     * filter => dependant to the fiscal year (only see period related to the fiscal year selected)

* Calculation
     * sum of all entries related to the account into the date filter selection

== General ledger ==
 * Wizard
     * add “with opening balance" => to have a new line with the sum of all entries that are before the begin date/periode
     * Use the “Display history” check box => add a new select field (see quentin notes)
     * add cumulative balance column

Calculation
     * list of all entries related to the account into the date filter selection

== Partner balance ==
* Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Also available on the partner (automatic selection of the partner) => important if multi selection

* Calculation
     * selection of client vs supplier based on the internal account type
     * sum of all entries related to the account into the date filter selection group by partners

== Partner ledger ==
 * Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Add choice “open amount only / paid amount only / all entries”
     * Add sort option (date, entry number, amount, due date)
     * Also available on the partner (automatic selection of the partner)

* Calculation
     * add store field “last pmt date” => define if paid or date at a specific date
     * selection...

Read more...

Revision history for this message
David Mitchell (www.novapointgroup.com) (david-novapointgroup.com) wrote : Re: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to review for 6.0
Download full text (7.2 KiB)

This is one reason why we're doing reports in Jasper using the
jasper_reports module when we can. The layout flexibility is very strong and
you can make very nice visual reports (invoice, etc), and even business
intelligence reports with embedded flash. We encourage everyone to check out
some of the capabilities of iReport as a designer. (It is used by OpenBravo,
OpenTaps, etc).
There are some areas where additional development is needed to improve the
interface between OpenERP and iReports, but it does work. We have it working
on v6 as well.

David Mitchell
NovaPoint Group
<email address hidden>

On Mon, Sep 13, 2010 at 7:27 AM, Carlos Liebana <email address hidden>wrote:

> Off topic but related: About reports, in general, maybe it's about time
> to redesign them (in design terms). IMHO and also from the feedback of
> our implementations, standard reports (invoices, quotations, etc) in v5
> are ugly.
>
> -----Mensaje original-----
> De: openerp-expert-accounting-bounces+carlos.liebana=ting.es@
> lists.launchpad.net [mailto:
> openerp-expert-accounting-bounces+carlos.liebana<openerp-expert-accounting-bounces%2Bcarlos.liebana>
> =<email address hidden>] En nombre de Fabien (Open ERP)
> Enviado el: lunes, 13 de septiembre de 2010 13:02
> Para: <email address hidden>
> Asunto: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to
> review for 6.0
>
> Frederic,
>
> You did a great job. I reviewed your document and send to the developers
> for implementation.
>
> I put my comments in dark bold in document. Keep in mind that if I
> strikeout some lines, it's not because it's a bad idea but simply
> because it does not fit our goals for v6.0. New features may be
> implemented for v6.1.
>
> Thanks for the contribution.
>
> --
> Financial reports to review for 6.0
> https://bugs.launchpad.net/bugs/551630
> You received this bug notification because you are a member of OpenERP
> Accounting Experts, which is a direct subscriber.
>
> Status in OpenObject Addons Modules: Confirmed
>
> Bug description:
> Hello,
>
> As discuss during the community days, all financial reports have to be
> reviewed.
>
> The list of modification has been created by Quentin, please ask him for
> more information => here are the most important things to change :
>
> == Account balance ==
>
> * Wizard
> * add currency balance amount => check box
> * add comparison with other fiscal year
> * filter => only by date / by periode / none => from ... to for both
> date and period (period really based on period and not on dates)
> * filter => dependant to the fiscal year (only see period related to
> the fiscal year selected)
>
> * Calculation
> * sum of all entries related to the account into the date filter
> selection
>
> == General ledger ==
> * Wizard
> * add “with opening balance" => to have a new line with the sum of all
> entries that are before the begin date/periode
> * Use the “Display history” check box => add a new select field (see
> quentin notes)
> * add cumulative balance column
>
> Calculation
> * list of all entries related to the account into the date filter
> selection
>
> == Partner...

Read more...

Revision history for this message
Hervé Proust - www.kazacube.com (hproust) wrote :

Hello,

I see improvements on an issue I consider as critical for the future of OpenERP (quality, fiability and coverage of financial reports and also good level of performance, i.e. capacity to print a general ledger without timeout...). We agree mostly with requests from c2c.

Some additional comments:
- Account balance: initial balance is requested by our certified accountant on one single report (and not by generating one report per fiscal year)
  * Fiscal year report: if the report shows the full year N, the initial balance should be equal to balance beginning of year N (= opening entries for balance sheet accounts)
  * Period report: if the report is limited to one period N, the initial balance should be equal to balance end of period N-1 (for all acounts..., but only for the running fiscal year for income statement accounts. That is where I guess it becomes tricky... )
- Translation: trial balance = general balance (and not "solde de compte" in standard french.po)
- Comparison of yearly results: is it possible or planned to add "comparison" reports as proposed by the module "Account_balance_compare years" to the standard reports? (which would be presented in columns and not in two reports in one)
- Layout: is it possible to edit reports with thousands separators?
- Tax report: did you consider modifying the tax report which does not calculate correctly partial payments for payment based VAT declaration? cf. 587707 Print Taxes Report Base on Payments

Best regards

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :
Download full text (10.7 KiB)

Guys,

juts a remark: iReport is probably better than anything we had previously in
OpenERP indeed. That being said, I think the ultimate report engine is
rather BIRT:
http://www.infoq.com/articles/birt2-intro
Pentaho/iReport and Jasper have some advantages over BIRT like metadata (do
we have a Jasper or Pentaho metadata "provider" for OpenERP or do you plug
it directly on the DB?), but there are even guys now attempting to plug BIRT
over Pentaho metadata and I think this could be great:
http://www.osbi.fr/?p=1664

Regards,

Raphaël Valyi
Founder and ERP Consultant
+55 21 3010 9965
http://www.akretion.com

<http://www.akretion.com.br/>
<http://www.osbi.fr/?p=1664>

On Mon, Sep 13, 2010 at 8:43 AM, David Mitchell (www.novapointgroup.com) <
<email address hidden>> wrote:

> This is one reason why we're doing reports in Jasper using the
> jasper_reports module when we can. The layout flexibility is very strong
> and
> you can make very nice visual reports (invoice, etc), and even business
> intelligence reports with embedded flash. We encourage everyone to check
> out
> some of the capabilities of iReport as a designer. (It is used by
> OpenBravo,
> OpenTaps, etc).
> There are some areas where additional development is needed to improve the
> interface between OpenERP and iReports, but it does work. We have it
> working
> on v6 as well.
>
> David Mitchell
> NovaPoint Group
> <email address hidden>
>
> On Mon, Sep 13, 2010 at 7:27 AM, Carlos Liebana
> <email address hidden>wrote:
>
> > Off topic but related: About reports, in general, maybe it's about time
> > to redesign them (in design terms). IMHO and also from the feedback of
> > our implementations, standard reports (invoices, quotations, etc) in v5
> > are ugly.
> >
> > -----Mensaje original-----
> > De: openerp-expert-accounting-bounces+carlos.liebana=ting.es@
> > lists.launchpad.net [mailto:
> >
> openerp-expert-accounting-bounces+carlos.liebana<openerp-expert-accounting-bounces%2Bcarlos.liebana>
> > =<email address hidden>] En nombre de Fabien (Open ERP)
> > Enviado el: lunes, 13 de septiembre de 2010 13:02
> > Para: <email address hidden>
> > Asunto: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to
> > review for 6.0
> >
> > Frederic,
> >
> > You did a great job. I reviewed your document and send to the developers
> > for implementation.
> >
> > I put my comments in dark bold in document. Keep in mind that if I
> > strikeout some lines, it's not because it's a bad idea but simply
> > because it does not fit our goals for v6.0. New features may be
> > implemented for v6.1.
> >
> > Thanks for the contribution.
> >
> > --
> > Financial reports to review for 6.0
> > https://bugs.launchpad.net/bugs/551630
> > You received this bug notification because you are a member of OpenERP
> > Accounting Experts, which is a direct subscriber.
> >
> > Status in OpenObject Addons Modules: Confirmed
> >
> > Bug description:
> > Hello,
> >
> > As discuss during the community days, all financial reports have to be
> > reviewed.
> >
> > The list of modification has been created by Quentin, please ask him for
> > more information => here are the most importan...

Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote : Re: [Bug 551630] Re: Financial reports to review for 6.0

Hervé Proust - www.kazacube.com escribió:
> Hello,
>
> I see improvements on an issue I consider as critical for the future of
> OpenERP (quality, fiability and coverage of financial reports and also
> good level of performance, i.e. capacity to print a general ledger
> without timeout...). We agree mostly with requests from c2c.
>
> Some additional comments:
> - Account balance: initial balance is requested by our certified accountant on one single report (and not by generating one report per fiscal year)
> * Fiscal year report: if the report shows the full year N, the initial balance should be equal to balance beginning of year N (= opening entries for balance sheet accounts)
> * Period report: if the report is limited to one period N, the initial balance should be equal to balance end of period N-1 (for all acounts..., but only for the running fiscal year for income statement accounts. That is where I guess it becomes tricky... )
>

On the 5.0 you have a module called account_financial_report that gives
you extra reports, like a 'full balance' report that shows the balance
on a given period and the full year:

> - Comparison of yearly results: is it possible or planned to add "comparison" reports as proposed by the module "Account_balance_compare years" to the standard reports? (which would be presented in columns and not in two reports in one)
>
On 5.0, you have the account_balance_reporting module, that lets create
report templates for comparisons of two fiscal years/periods:

Selecting the template (official Spanish templates are available for the
Spanish localization) and fiscal years / periods:

Calculated data:

Printed example (everything):

Printed example (non-zero):

Sample P&L template (taken from Spanish localization) - Template
information:

Sample P&L template - Template lines:

Note: A formula like "760,761" means 'the balance of the account with
code 760 plus the balance of the account with code 761", parenthesis
might be used to negate the values. A formula like "49300+41900" means
"the sum of the line with code 49300 and the line with code 41900".

Maybe some of this reports (the ones account_financial_report provides)
could be integrated into the standard accounting reports in the future
6.X versions...

Best regards.

--
Borja López Soilán
<email address hidden>

Pexego Sistemas Informáticos S.L.
Avenida de Magoi 66 - 27002 Lugo (España)
Tel./Fax 982801517
http://www.pexego.es

AVISO LEGAL - CLÁUSULA DE PRIVACIDAD
Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o confidencial. Si no es usted el destinatario indicado, queda informado de que la utilización, divulgación y/o copia sin autorización está prohibida en virtud de la legislación vigente. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción.

Revision history for this message
Gibson Wasukira (gwasukira) wrote :
Download full text (3.8 KiB)

Hullo All,
Sorry probably cross posting,Is it possible to generate account statements
for suppliers whose transactions are done in foreign currencies?
Say if purchase orders are in USD,invoices are paid in USD.Then these
shouldnt be converted into the company currency.Account statement should
have the foreign currency(USD)
Regards
Gibson

On Mon, Sep 13, 2010 at 5:54 PM, Borja López Soilán (Pexego) <
<email address hidden>> wrote:

> ** Attachment added: "balance-en-01.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578041/+files/balance-en-01.png
>
> ** Attachment added: "balance-en-03.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578042/+files/balance-en-03.png
>
> ** Attachment added: "pyg-en-01.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578043/+files/pyg-en-01.png
>
> ** Attachment added: "pyg-en-02.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578044/+files/pyg-en-02.png
>
> ** Attachment added: "pyg-en-06.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578045/+files/pyg-en-06.png
>
> ** Attachment added: "pyg-en-07.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578046/+files/pyg-en-07.png
>
> ** Attachment added: "pyg-en-04.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578047/+files/pyg-en-04.png
>
> ** Attachment added: "pyg-en-05.png"
>
> https://bugs.launchpad.net/bugs/551630/+attachment/1578048/+files/pyg-en-05.png
>
> --
> Financial reports to review for 6.0
> https://bugs.launchpad.net/bugs/551630
> You received this bug notification because you are subscribed to
> OpenObject Addons.
>
> Status in OpenObject Addons Modules: Confirmed
>
> Bug description:
> Hello,
>
> As discuss during the community days, all financial reports have to be
> reviewed.
>
> The list of modification has been created by Quentin, please ask him for
> more information => here are the most important things to change :
>
> == Account balance ==
>
> * Wizard
> * add currency balance amount => check box
> * add comparison with other fiscal year
> * filter => only by date / by periode / none => from ... to for both
> date and period (period really based on period and not on dates)
> * filter => dependant to the fiscal year (only see period related to
> the fiscal year selected)
>
> * Calculation
> * sum of all entries related to the account into the date filter
> selection
>
> == General ledger ==
> * Wizard
> * add “with opening balance" => to have a new line with the sum of all
> entries that are before the begin date/periode
> * Use the “Display history” check box => add a new select field (see
> quentin notes)
> * add cumulative balance column
>
> Calculation
> * list of all entries related to the account into the date filter
> selection
>
> == Partner balance ==
> * Wizard
> * add "balance date"
> * add new selection “partner with movement / balance <> 0 / all
> * Also available on the partner (automatic selection of the partner) =>
> important if multi selection
>
> * Calculation
> * selection of client vs supplier based on the internal account type
> * sum of all entries related to the account into t...

Read more...

Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello All,

We have improved Accounting Reports as suggested by Frederic and reviewed by Fabien Pinckaers.

Thank you,
Mustufa

Revision history for this message
Ferdinand (office-chricar) wrote :

please see my recent bug reports regarding
still in addons r 4993 server 2782

https://bugs.launchpad.net/bugs/645953
https://bugs.launchpad.net/bugs/645954
https://bugs.launchpad.net/bugs/645961
https://bugs.launchpad.net/bugs/645969
https://bugs.launchpad.net/bugs/645964

most are claimed to be fixed but not available in trunk

Revision history for this message
Mohammed (gaafer5) wrote : Re: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to review for 6.0

Hello,

What about implementing/ migrating these improvement for V 5.0.15?

Is it planned on the roadmap

Thanks
Gaafer

--- On Sun, 9/26/10, mra (Open ERP) <email address hidden> wrote:

From: mra (Open ERP) <email address hidden>
Subject: [Openerp-expert-accounting] [Bug 551630] Re: Financial reports to review for 6.0
To: <email address hidden>
Date: Sunday, September 26, 2010, 11:38 PM

Hello All,

We have improved Accounting Reports as suggested by Frederic and
reviewed by Fabien Pinckaers.

Thank you,
Mustufa

--
Financial reports to review for 6.0
https://bugs.launchpad.net/bugs/551630
You received this bug notification because you are a member of OpenERP
Accounting Experts, which is a direct subscriber.

Status in OpenObject Addons Modules: In Progress

Bug description:
Hello,

As discuss during the community days, all financial reports have to be reviewed.

The list of modification has been created by Quentin, please ask him for more information => here are the most important things to change :

== Account balance  ==

* Wizard
     * add currency balance amount => check box
     * add comparison with other fiscal year
     * filter => only by date / by periode / none => from ... to for both date and period (period really based on period and not on dates)
     * filter => dependant to the fiscal year (only see period related to the fiscal year selected)

* Calculation
     * sum of all entries related to the account into the date filter selection

== General ledger ==
* Wizard
     * add “with opening balance" => to have a new line with the sum of all entries that are before the begin date/periode
     * Use the “Display history” check box => add a new select field (see quentin notes)
     * add cumulative balance column

Calculation
     * list of all entries related to the account into the date filter selection

== Partner balance ==
* Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Also available on the partner (automatic selection of the partner) => important if multi selection

* Calculation
     * selection of client vs supplier based on the internal account type
     * sum of all entries related to the account into the date filter selection group by partners

== Partner ledger ==
* Wizard
     * add "balance date"
     * add new selection “partner with movement / balance <> 0 / all
     * Add choice “open amount only / paid amount only / all entries”
     * Add sort option (date, entry number, amount, due date)
     * Also available on the partner (automatic selection of the partner)

* Calculation
     * add store field “last pmt date” => define if paid or date at a specific date
     * selection of client vs supplier based on the internal account type
     * list of entries group by client

_______________________________________________
Mailing list: https://launchpad.net/~openerp-expert-accounting
Post to     : <email address hidden>
Unsubscribe : https://launchpad.net/~openerp-expert-accounting
More help   : https://help.launchpad.net/ListHelp

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Dear all,

First thanks for the job, we'll review those improvements ASAP. I also targeted the backport of those report for the 5.0.15 milestones (https://bugs.launchpad.net/openobject-addons/+bug/583666). I think this come to be very important for everyone to have those reports working on v.5.0.

So please, do not forget to make them available on V5.0 stable version. Let us know if we can help.

Thanks in advance,

Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

We have finished testing new financial reports on the 6.0. I must say that it is a big step forward.

Quick summary of what we like the most:
- Chart of account can be filtered by period
- All filters in reports works fine. On all reports, you can select periods and posted/draft entries.
- Layout printout issues have been solved
- "Initial balance" checkbox on General Ledger works perfectly (unticked by default)
- General Ledger and Trial balance are now correct
- And performance has been improved (although we have not done testings with many entries)

Now... what still does not work? Partner reports initial balance

- There is an "Initial balance" checkbox for the Partner ledger but works only for Partners with transactions during current FY. If there is no move entry during the current year, the initial balance (IB) is simply not shown (neither the partner).
- Opening entries do not appear on the report. (I must specify that the deferral method selected is "unreconciled" for creditors and debtors but does not generate opening entries split by partner ; I see only one grouped entry line with empty partner column. (see my bug report 655595)
On that point, I need clarification please : I think that the partner ledger will work only if the deferral method for debtors & creditors is "unreconciled" otherwise impossible to get initial balance for each partner - is it correct?

- Small layout problem: on partner ledger, please increase size of column "currency" - we do not want to see the currency symbol on a new line.

And a final comment, I did not test centralized and general Journal but I think both reports give exactly the same report.

I leave apart the aged partner report for the moment (we need a fixed partner ledger first)

Thanks to OpenERP team for this excellent job.

We are getting closer and closer to what we need... !

Frederic

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Dear all,

Just wanted to know about the last testing report from Frédéric : is there enough details for you to fix the last remaining troubles ?

We really need to backport those reports into the V5.0 at the end of the month (final deadline), so please consider our feedback and let us know if something need more details or explanation.

Till there, I really want to thank you for the quality of your job. We're really close to have the best financial report ever on OpenERP :) !

Best regards,

Joël

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Frédéric,

As you point the three problem on the comment #30.

- There is an "Initial balance" checkbox for the Partner ledger but works only for Partners with transactions during current FY. If there is no move entry during the current year, the initial balance (IB) is simply not shown (neither the partner). => Fixed with lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch and the branch will be merged with trunk addons soon.

- Opening entries do not appear on the report. (I must specify that the deferral method selected is "unreconciled" for creditors and debtors but does not generate opening entries split by partner ; I see only one grouped entry line with empty partner column. (see my bug report 655595) => Not getting your problem can you please explain ?

- Small layout problem: on partner ledger, please increase size of column "currency" - we do not want to see the currency symbol on a new line. => We can not fixed this => Because we do not have much space more on our report if we tried to correct this it breaks other columns (Use Landscape mode :) )

thanks.

Revision history for this message
Ferdinand (office-chricar) wrote :

1) unfortunatley - column headers are printed only on the first page - a long outstanding issue.
will this be fixed ?

2) no initial/opening balance for general ledger ?
at least as long the old fiscal year is not closed ?

IMHO for accountants a "balance" must always show and include the initial/opening balance because otherwise it's not a "balance" but an intermediate sum of moves.

I have tried to explain this multiple times
* cash/bank accounts can be closed a few days after the beginnning of the new fiscal year.
* all other accounts will be closed only after 3-6 month after the beginning of the new fy
** a modern accounting system must be able to show the (current) initial balance regardless if the previous fiscal year is closed or not

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Ferdinand,

          For your second point there is initial/opening balance available with general ledger.

thanks.

Revision history for this message
Ferdinand (office-chricar) wrote :

unfortunatley not :-(

IMHO

1) initial/opening balance of P&L accounts (close_method=none) must NOT be included
2) inital/opening balance must always be included (if checked - should be default) regardless of the settings of "Display accounts"

to reduce output - especially for SME - "With balance is not equal to 0" should be default.
these companies may use only 20-30 % of the accounts of a standard chart.

please "With balance is not equal to 0" should check for balance, debit and credit (including rounding)
imagine
initial = 100
credit = 100
balance = 0

such accounts must be displayed

Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote : Re: [Bug 551630] Re: Financial reports to review for 6.0
Download full text (4.8 KiB)

Hello,

Please, see my comments in red below:

>
>
> - There is an "Initial balance" checkbox for the Partner ledger but works
> only for Partners with transactions during current FY. If there is no move
> entry during the current year, the initial balance (IB) is simply not shown
> (neither the partner). => Fixed with
> lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch and the branch
> will be merged with trunk addons soon....***Excellent, works perfectly now
>
>
> - Opening entries do not appear on the report. (I must specify that the
> deferral method selected is "unreconciled" for creditors and debtors but
> does not generate opening entries split by partner ; I see only one grouped
> entry line with empty partner column. (see my bug report 655595) => Not
> getting your problem can you please explain ? ***Bug seems to be fixed
> since I could generate opening entries by partner - I am happy with numbers
> on all partner reports

- Aged Partner balance: when you have a payment not reconciled (but you
have the partner name on the entry), the system should allocated the payment
in the column "not due" by default instead of taking the payment date as due
date. Having an overdue payment is a non sens.

>
> - Small layout problem: on partner ledger, please increase size of
> column "currency" - we do not want to see the currency symbol on a new
> line. => We can not fixed this => Because we do not have much space more
> on our report if we tried to correct this it breaks other columns (Use
> Landscape mode :) ) ***Fine
>

- About GL report : Initial balance should be calculated from begining of
the Fiscal year for P&L accounts (=deferral method: none) - For B/S account,
it is ok - (I am pretty sure this was Ok 2 weeks ago...strange)

- Layout : on all financial reports, we need to have column titles on every
single page of the report and not the 1st one only.

- For all fi. reports, it would be good that in the filter "display
accounts" shows "With balance is not equal to 0" by default

- and a small detail on P/L report : could you just call bottom line "Net
Profit" instead of "Net profit C.F.B.L"

Saying that, excellent work on Partner reports, it was not the easiest
reports to make.

Frederic

>
> thanks.
>
> --
> Financial reports to review for 6.0
> https://bugs.launchpad.net/bugs/551630
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in OpenObject Addons Modules: In Progress
>
> Bug description:
> Hello,
>
> As discuss during the community days, all financial reports have to be
> reviewed.
>
> The list of modification has been created by Quentin, please ask him for
> more information => here are the most important things to change :
>
> == Account balance ==
>
> * Wizard
> * add currency balance amount => check box
> * add comparison with other fiscal year
> * filter => only by date / by periode / none => from ... to for both
> date and period (period really based on period and not on dates)
> * filter => dependant to the fiscal year (only see period related to
> the fiscal year selected)
>
> * Calculation
> * sum of all entries related to the account ...

Read more...

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Frederic,

- Aged Partner balance: when you have a payment not reconciled (but you
have the partner name on the entry), the system should allocated the payment
in the column "not due" by default instead of taking the payment date as due
date. Having an overdue payment is a non sens. => Need to check ...

- About GL report : Initial balance should be calculated from begining of
the Fiscal year for P&L accounts (=deferral method: none) - For B/S account,
it is ok - (I am pretty sure this was Ok 2 weeks ago...strange) => We will check it

- Layout : on all financial reports, we need to have column titles on every
single page of the report and not the 1st one only. => Yes we are working on it

- For all fi. reports, it would be good that in the filter "display
accounts" shows "With balance is not equal to 0" by default.. => We need experts suggestion on this ... can anyone confirm ?

- and a small detail on P/L report : could you just call bottom line "Net
Profit" instead of "Net profit C.F.B.L" => We will check it

Thank you,
mustufa

Changed in openobject-addons:
assignee: OpenERP Core Team (openerp) → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Accounting Experts,

I have recently fixed one bug on Partner ledger report on lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch and it will merge with trunk addons soon.

       - If i have one invoice with Date and period with January-2010 (old) and it is already recoiled/paid.
       - Now i print the report with Include initial balance option ticked and filter by periods + include Reconciled entries Ticked
                  - Start period => Sep-2010
                  - End period => Dec-2010

       - If i look in the report -> i can not found that reconciled amount for the partner on Initial balance row.

Thank you,
Mustufa (mra)

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello,

We have changed "Net Profit" instead of "Net profit C.F.B.L" in p&l and b&s reports.

Thank you,
Mustufa (mra)

qdp (OpenERP) (qdp)
Changed in openobject-addons:
milestone: 6.0 → none
Changed in openobject-addons:
milestone: none → 6.0-rc2
Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

on the Administration / Company / company menu / tab 'configuration' I cannot set the P&L account because I think the filter does not allow me to select none payables account.
==> I cannot use P&L and B&S financial reports

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Frederic,

We can open Accounts where type=Regular for the Reserve & Profit&loss account field on company.

I am attaching the patch here can you please test and tell us.

Thank you,
Mustufa (mra)

Revision history for this message
Frederic Clementi - Camptocamp (frederic-clementi) wrote :

Patch works fine.
Thanks mustafa.

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Frederic,

Yes i have fixed in Addons3 branch.

Thank you

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

I think this bug is closed.

If we missed something, I would suggest to open a new bug with only the description of the bug.

Changed in openobject-addons:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.