[patch] "help quiet" in grub console causes segmentation fault

Confirmed on Ubuntu 6.10.

debug output from gdb with a debug build.

The help text for "quiet" should not be available on the command line, and is not compiled in, and things break when it tries to print it anyway. It is only available from the menu.lst file.

The patch fixes the problem, this is a patch against the debian/patches/quiet.diff

Eventually I think it should rather be like this:

static struct builtin builtin_quietboot =
{
  "quiet",
  quietboot_func,
  BUILTIN_CMDLINE | BUILTIN_HELP_LIST,
  "quietboot",
  "Quiet boot messages."
};

I don't know why the help strings were ifdef'd away.

grub (0.97-29ubuntu1) gutsy; urgency=low

  * Merge from Debian unstable. Remaining Ubuntu changes:
    - debian/control: build-depends on libc6-dev and gcc-3.4
    - debian/control: depends on volumeid, provides linux-boot-loader
    - debian/rules: use gcc-3.4
    - debian/patches/grub-install_storeversion.diff
    - debian/patches/quiet.diff
    - debian/patches/gpt.diff
    - debian/patches/grub-0.95-mem_lower.patch
    - debian/update-grub: assorted Ubuntu tweaks
      - use printf instead of echo -e
      - split up warning about missing /boot/grub
      - is_removable device handling
      - crashdump handling
      - get default root device from /etc/fstab
      - rename title to "Ubuntu"
      - quiet and splash default defoptions
      - rename "single-user" to "recovery"
      - timeout/hiddenmenu/colours defaults
      - robust oldversion handling
      - don't treat memtest as a kernel
      - convert_kopt_to_uuid
      - kopt_2_6 handling
      - remove freebsd support
    - configure.ac: -fno-strict-aliasing
    - debian/grub.postinst: run update-grub on upgrade from dapper
  * debian/patches/quiet.diff: Fix "help quiet" segfault (LP: #60163)
  * debian/update-grub: New "savedefault" automagic option (default: false)
    for adding the savedefault command to menu entries (LP: #66278)

 -- Tormod Volden <email address hidden> Fri, 29 Jun 2007 16:38:06 +0200