Scripts in os-post/ don't get executed on installation

Bug #602414 reported by Mario Limonciello
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dell-recovery (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Chris Gregan

Bug Description

Binary package hint: dell-recovery

Version: 0.58

Summary:
Because of the way that /usr/share/dell/scripts/non-negotiable/00-dkms-autoinstaller.sh gets executed during installation, it seems that dell-recovery does not execute any additional scripts in /cdrom/scripts/os-post.

Impact:
This means that documentation may not be copied onto the target system and that the timezone may be improperly set.

Steps to Reproduce:
1) Build recovery media using the latest stable version of dell-recovery (0.58 at the time of this bug)
2) Add a docs/blah.pdf to the recovery media.
3) Install from that recovery media
4) Observe that documentation is not populated on the target system

Regression Potential:
None to users with dell-recovery already installed. This code path is only used when running an installation or reinstallation.
For people running dell-recovery for installation, additional post install scripts may need some modifications if they were working around this behavior.

Changed in dell-recovery (Ubuntu):
status: New → Fix Committed
Changed in dell-recovery (Ubuntu Lucid):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dell-recovery - 0.60

---------------
dell-recovery (0.60) maverick; urgency=low

  * When genisoimage fails, be more informative in it's error message
    to the user about why it may have failed.
  * Merge translations from launchpad.
  * Mark some more strings translatable that previously weren't.
  * For FISH scripts, just execute them rather than special casing python and
    shell. This means all scripts need #!/bin/sh or #!/bin/python at the top.
  * If FIST is found, don't extract the UP. This means factory process ( of
    some sort )
  * Reverse the order of calling /tmp/set_active_partition and SUCCESS_SCRIPT
    to prevent problems with BTO Anywhere.
  * When calling scripts in non-negotiable, don't use exec. (LP: #602414)
  * Update for deprecated isInstalled to use is_installed instead.
  * Add a new tri-state knob for configuring the behavior of swap
    dell-recovery/swap = (true, [dynamic], false)
    - false will force swap on
    - false will force swap off
    - dynamic (default) will detect small drives (<=64GB). If one of these
      is found, disable the creation of a swap partition. (LP: #601780)
  * Disable terminal spawning if debug-ubiquity mode is enabled since the
    same effect can be achieved with ctrl-alt-T.
  * Drop support for running in virtualbox. If it's actually desirable, vbox
    has support to modify the DMI information.
  * For grub conffiles, write out in the new 10.10 syntax when working with
    newer media.
  * Write out a UUID to search for in the grub conffile in the event that it's
    not actually on hd0.
 -- Mario Limonciello <email address hidden> Thu, 17 Jun 2010 15:09:45 -0500

Changed in dell-recovery (Ubuntu):
status: Fix Committed → Fix Released
description: updated
Revision history for this message
John Dong (jdong) wrote :

ACK from ubuntu-sru

Revision history for this message
Jonathan Riddell (jr) wrote : Please test proposed package

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Mario Limonciello (superm1) wrote :

I've verified this fixed the problem for me, Canonical OEM QA (who originally discovered it) should do a test run with it still.

Changed in dell-recovery (Ubuntu Lucid):
status: Fix Committed → New
assignee: nobody → Chris Gregan (cgregan)
Revision history for this message
James Ferguson (jamesf) wrote :

Tested the new package and everything seems to go well - all scripts in fish and os-post run, with the non-negotiable scripts run in between.

Martin Pitt (pitti)
Changed in dell-recovery (Ubuntu Lucid):
status: New → Fix Committed
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dell-recovery - 0.58.1

---------------
dell-recovery (0.58.1) lucid-proposed; urgency=low

  * Cherry pick from trunk:
    - For FISH scripts, just execute them rather than special casing python and
      shell. This means all scripts need #!/bin/sh or #!/bin/python at the top.
    - When calling scripts in non-negotiable, don't use exec. (LP: #602414)
    - Reverse the order of calling /tmp/set_active_partition and SUCCESS_SCRIPT
      to prevent problems with BTO Anywhere.
    - If FIST is found, don't extract the UP. This means factory process ( of
      some sort )
 -- Mario Limonciello <email address hidden> Wed, 07 Jul 2010 14:29:10 -0500

Changed in dell-recovery (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.