Recognize uxlaunch as a display manager

On Fri, Jul 23, 2010 at 02:06:18PM -0000, Michael Terry wrote:
> Here's a patch to treat it like the other display managers plymouth
> knows about. Seems like this should be made generic in the future?

The only way I see to make this generic on the plymouth side would be to
require all the dms' upstart jobs emit a common upstart event in a pre-start
script?

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Agreed. And in fact, ubiquity and oem-config do emit starting-dm. gdm claims to do so, but doesn't have any code to.

On Fri, Jul 23, 2010 at 03:55:36PM -0000, Michael Terry wrote:
> Agreed. And in fact, ubiquity and oem-config do emit starting-dm. gdm
> claims to do so, but doesn't have any code to.

The existing starting-dm event is unsuitable for this, as it's emitted by
old versions of DMs that do *not* signal plymouth in the required manner.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

The patch looks good. Subscribed ubuntu-sponsors so that they handle it.
(btw, I agree this should be generic, but for now, adding this won't do much, right?)

Steve, could you upload the patch if you think it's correct or unsubscribe the sponsors otherwise?

Thanks Mike, this looks fine! Committed to bzr with adding this bug ref to the changelog.

I don't upload this yet, as the current bzr head version looks really bad now. This might be related to Steve's previous changes to the backends, and needs debugging first.

This bug was fixed in the package plymouth - 0.8.2-2ubuntu7

---------------
plymouth (0.8.2-2ubuntu7) natty; urgency=low

  [ Steve Langasek ]
  * Refactor ubuntu-text theme to allow setting colors and text via settings
    in the plymouth theme file, and have plymouth-theme-kubuntu-text depend
    on ubuntu-text instead of duplicating the code.
  * Bump the version strings from 10.10 to 11.04. LP: #683994.

  [ Michael Terry ]
  * debian/plymouth.plymouth-stop.upstart,
    debian/plymouth.upstart:
    - Recognize uxlaunch as a display manager. (LP: #609163)
 -- Steve Langasek <email address hidden> Fri, 03 Dec 2010 15:06:17 -0800