include /usr/bin link, desktop file, and system menu entry

The linked branch and the patch includes a symlink and a desktop file as suggested.

As regards the comparison with logout, shutdown etc., I'm not convinced. Even if there are similarities from a technical point of view, from a user perspective I believe that the guest session feature is more like an application. The desktop file I added makes an item appear under Applications -> System Tools, which I think reflects the nature of gdm-guest-session fairly well.

Hide menu item within guest sessions

The /usr/bin/ symlink is fine, but adding a desktop file with user visible strings is more work. It needs to be a .desktop.in file, and gdm-guest-session would need to grow an intltool setup, so that the desktop file can be translated properly.

Martin,
As regards translation, I took a short cut and simply pointed to the textdomain of indicator-session, which seems to work fine. Is it still a must to do it the hard way? ;-)

Oh, indeed I missed that. I guess that's okay for an Ubuntu specific package like gdm-guest-session :)

But shouldn't we hide the menu entry by default? It's usually in the session indicator menu, and the system menu is already crowded enough; I wouldn't like to aggravate that by adding duplicate information.

We could hide it by default, and then people can unhide it with the menu editor. Does that sound acceptable for you?

This bug was fixed in the package gdm-guest-session - 0.19

---------------
gdm-guest-session (0.19) natty; urgency=low

  * Do not launch if screenlocking fails (LP: #600559)
  * Provide /usr/bin/ symlink and (hidden by default) desktop file
    (LP: #615301)
 -- Gunnar Hjalmarsson <email address hidden> Thu, 11 Nov 2010 08:51:05 +0100

While I do see the logic in not duplicating, it's not in the System menu it appears, it's in Applications -> System Tools (not very crowded). I think that the guest session feature is not obviously comparable with logout, restart etc., and that it would have deserved the improved visibility. But of course it's acceptable to me; after all it was you who wrote the thing.

I pull myself together for discussing ~/.profile on another topic. ;-) When are you ready for that?

Gunnar Hjalmarsson [2010-11-11 10:37 -0000]:
> While I do see the logic in not duplicating, it's not in the System menu
> it appears, it's in Applications -> System Tools (not very crowded).

In fact it should be empty. We don't want this menu in a default
installation, stuff should go into the System menu instead.
Unfortunately there are still packages which use this menu.

> I pull myself together for discussing ~/.profile on another topic. ;-)
> When are you ready for that?

Need to find some time, but RSN, promised!

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

Just a detail. I believe it should be

NoDisplay=true

(lower-case 't') to safely prevent displaying.

Gunnar,

right, I just uploaded version 20 to fix this. Thanks!

Martin