Ubuntu
fwts package

fwts FADT test is not checking correct table from /sys/firmware

Bug #627959 reported by Colin Ian King
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: fwts

FADT test should be pulling FADT table data from /sys/firmware/acpi/tables/FACP and not FADT. This bug crept in when moving from reading the tables from the output from acpidump to reading the data directly from /sys/firmware

Also, reading the GAS data from the FADT was not fully implemented, so the tests failed even when the ACPI data was correct.

Related branches

lp:ubuntu/maverick/fwts
Colin Ian King (colin-king)
Changed in fwts (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Colin King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

A newer version 0.18.2 of the fwts tools is now available to fix this bug.

https://launchpad.net/~firmware-testing-team/+archive/ppa-firmware-test-suite/+sourcepub/1283167/+listing-archive-extra

Freeze Exception request:

a) A description of the proposed changes, with sufficient detail to estimate their potential impact on the distribution:

1. Version 0.18.2:
   Fix FADT test, which was reading the wrong ACPI table from /sys/firmware/acpi/tables and was not decoding FADT GAS data or 64 bit addresses correctly. Also added some extra address and port width information when FADT tests detect a mismatch in FADT table, otherwise the tests are not very useful when a test detects a failure.

b) A rationale for the exception, explaining the benefit of the change:

Will fix a broken FADT test.

c) Any additional information which would be helpful in considering the decision.

This is required for OEM firmware testing.

Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Bug fixes don't violate FF and UIF and thus don't need any exception. Unsubscribing u-release again.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Colin: Sponsors don't normally look at bugs with "Fix Comitted" or someone assigned.

Changed in fwts (Ubuntu):
assignee: Colin King (colin-king) → nobody
status: Fix Committed → Confirmed
Revision history for this message
Stefano Rivera (stefanor) wrote :

Oh, "Closes: #" is for Debian bugs. We use "LP: #"

Changed in fwts (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 0.18.02

---------------
fwts (0.18.02) maverick; urgency=low

  * FADT test read correct ACPI table from /sys/firmware (LP: #627959)
  * New upstream version 0.18.02
 -- Colin King <email address hidden> Wed, 1 Sep 2010 11:11:20 +0100

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Colin Ian King (colin-king) wrote :

Oops, please ignore my recent sponsorship request. My mistake on wrong bug.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Sponsors unsubscribed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.