PowerTOP: Remove hard coded values for C and P states

Bug #627975 reported by Amit Arora
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
powertop (Ubuntu)
Fix Released
Undecided
Martin Pitt
Maverick
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: powertop

This bug is being reported for PowerTOP (v1.13) on MAVERICK (10.10 release).

The problem with current PowerTOP tool is that it has hard coded values for P and C states. Because of this it doesn't show correct and complete information on non-intel architectures (like ARM) which may support more of these states than what intel has. Being part of the Linaro Power Management Work Group, one of the mission we have is to make PowerTOP work well on ARM SoCs too.

The patch suggested here removes these hard coded values and makes display subsystem of powertop aware of the actual number of C and P states available on the system and show them accordingly (i.e. reserve corresponding lines in the ncurses window to display these states, and also show all the states in the "dump" mode too). This change will make PowerTOP work well on ALL the architectures, and not just on x86.

The patch has been posted upstream and the maintainer has promised to look into it and reply back. Its in his one of the lower priority ToDo item. But, for us (Linaro) its of high priority, since PowerTOP on many ARM devices won't work (eg. on OMAP3, where number of C states can be upto 9 !).

Here is the link to the post : http://www.bughost.org/pipermail/power/2010-August/001961.html

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: powertop 1.11+git20091208-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic i686
Architecture: i386
Date: Wed Sep 1 15:23:21 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
ProcEnviron:
 PATH=(custom, no user)
 LANG=en_IN
 SHELL=/bin/bash
SourcePackage: powertop

Related branches

Revision history for this message
Amit Arora (amitarora) wrote :
Revision history for this message
Amit Arora (amitarora) wrote :

Please Note:
The report was triggered from my Lucid desktop, hence the version details are not valid in the debug information collected by "ubuntu-bug" tool. Please ignore it and us following details instead :
     InstallationMedia: Ubuntu 10.10, Maverick
     Package: powertop 1.13

Sorry for the confusion, if any!

summary: - Remove hard coded values for C and P states
+ PowerTOP: Remove hard coded values for C and P states
tags: added: patch
Revision history for this message
Amit Arora (amitarora) wrote :

The patch has been accepted upstream.
Here is the link : http://www.bughost.org/pipermail/power/2010-September/001984.html

And, here is the commit id in the powertop git tree : 0a8620213f1841af2ad46bb59e5cf57c305fc43a

Can this patch be included in the PowerTOP package, targeting the Maverick Ubuntu release ? Thanks!

Martin Pitt (pitti)
Changed in powertop (Ubuntu Maverick):
assignee: nobody → Martin Pitt (pitti)
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Where is the powertop git tree? It seems http://git.moblin.org/cgit.cgi/powertop/ is severely out of date?

Revision history for this message
Martin Pitt (pitti) wrote :

powertop (1.13-1ubuntu1) maverick; urgency=low

  * Cherrypick upstream patch 0a8620213f1841a to stop hardcoding the maximum
    number of C and P states. This makes powertop work on ARM processors as
    well, which have a lot of those states. Thanks to Amit Arora for the
    patch! (LP: #627975)

 -- Martin Pitt <email address hidden> Wed, 15 Sep 2010 13:43:46 +0200

Changed in powertop (Ubuntu Maverick):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.