make test fails on xfs filesystem
Bug #672643 reported by
Petr Lautrbach
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libnih |
Triaged
|
Low
|
Unassigned | ||
libnih (Debian) |
Fix Released
|
Unknown
|
|||
libnih (Ubuntu) |
Fix Released
|
Medium
|
Dimitri John Ledkov | ||
upstart (Fedora) |
Fix Released
|
Medium
|
Bug Description
If there is used xfs fs on /tmp, upstart make check fails on:
BAD: wrong value for block file, got unexpected NULL
at tests/test_
It's because in libnih library there is a test if an entity is a directory based on struct dirent returned by
readdir(3):
nih/file.c:644 if (filter && filter (data, subpath, ent->d_type ==
DT_DIR))
but used item d_type is not supported by all filesystem like xfs, reiserfs and so on.
Related branches
lp:~xnox/ubuntu/raring/libnih/fix-xfs
- Upstart Developers: Pending requested
- Upstart Developers: Pending requested
-
Diff: 122 lines (+80/-1)3 files modifieddebian/changelog (+8/-0)
nih/file.c (+11/-1)
nih/tests/test_file.c (+61/-0)
lp:~xnox/libnih/fix-672643
- Dimitri John Ledkov (community): Disapprove
- Scott James Remnant: Pending requested
-
Diff: 124 lines (+82/-1)3 files modifiedChangeLog (+10/-0)
nih/file.c (+11/-1)
nih/tests/test_file.c (+61/-0)
lp:~upstart-devel/libnih/nih
Ready for review
for merging
into
lp:libnih
- Scott James Remnant: Pending requested
-
Diff: 2208 lines (+661/-409)56 files modifiedChangeLog (+46/-0)
nih-dbus-tool/argument.h (+1/-1)
nih-dbus-tool/demarshal.c (+3/-3)
nih-dbus-tool/demarshal.h (+1/-1)
nih-dbus-tool/indent.h (+2/-2)
nih-dbus-tool/interface.h (+8/-8)
nih-dbus-tool/main.c (+2/-2)
nih-dbus-tool/marshal.c (+39/-7)
nih-dbus-tool/marshal.h (+1/-1)
nih-dbus-tool/method.h (+7/-7)
nih-dbus-tool/node.h (+4/-4)
nih-dbus-tool/output.h (+2/-2)
nih-dbus-tool/parse.h (+2/-2)
nih-dbus-tool/property.h (+9/-9)
nih-dbus-tool/signal.h (+4/-4)
nih-dbus-tool/symbol.c (+2/-2)
nih-dbus-tool/symbol.h (+4/-4)
nih-dbus-tool/tests/expected/test_method_object_function_no_input.c (+13/-11)
nih-dbus-tool/tests/expected/test_method_object_function_standard.c (+13/-11)
nih-dbus-tool/tests/expected/test_method_reply_function_deprecated.c (+12/-11)
nih-dbus-tool/tests/expected/test_method_reply_function_standard.c (+12/-11)
nih-dbus-tool/tests/test_main.c (+2/-2)
nih-dbus-tool/tests/test_marshal.c (+164/-150)
nih-dbus-tool/tests/test_property.c (+1/-1)
nih-dbus-tool/type.c (+1/-1)
nih-dbus-tool/type.h (+15/-15)
nih-dbus/dbus_object.h (+1/-2)
nih-dbus/dbus_pending_data.h (+1/-1)
nih-dbus/dbus_proxy.c (+2/-2)
nih-dbus/dbus_proxy.h (+2/-2)
nih-dbus/dbus_util.h (+1/-1)
nih/alloc.c (+1/-2)
nih/alloc.h (+2/-2)
nih/child.h (+1/-1)
nih/command.h (+1/-1)
nih/config.h (+5/-5)
nih/file.c (+12/-2)
nih/file.h (+1/-1)
nih/hash.h (+1/-1)
nih/io.h (+8/-8)
nih/list.h (+2/-2)
nih/logging.c (+8/-11)
nih/main.h (+1/-1)
nih/option.h (+2/-2)
nih/signal.h (+1/-1)
nih/string.h (+17/-17)
nih/tests/test_file.c (+61/-0)
nih/tests/test_hash.c (+2/-1)
nih/tests/test_logging.c (+55/-60)
nih/tests/test_main.c (+1/-1)
nih/tests/test_option.c (+2/-2)
nih/tests/test_watch.c (+60/-0)
nih/timer.h (+4/-4)
nih/tree.h (+2/-2)
nih/watch.c (+33/-1)
nih/watch.h (+1/-1)
Changed in libnih: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in libnih: | |
status: | Confirmed → Triaged |
Changed in libnih (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Dmitrijs Ledkovs (xnox) |
Changed in libnih (Debian): | |
status: | Unknown → New |
Changed in libnih (Debian): | |
status: | New → Fix Released |
Changed in upstart (Fedora): | |
importance: | Unknown → Medium |
status: | Unknown → Fix Released |
To post a comment you must log in.
Description of problem:
When I try to rebuild upstart with /tmp - XFS filesystem, reload( ) with new job directory (see log). If tmpfs of ext3 mounted on /tmp, build finishes ok,
build failed on test Testing conf_source_
but after install and reboot, boot process freezed on init start
(I have / XFS too).
Version-Release number of selected component (if applicable): 0.6.3-7. fc13.src. rpm 0.3.11- 3.1.bcx. src.rpm
upstart-
last working version: upstart-
How reproducible:
100%
Steps to Reproduce:
1. mount /tmp XFS
2. try to rebuild rpm
3. see failed test.
4. mount /tmp tmpfs
5. rebuild rpm - OK
-- only for mazo:
6. PREPARE for boot error (copy old init)
7. upgrage
8. reboot -- see boot hang.
9. restore old init
Actual results:
dont work on XFS.
Expected results:
work on ANY good filesystem
(may be clean request for FS abilities).
Additional info: