Bluebird uses removed controls for chrome; please use attached instead.

Bug #686239 reported by Elliot Glaysher
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Chromium Browser
Unknown
Unknown
NULL Project
Invalid
Undecided
Unassigned
shimmer-themes (Ubuntu)
Fix Released
Low
Simon Steinbeiß

Bug Description

(Note: I'm the author of Google Chrome's GTK+ integration code.)

The gtkrc file for Bluebird contains the following line:

    gtk_color_scheme = "frame_color:#CDCDCD\ninactive_frame_color:#CDCDCD" # Fix for Chrome

Specifying frame colors through the gtk color scheme has been deprecated since late 2009, and has been removed for Chrome 9. (The above line will also set both the normal and inactive frame to a gray, which I assume is unintentional.)

The new theming controls for Chrome 9 and forward are documented at: http://code.google.com/p/chromium/wiki/LinuxGtkThemeIntegration

Here is an example for Bluebird based on me naively picking colors from screenshots taken with the gimp. Your art team will probably be displeased with it and want to fine tune it. These individual style properties are documented in the link above. It is only meant as an example of what can be done. To try this out, please install either Google Chrome/Chromium 9.0.597 or newer:

style "chrome-gtk-frame"
{
    ChromeGtkFrame::frame-color = "#4e79a7"
    ChromeGtkFrame::inactive-frame-color = "#4e79a7"

    ChromeGtkFrame::frame-gradient-size = 24
    ChromeGtkFrame::frame-gradient-color = "#5c89b7"
    ChromeGtkFrame::inactive-frame-gradient-color = "#7193b7"

    ChromeGtkFrame::scrollbar-trough-color = @bg_color
    ChromeGtkFrame::scrollbar-slider-prelight-color = "#686868"
    ChromeGtkFrame::scrollbar-slider-normal-color = "#a1a1a1"
}

class "ChromeGtkFrame" style "chrome-gtk-frame"

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

thanks a lot for pointing this out!
i'm currently reworking parts of the theme for natty (which you can check out here: http://shimmerproject.org/hg/bluebird-colors), i'll test/apply your theming suggestions for both bluebird and greybird (and maybe even albatross) and will report again here.

Revision history for this message
Charlie Kravetz (cjkgeek) wrote :

Thanks for reporting this bug and any supporting documentation. Since this bug has enough information provided for a developer to begin work, I'm going to mark it as confirmed and let them handle it from here. Thanks for taking the time to make Ubuntu better!

Changed in xubuntu-artwork:
importance: Undecided → Low
status: New → Confirmed
Changed in xubuntu-artwork:
assignee: nobody → Simon Steinbeiß (simon-steinbeiss)
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

thanks again, this has been taken care of in greybird (successor-theme of bluebird) and will soon also be fixed in bluebird!

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

It's not fixed in Greybird in Xubuntu 11.04-beta1

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

Can you please specify how it is not fixed?
using chrome/ium >= v.9.0.5* (which is the case in 11.04beta1) it works perfectly.

Keep in mind that you have to change chromium's settings to use the gtk-theme and system borders by hand in the "Under the hood" tab (if I remember the name of the tab correctly).

If this still doesn't work for you please give me more information, e.g. what version of chromium you're using and how it doesn't work. Thanks.

Revision history for this message
Dmitry Shachnev (mitya57) wrote : Re: [Bug 686239] Re: Bluebird uses removed controls for chrome; please use attached instead.

Maybe it's my mistake, I'll test it later this week.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Here is what I get: Title color is different from tabs-area color, with "Use Gtk+ theme" enabled.
Additionally, "Zoom" option in the menu looks ugly.

Also, Chromium uses Gtk+ theme by default on regular Ubuntu, why don't you do the same?

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

hey again,
sorry, i really cannot reproduce this. i made a screenshot for you and attached it, it should show all the relevant info.
please let me know about the difference between your version and mine.
thanks in advance.

Revision history for this message
Elliot Glaysher (glaysher) wrote :

@Dmitry

> Also, Chromium uses Gtk+ theme by default on regular Ubuntu, why don't you do the same?

Chromium checks the DESKTOP_SESSION environment variable to see whether it's on a GTK+ based desktop and to enable gtk+ rendering if it is. While I haven't installed any of the Natty betas yet, previously that's been set to either /xfce\d?/ or "xubuntu".

The actual xdg shell scripts check for a string on xprop, which we'd prefer to not do. If there's another xfce specific environment variable that we should be checking, please file a bug at new.crbug.com.

@Simon

That looks great with the system title bars, but does it still look OK if you use compact borders (Preferences > Personal Stuff > Hide system title bar and use compact borders)? Compact borders are the default on whitelisted window managers and "Xfwm4" is a whitelisted WM.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

hey elliot,
thanks for the heads-up. here goes a screenshot of chromium with compact borders. looks pretty decent imo.

Revision history for this message
Elliot Glaysher (glaysher) wrote :

Agreed. Just wanted to make sure the case was covered.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

The output:
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `ChromeGtkFrame::frame-color' of type `GdkColor' from rc file value "((GString*) 0xb8c517c0)" of type `GString'
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `ChromeGtkFrame::inactive-frame-color' of type `GdkColor' from rc file value "((GString*) 0xb8c517d0)" of type `GString'
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `ChromeGtkFrame::scrollbar-slider-normal-color' of type `GdkColor' from rc file value "((GString*) 0xb8c51930)" of type `GString'
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `ChromeGtkFrame::frame-gradient-color' of type `GdkColor' from rc file value "((GString*) 0xb8cae900)" of type `GString'
Gtk-Message: (for origin information, set GTK_DEBUG): failed to retrieve property `ChromeGtkFrame::inactive-frame-gradient-color' of type `GdkColor' from rc file value "((GString*) 0xb8cae920)" of type `GString'

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

All is OK when I start Chromium with LC_ALL=C (my current locale is ru_RU.utf8). Also, here is output with GTK_DEBUG set:

Gtk-Message: /usr/share/themes/greybird/gtk-2.0/gtkrc:662: failed to retrieve property `ChromeGtkFrame::frame-color' of type `GdkColor' from rc file value "((GString*) 0xb7cc07c0)" of type `GString'
Gtk-Message: /usr/share/themes/greybird/gtk-2.0/gtkrc:663: failed to retrieve property `ChromeGtkFrame::inactive-frame-color' of type `GdkColor' from rc file value "((GString*) 0xb7cc07d0)" of type `GString'
<...>

Sorry for the spam :)

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

@Elliot: is this an issue in Chromium?

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

thanks for reporting/linking this upstream, don't think i can do anything about that in the theme.

Revision history for this message
Elliot Glaysher (glaysher) wrote :

This is a bug in GTK+; not in chromium: https://bugzilla.gnome.org/show_bug.cgi?id=647908

(I have a minimal test case showing off the bug on the gtk+ tracker)

Also: :-(

Changed in gtk:
importance: Unknown → Medium
status: Unknown → New
Revision history for this message
Elliot Glaysher (glaysher) wrote :

A fix has been committed upstream for the locale issue.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

thanks elliot!

@dmitry: would be nice if you could test the fix later or check when it lands in natty.

Changed in gtk:
status: New → Fix Released
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I have filed a new report for this: bug 772492.

affects: gtk → null
Changed in null:
importance: Medium → Undecided
status: Fix Released → New
status: New → Invalid
Changed in xubuntu-artwork (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Simon Steinbeiß (simon-steinbeiss)
no longer affects: xubuntu-artwork
affects: xubuntu-artwork (Ubuntu) → shimmer-themes (Ubuntu)
Revision history for this message
Simon Steinbeiß (ochosi) wrote :
Changed in shimmer-themes (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shimmer-themes - 1.5.0-0ubuntu1

---------------
shimmer-themes (1.5.0-0ubuntu1) quantal; urgency=low

  * Update Greybird to latest tag (v0.9). lp: #924853,#947436,#982820,#1016713
  * Update Bluebird to latest tag (v0.6). lp: #686239,#977431
  * Update Albatross to latest tag (v1.2). lp: #989814,#1023056
  * debian/control: demote gtk3-engines-unico to recommends as most themes
    are now engine-free.
  * debian/shimmer-wallpapers.install: update paths, wallpapers are in their
    own branch/subtarball now.
  * debian/shimmer-themes.install: ship Albatross' metacity theme.
  * debian/shimmer-themes.links: drop greybird -> Greybird compatibility
    symlinks. lp: #985320
 -- Lionel Le Folgoc <email address hidden> Sat, 28 Jul 2012 22:28:31 +0200

Changed in shimmer-themes (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.