Amarok

Amarok does not register with the menu

Bug #693316 reported by Conor Curran on 2010-12-22

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Amarok	Fix Released	Medium	Aurélien Gâteau
	amarok (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Due to the different location of the Desktop file for Amarok on Ubuntu systems the application now cannot currently register and therefore be controlled by the applicaton.

Tags:

Related branches

lp:ubuntu/natty/amarok

Conor Curran (cjcurran) on 2010-12-22

Changed in indicator-sound:
milestone:	none → 0.5.4
assignee:	nobody → Conor Curran (cjcurran)
status:	New → Confirmed
importance:	Undecided → Medium

Conor Curran (cjcurran) on 2011-01-04

Changed in indicator-sound:
status:	Confirmed → Fix Committed

Conor Curran (cjcurran) on 2011-01-05

Changed in indicator-sound:
status:	Fix Committed → Confirmed
assignee:	Conor Curran (cjcurran) → Aurélien Gâteau (agateau)

Revision history for this message

Conor Curran (cjcurran) wrote on 2011-01-05:

I thought the automatic lookup would solve this but alas no, the problem lies with the desktop file name being returned by the MPRIS root interface. Inorder for the new DesktopAppInfo(string desktop-file-d) to work the amarok desktop file id needs to actually be 'kde4-amarok,desktop' and not 'amarok.desktop'. The MPRIS spec is misleading here. To put simply the desktopentry on the root MPRIS interface for Amarok needs to return 'kde4-amarok'

affects:	indicator-sound → amarok
Changed in amarok:
milestone:	0.5.4 → none

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2011-01-11:

14_soundmenu_fix_desktop_file_path.diff Edit (528 bytes, text/plain)

Attached one-liner fix the problem.

Changed in amarok:
status:	Confirmed → In Progress

Felix Geyer (debfx) on 2011-01-12

Changed in amarok (Ubuntu):
status:	New → Fix Committed

Brian Murray (brian-murray) on 2011-01-12

tags:

added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-01-15:

This bug was fixed in the package amarok - 2:2.4.0-0ubuntu1

---------------
amarok (2:2.4.0-0ubuntu1) natty; urgency=low

  * New upstream release.
  * Adapt patches to new upstream version.
  * Reactivate mysqle_amarok_local_errmsg_feature.diff.
  * Drop kubuntu/11_soundmenu_mpris2.0.diff, merged upstream.
  * Drop kubuntu/13_arm_compile.diff, merged upstream.
  * Add kubuntu/14_soundmenu_fix_desktop_file_path.diff to fix Amarok not
    registering with the sound indicator menu. (LP: #693316)
-- Felix Geyer <email address hidden> Wed, 12 Jan 2011 01:10:22 +0100

Changed in amarok (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Conor Curran (cjcurran) wrote on 2011-01-15:

I'm afraid this isn't fixed. The Desktop path exposed on Desktopentry property on the mpris root interface needs to be kde4-amarok and not just amarok. This will hint the lookup mechanism to search through the kde4 subdirectory within system XDG data dir. reopening ...

Changed in amarok (Ubuntu):
status:	Fix Released → In Progress
Changed in amarok:
status:	In Progress → Confirmed
Changed in amarok (Ubuntu):
status:	In Progress → Confirmed

Revision history for this message

Felix Geyer (debfx) wrote on 2011-01-15:

I've applied the patch from Aurélien to the amarok package.
Doesn't the patch fix the problem?

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2011-01-20:

Mmm...

"""
[aurelien@natty - ~]
`-> dpkg -l amarok
ii amarok 2:2.4.0-0ubuntu1 easy to use media player based on the KDE Platform

[aurelien@natty - ~]
`-> qdbus org.mpris.MediaPlayer2.amarok /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.DesktopEntry
kde4-amarok
"""

Looks fixed to me.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-03-10:

should that bug be closed?

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2011-03-10:

Yes, closing it now.

Changed in amarok:
status:	Confirmed → Fix Committed
Changed in amarok (Ubuntu):
status:	Confirmed → Fix Released
Changed in amarok:
status:	Fix Committed → Invalid

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2011-03-10:

(marking as invalid for upstream project since the problem only appears because we install .desktop files in a kde4/ dir)

Revision history for this message

Aurélien Gâteau (agateau) wrote on 2011-03-10:

#10

Actually the bug is valid for the upstream project since share/applications/kde4/ is the default kde installation dir for desktop files, thanks to debfx for pointing this out to me.