Remove scour dependancy while building Humanity
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| humanity-icon-theme (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Binary package hint: humanity-icon-theme
Scour is not production ready, and the authors themselves acknowledge that it does not always preserve the original image : <http://
Louis Simard mentions : "Scour is not reliable enough to use on input files to replace them" This is why they dont allow input and output names to be the same.
However, we have this brand new unreliable package in natty building packages since it saves space.
While it maybe be acceptable for other programs to use scour, (icons are not part of their main purpose), it is not reasonable to use it for building icon themes whose main and **only** purpose is to have properly colored/designed icons.
Build 0.5.3.5 of Humanity was completely changed and several of the icons were not even close to what we had designed.
For Build 0.5.3.6 we added a fuzzy SVG comparison script ,cmpsvg, to check the difference and only accept of difference is less than 0.5% !!!
As i'v mentioned on bug 702423 0.5% is way too high, several icons escape this check and look completely different to what it was designed. I'v already found atleast 15 icons which have been modified.
http://
Saying the 0.5% is an acceptable ratio for removal is like telling a developer that it is OK if 0.5% of their code at random will be removed during packaging.
We dont even know what 0.5% will be changed , so we cant even make icons and be assured that it will be distributed right.
However, space used *is* important, and even we, at the elementary team, are pedantic about this.
We have always saved the files as plain svg, because it was the only option we had until now.
So, what I have done is I have manually scoured ,using rev 207 from lp:scour, and checked *all* the svg and
* reduced the size from 21.8MB to 12.3MB *, the optimized branch is at lp:~ubuntu-art-pkg/humanity/release
Only 18 icons have not been scoured since they have bugs: Bug #734885 , Bug #734933 , Bug #734019
This reduced size is 3.5MB lesser than the size in package 0.5.3.6, which is 15.8 MB
Since space is the main reason this was done, I would suggest that we drop the scour dependency until scour is production ready.
| Changed in humanity-icon-theme (Ubuntu): | |
| importance: | Undecided → High |
| description: | updated |
| Martin Pitt (pitti) wrote | #1 |
| Vish (vish) wrote | #2 |
| Martin Pitt (pitti) wrote | #3 |
| Martin Pitt (pitti) wrote | #4 |
| Vish (vish) wrote Re: [Bug 734955] Re: Remove scour dependancy while building Humanity | #5 |
| Vish (vish) wrote | #6 |
| Vish (vish) wrote | #7 |
| Martin Pitt (pitti) wrote | #8 |
| Launchpad Janitor (janitor) wrote | #9 |
| Changed in humanity-icon-theme (Ubuntu): | |
| status: | New → Fix Released |
> Scour is not reliable enough to use on input files to replace them
That's correct. However, that means "you should keep your original file around instead of assuming that you can continue to edit the scour'ed result in Inkscape". It isn't supposed to mean "the icons are meant to look different".
If it's merely the error treshold which is a concern here: How about just lowering that to 0.0%?
> So, what I have done is I have manually scoured ,using rev 207 from lp:scour, and checked *all* the svg and
> * reduced the size from 21.8MB to 12.3MB *, the optimized branch is at lp:~ubuntu-art-pkg/humanity/release
You mean you actually committed the scour'red results? Don't! That's precisely the big fat warning that scour has stamped on which you pointed out above. That will actually change the original files and make them uneditable in Inkscape.