Ubuntu
qemu-kvm package

need a versioned depend on vgabios

Bug #783864 reported by dann frazier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qemu-kvm (Ubuntu)
Fix Released
High
Serge Hallyn
Natty
Invalid
Undecided
Unassigned

Bug Description

Binary package hint: qemu-kvm

qemu-kvm includes symlinks to files in the vgabios package, but only newer vgabios packages provide those files. The dependency that natty & oneiric's qemu-kvm has on vgabios probably needs to be versioned to >= 0.6c-2ubuntu2 to work well w/ partial upgrades and backports.

SRU Justifications:
1. Impact: users backporting qemu-kvm need to know to manually upgrade vgabios first. A versioned depend should be warning them and doing it for them.

2. How bug was addressed: the vgabios depends is versioned to ensure that the version provides needed symlink targets.

3. Patch:
diff -u qemu-kvm-0.14.0+noroms/debian/control qemu-kvm-0.14.0+noroms/debian/control
--- qemu-kvm-0.14.0+noroms/debian/control
+++ qemu-kvm-0.14.0+noroms/debian/control
@@ -75,7 +75,7 @@

 Package: qemu-common
 Architecture: all
-Depends: seabios, vgabios, ${misc:Depends}, ${shlibs:Depends}
+Depends: seabios, vgabios (>= 0.6c-2ubuntu2), ${misc:Depends}, ${shlibs:Depends}
 Recommends: cpu-checker
 Suggests: kvm-pxe,
           mol-drivers-macosx,

4. TEST CASE: dpkg -i qemu-common_0.14.0+noroms-0ubuntu5_all.deb on a lucid machine.

5. regression potential: none.

See original description
Tags: testcase
Dustin Kirkland  (kirkland)
Changed in qemu-kvm (Ubuntu):
assignee: nobody → Serge Hallyn (serge-hallyn)
importance: Undecided → High
status: New → Triaged
Serge Hallyn (serge-hallyn)
Changed in qemu-kvm (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qemu-kvm - 0.14.0+noroms-0ubuntu6

---------------
qemu-kvm (0.14.0+noroms-0ubuntu6) oneiric; urgency=low

  * We need a versioned depend on vgabios to ensure the files we link to
    exist. (LP: #783864)
 -- Serge Hallyn <email address hidden> Tue, 24 May 2011 10:09:01 -0500

Changed in qemu-kvm (Ubuntu):
status: In Progress → Fix Released
Serge Hallyn (serge-hallyn)
description: updated
Changed in qemu-kvm (Ubuntu Natty):
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

This SRU seems quite pointless to me: it does not fix anything for natty users, as the vgabios version is recent enoug there. Why is it worth spending the effort of preparing, building, and QAing this, and having a nonzero regression risk? Oneiric has the versioned dependency, so backports will have it, too. For the theoretical case of a natty->lucid backport, the dependency can be added for the backport upload.

Revision history for this message
dann frazier (dannf) wrote :

I don't have a strong opinion either way (I've got it resolved where I needed it to be), but the only justification that comes to mind for me is a partial upgrade scenario. Whether or not that's an SRU qualifier, I've no idea.

Revision history for this message
Soren Hansen (soren) wrote : Re: [Bug 783864] Re: need a versioned depend on vgabios

2011/6/6 Martin Pitt <email address hidden>:
> This SRU seems quite pointless to me: it does not fix anything for natty
> users, as the vgabios version is recent enoug there. Why is it worth
> spending the effort of preparing, building, and QAing this, and having a
> nonzero regression risk? Oneiric has the versioned dependency, so
> backports will have it, too. For the theoretical case of a natty->lucid
> backport, the dependency can be added for the backport upload.

Just as a reminder: If this ever does get backported to Lucid, I'd
recommend that the versioned dependency should be "vgabios (>=
0.6c-2ubuntu2~)" (notice the tilde at the end). This is because
vgabios will have to be backported as well and the backport will be
versioned as e.g. 0.6c-2ubuntu2~lucid1, so it would not satisfy the
tildeless versioned dependency.

Revision history for this message
Martin Pitt (pitti) wrote :

Rejected as the current upload won't be sufficient for backports (see previous comment), and isn't necessary for natty users.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

(marked invalid for natty as per comment #5)

Changed in qemu-kvm (Ubuntu Natty):
status: Confirmed → Invalid
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: testcase
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.