Editing a review isn't instantly update in the users view
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| software-center (Ubuntu) |
Fix Released
|
Medium
|
Aaron Peachey | ||
Bug Description
Steps to reproduce:
From trunk
1. run the testing script
2. select a package
3. click on leave a review
4. login
5. make the review and submit it
6. click on edit
7. make an edit and submit it
Note that the edit is not instantly updated as you would expect clicking on edit again shows the new version.
8. restart USC now the new edit is visible
ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: software-center 4.0.3
ProcVersionSign
Uname: Linux 2.6.38-8-generic x86_64
NonfreeKernelMo
Architecture: amd64
Date: Thu Jul 7 15:28:14 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110423)
PackageArchitec
ProcEnviron:
LANGUAGE=en_GB:en
LANG=en_GB.UTF-8
SHELL=/bin/bash
SourcePackage: software-center
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Gary Lasker (community): Approve
- Michael Vogt: Pending requested
-
Diff: 167 lines (+66/-51)3 files modifieddebian/changelog (+7/-1)
softwarecenter/backend/reviews.py (+50/-42)
softwarecenter/backend/spawn_helper.py (+9/-8)
| Dave Morley (davmor2) wrote | #1 |
| Gary Lasker (gary-lasker) wrote | #2 |
| Changed in software-center (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Aaron Peachey (aaronp) |
| Aaron Peachey (aaronp) wrote | #3 |
| Gary Lasker (gary-lasker) wrote | #4 |
| Changed in software-center (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in software-center (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Dave Morley (davmor2) wrote | #6 |
| Aaron Peachey (aaronp) wrote | #7 |
Some relevant information from Aaron Peachey on this issue from bug 719843:
---
I think I know what this issue is, not that the update doesn't occur, but moreso that the old copy stays in the screen even though the new one is added.
I wrote the modify and delete code a long time ago and since then we received pagination support in USC which meant we needed to tweak the existing submit/flag/vote code to prevent duplication after a successful submit (see bug LP: #794060) with the new way the callback works after pagination was added.
I don't think we have made the same tweak on the modify/delete code since then so it's probably using the old callback method and 'duplicating' the reviews by not removing the original before inserting the updated version.
There are some helper functions in the UIReview class that should make this very simple to fix.