Git over https does not work (hangs) (fixed upstream)

Sorry, I saw this bug, but didn't jump on it fast enough, I've been busy.

Can you find the patch to fix this bug? and we can do an SRU
https://wiki.ubuntu.com/StableReleaseUpdates

[I don't need cntlm day-to-day any more, so I'm not keeping as much of an eye on it as I was before. I'd love someone else to start doing that.]

Here is the patch I found : it corresponds to revision 273 at http://svn.awk.cz/cntlm/tags/release-0.92/.

Commit log says :

------------------------------------------------------------------------
r273 | dave | 2011-11-28 14:55:15 +0100 (Mon, 28 Nov 2011) | 3 lines

* Fix latest GCC warnings
* Fix GIT HTTPS issue (invalid body length detection in request)

I'm not familiar at all with the cntlm code base, so I may be mistaken...

The attachment "Upstream fix for git/https bug" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Neither am I, but that sounds reasonable, let's see what we can do about it.

I'm very glad to see the upstream changelog say "proxy hostname is resolved at run-time not during startup (as requested)" which means that we can sync 0.92 from Debian, overriding my Ubuntu-specific changes.
That'll solve the problem for quantal.

For precise, your patch applies, and I've prepared an upload including it in
https://launchpad.net/~stefanor/+archive/sru

Please see if this resolves the issue for you, if it does, we can go ahead with the SRU.

Hi Stephano,

Thanks for the PPA. I'm still with oneiric at work however, and I cannot install the cntlm_0.91~rc6-0ubuntu2.1_i386.deb version due to the following dependency not being met :

dpkg: dependency problems prevent configuration of cntlm:
 cntlm depends on libc6 (>= 2.15); however:
  Version of libc6 on system is 2.13-20ubuntu5.1.

I'll switch to precise in a couple of days (I'm a bit busy at work right now). Is that ok to wait a little while ?

Uploading a build for oneiric...

The oneirec version seems to work nicely. Thanks !

OK, uploaded it to precise-proposed, pending SRU team review.

Thanks !

This bug was fixed in the package cntlm - 0.92.3-1

---------------
cntlm (0.92.3-1) unstable; urgency=low

  * New upstream release. Closes: #652725, #588920.
  * Fix Init script error, thanks Martijn. Closes: #588683.
  * Correct spellings in man page.
  * Update Standards Version, no changes needed.

 -- David Watson <email address hidden> Fri, 27 Apr 2012 15:08:17 +0100

Hello Manuel, or anyone else affected,

Accepted cntlm into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Hi Martin, hi all,

Thanks ! Here is the test I did : I reverted cntlm to the default precise version (apt-get remove cntlm && apt-get install cntlm), and then I tried to clone a git repo over https.

With cntlm version 0.91~rc6-0ubuntu2, the following command hangs forever :

    $ git clone https://github.com/hibernate/hibernate-orm.git
    Cloning into 'hibernate-orm'...

With cntlm version 0.91~rc6-0ubuntu2.12.04.1, it works fine :

    $ git clone https://github.com/hibernate/hibernate-orm.git
    Cloning into 'hibernate-orm'...
    remote: Counting objects: 125045, done.
    remote: Compressing objects: 100% (33302/33302), done.
    remote: Total 125045 (delta 76281), reused 123526 (delta 75008)
    Receiving objects: 100% (125045/125045), 89.87 MiB | 499 KiB/s, done.
    Resolving deltas: 100% (76281/76281), done.

So, from my point of view, the bug is fixed. Thanks again for your support !

This bug was fixed in the package cntlm - 0.91~rc6-0ubuntu2.12.04.1

---------------
cntlm (0.91~rc6-0ubuntu2.12.04.1) precise-proposed; urgency=low

  * Cherry-pick r273 from 0.92 to fix a lockup with git clones over HTTPS.
    (LP: #973288). Thanks Manuel Siggen.
 -- Stefano Rivera <email address hidden> Wed, 02 May 2012 13:01:23 +0200