Juju Charms Collection

charm needed: newrelic sysmond

Bug #1000088 reported by Brandon Holtsclaw
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Fix Released
Medium
Brandon Holtsclaw

Bug Description

Simple Newrelic sysmon charm

Brandon Holtsclaw (imbrandon)
tags: added: new-charm
Changed in charms:
importance: Undecided → Medium
status: New → Confirmed
Jorge Castro (jorge)
tags: removed: new-charm
Brandon Holtsclaw (imbrandon)
Changed in charms:
status: Confirmed → New
tags: added: new-charm
Jorge Castro (jorge)
tags: removed: new-charm
Brandon Holtsclaw (imbrandon)
Changed in charms:
assignee: Brandon Holtsclaw (imbrandon) → nobody
status: New → Confirmed
Revision history for this message
Marc Cluet (lynxman) wrote :

Looks good Brandon, thank you for your contribution!

Marc Cluet (lynxman)
Changed in charms:
status: Confirmed → In Progress
assignee: nobody → Brandon Holtsclaw (imbrandon)
Revision history for this message
Marc Cluet (lynxman) wrote :

Hi Brandon,

It looks quite good to me, just a couple things:

1- Make sure to put your name as maintainer in the metadata.yaml file, if you don't want to be the maintainer for any reason please let us know and we'll find a way :)

2- The key file implementation could benefit from a more verbose approach catching the error and showing an error message if the user forgets or doesn't have a valid key for the product.

Please change the state back to New as soon as that's fixed in the branch.

Thanks!

Changed in charms:
status: In Progress → Incomplete
Revision history for this message
Brandon Holtsclaw (imbrandon) wrote :

1. adding the maintainer now, this was in the queue prior to needing a maintainer so it hadent been added yet :)

As for #2 i'm putting as "wont fix"
As the daemon its self handles if there is no key ( it adds a default trial key ) and the if/else covers if they forgot to provide one, in other words its like that by design.

Brandon Holtsclaw (imbrandon)
Changed in charms:
status: Incomplete → Fix Committed
Brandon Holtsclaw (imbrandon)
tags: added: new-charm
Jorge Castro (jorge)
tags: removed: new-charm
Revision history for this message
Mark Mims (mark-mims) wrote :

testing

Revision history for this message
Mark Mims (mark-mims) wrote :

testing again

Revision history for this message
Mark Mims (mark-mims) wrote :

testing yet again

Revision history for this message
Mark Mims (mark-mims) wrote :

and another time

Revision history for this message
Mark Mims (mark-mims) wrote :

ugh

Revision history for this message
Mark Mims (mark-mims) wrote :

hahaha

Revision history for this message
Mark Mims (mark-mims) wrote :

whadup

with

some spaces

just to see what the formatting

looks *bold* like.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Brandon,

maintainer cannot be a list. It is a single field only. If you do not want to have sole responsibility for the charm, then just assign it to Juju Charmers.

Also the indentation is a bit sloppy:

requires:
  juju-info:
    interface: juju-info
    scope: container
provides:
  logging:
   interface: newrelic
   scope: container

Please stay consistent, 1 space or two.

Changed in charms:
status: Fix Committed → Incomplete
Revision history for this message
Brandon Holtsclaw (imbrandon) wrote :

spacing fixed

maintainer reduced to just me to avert the bug you mentioned

filing a sperate issue against juju as I did not realize that the metadata.yaml file was not parsed as yaml , thankfully http://jujucharms.com/~imbrandon/precise/newrelic seemed to properly parse the file

Fixes committed.

Changed in charms:
status: Incomplete → Fix Committed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Thanks Brandon, Promulgated!

Changed in charms:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.