Queue tool requires direct DB access
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
scripts/
Some of queue's capabilities are not currently exposed in the web UI, in particular overriding individual binaries in an upload. Julian has said that he considers this a bug in its own right (bug 828649), but that's a case where it would probably be easier to expose an API in the short term than to do yet another UI redesign; and, again, that's something I can imagine automated use cases for (e.g. syncing over the overrides for all of linux's zillion binary packages each time there's a new kernel API in the development release).
In general, I believe we make use of just about all the facilities provided by the queue tool in one way or another. I think the most straightforward approach here is just to provide a like-for-like replacement. We don't need the new API to have any particular stability guarantees, since the main consumers of it will be in ubuntu-
Related branches
- Steve Kowalik (community): Approve (code)
-
Diff: 232 lines (+120/-7)4 files modifiedlib/lp/soyuz/interfaces/queue.py (+14/-3)
lib/lp/soyuz/stories/webservice/xx-packageupload.txt (+1/-0)
lib/lp/soyuz/tests/test_packageupload.py (+103/-2)
lib/lp/testing/factory.py (+2/-2)
- Launchpad code reviewers: Pending requested
-
Diff: 1647 lines (+802/-187)16 files modifiedlib/lp/archiveuploader/tests/nascentupload-ddebs.txt (+2/-1)
lib/lp/registry/interfaces/distroseries.py (+7/-0)
lib/lp/soyuz/browser/queue.py (+7/-3)
lib/lp/soyuz/configure.zcml (+6/-0)
lib/lp/soyuz/doc/distroseriesqueue.txt (+22/-26)
lib/lp/soyuz/interfaces/archive.py (+13/-1)
lib/lp/soyuz/interfaces/binarypackagerelease.py (+8/-1)
lib/lp/soyuz/interfaces/queue.py (+133/-31)
lib/lp/soyuz/model/binarypackagerelease.py (+13/-2)
lib/lp/soyuz/model/queue.py (+241/-36)
lib/lp/soyuz/scripts/queue.py (+3/-3)
lib/lp/soyuz/stories/webservice/xx-packageupload.txt (+13/-0)
lib/lp/soyuz/tests/test_distroseriesqueue_ddtp_tarball.py (+0/-28)
lib/lp/soyuz/tests/test_distroseriesqueue_dist_upgrader.py (+4/-27)
lib/lp/soyuz/tests/test_packageupload.py (+327/-26)
lib/lp/testing/factory.py (+3/-2)
- Benji York (community): Approve (code)
-
Diff: 41 lines (+20/-0)2 files modifiedlib/lp/registry/interfaces/distroseries.py (+7/-0)
lib/lp/soyuz/stories/webservice/xx-packageupload.txt (+13/-0)
- Benji York (community): Approve (code)
-
Diff: 330 lines (+135/-48)6 files modifiedlib/lp/archiveuploader/tests/nascentupload-ddebs.txt (+2/-1)
lib/lp/soyuz/browser/queue.py (+7/-3)
lib/lp/soyuz/doc/distroseriesqueue.txt (+8/-12)
lib/lp/soyuz/interfaces/archive.py (+13/-1)
lib/lp/soyuz/interfaces/queue.py (+10/-13)
lib/lp/soyuz/model/queue.py (+95/-18)
- Richard Harding (community): Approve
-
Diff: 926 lines (+411/-66)13 files modifiedlib/lp/archiveuploader/tests/nascentupload.txt (+2/-2)
lib/lp/archiveuploader/tests/test_buildduploads.py (+2/-2)
lib/lp/soyuz/configure.zcml (+6/-0)
lib/lp/soyuz/interfaces/binarypackagerelease.py (+5/-1)
lib/lp/soyuz/interfaces/queue.py (+86/-16)
lib/lp/soyuz/model/binarypackagerelease.py (+14/-2)
lib/lp/soyuz/model/queue.py (+105/-12)
lib/lp/soyuz/scripts/queue.py (+4/-4)
lib/lp/soyuz/tests/test_distroseriesqueue_debian_installer.py (+1/-1)
lib/lp/soyuz/tests/test_distroseriesqueue_dist_upgrader.py (+1/-1)
lib/lp/soyuz/tests/test_packageupload.py (+176/-22)
lib/lp/testing/factory.py (+3/-2)
lib/lp/testing/tests/test_factory.py (+6/-1)
- j.c.sackett (community): Approve
-
Diff: 111 lines (+57/-14)2 files modifiedlib/lp/soyuz/model/queue.py (+7/-1)
lib/lp/soyuz/tests/test_packageupload.py (+50/-13)
- j.c.sackett (community): Approve
-
Diff: 102 lines (+4/-55)2 files modifiedlib/lp/soyuz/tests/test_distroseriesqueue_ddtp_tarball.py (+0/-28)
lib/lp/soyuz/tests/test_distroseriesqueue_dist_upgrader.py (+4/-27)
- j.c.sackett (community): Approve
-
Diff: 518 lines (+241/-20)5 files modifiedlib/lp/soyuz/browser/queue.py (+5/-2)
lib/lp/soyuz/doc/distroseriesqueue.txt (+5/-5)
lib/lp/soyuz/interfaces/queue.py (+37/-2)
lib/lp/soyuz/model/queue.py (+43/-7)
lib/lp/soyuz/tests/test_packageupload.py (+151/-4)
- Steve Kowalik (community): Approve (code)
-
Diff: 356 lines (+141/-17)8 files modifiedlib/lp/soyuz/browser/configure.zcml (+4/-0)
lib/lp/soyuz/browser/queue.py (+10/-1)
lib/lp/soyuz/configure.zcml (+1/-0)
lib/lp/soyuz/interfaces/queue.py (+17/-0)
lib/lp/soyuz/interfaces/sourcepackagerelease.py (+15/-0)
lib/lp/soyuz/model/queue.py (+29/-9)
lib/lp/soyuz/model/sourcepackagerelease.py (+13/-0)
lib/lp/soyuz/tests/test_packageupload.py (+52/-7)
- Steve Kowalik (community): Approve (code)
-
Diff: 38 lines (+15/-2)2 files modifiedlib/lp/soyuz/model/queue.py (+4/-2)
lib/lp/soyuz/tests/test_packageupload.py (+11/-0)
- William Grant: Approve (code)
- j.c.sackett (community): Approve
-
Diff: 2562 lines (+253/-2208)7 files modifiedlib/lp/soyuz/doc/ftpmaster-tools.txt (+0/-71)
lib/lp/soyuz/model/sourcepackagerelease.py (+2/-2)
lib/lp/soyuz/scripts/queue.py (+0/-737)
lib/lp/soyuz/scripts/tests/test_processaccepted.py (+52/-3)
lib/lp/soyuz/scripts/tests/test_queue.py (+0/-1270)
lib/lp/soyuz/tests/test_packageupload.py (+199/-0)
scripts/ftpmaster-tools/queue (+0/-125)
Changed in launchpad: | |
assignee: | nobody → Colin Watson (cjwatson) |
status: | New → In Progress |
summary: |
- Replace queue tool with API + Queue tool requires direct DB access |
Changed in launchpad: | |
importance: | Undecided → High |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
r15331 in stable (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 15331) is part of this bug's fix.