remove "runthis" and other unused fns from utils.py

Does all unused methods need to be removed or only some specific? Like currently i couldnt find any usage of generate_uid and generate_mac functions in utils.py. Are such methods to be removed too?

I would remove anything that is not used.

dan

On Thu, Jun 14, 2012 at 11:10 PM, Harsh Prasad <email address hidden>wrote:

> Does all unused methods need to be removed or only some specific? Like
> currently i couldnt find any usage of generate_uid and generate_mac
> functions in utils.py. Are such methods to be removed too?
>
> --
> You received this bug notification because you are a member of Netstack
> Core Developers, which is subscribed to quantum.
> https://bugs.launchpad.net/bugs/1012234
>
> Title:
> remove "runthis" and other unused fns from utils.py
>
> Status in OpenStack Quantum (virtual network service):
> Confirmed
>
> Bug description:
> Several methods in utils.py seem to be unused, for example, "runthis"
> (this method even seems to duplicate the "execute" method also in the
> same file).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1012234/+subscriptions
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix proposed to branch: master
Review: https://review.openstack.org/8653

Reviewed: https://review.openstack.org/8653
Committed: http://github.com/openstack/quantum/commit/dd0fe18690dfadec6dcc1c9161498db60b053083
Submitter: Jenkins
Branch: master

commit dd0fe18690dfadec6dcc1c9161498db60b053083
Author: Harsh Prasad <email address hidden>
Date: Mon Jun 18 14:18:24 2012 +0530

    removed "runthis" and other unused functions from utils.py

    Fixes Bug #1012234

    Removed all unused functions and imports from common/utils.py.

    Patch set 2: Submitted same code by mistake
    Patch set 3: removed commented code but inappropriate commit msg.
    Patch set 4: removed commented code with appropriate commit msg. Removed pep8 changes for ucs plugin.

    Change-Id: I0ec33be127ef0389685a378c6f8d39ce5cbdb58c