gtimelog crashed with SIGSEGV in gtk_style_context_get_valist()

StacktraceTop:
 gtk_style_context_get_valist (context=context@entry=0x18654c0, state=state@entry=GTK_STATE_FLAG_NORMAL, args=args@entry=0x7fffb0c593e8) at /build/buildd/gtk+3.0-3.5.4/./gtk/gtkstylecontext.c:1395
 gtk_style_context_get (context=context@entry=0x18654c0, state=state@entry=GTK_STATE_FLAG_NORMAL) at /build/buildd/gtk+3.0-3.5.4/./gtk/gtkstylecontext.c:1430
 gtk_style_context_get_color (context=0x18654c0, state=GTK_STATE_FLAG_NORMAL, color=0x197a7d0) at /build/buildd/gtk+3.0-3.5.4/./gtk/gtkstylecontext.c:3256
 ffi_call_unix64 () at ../src/x86/unix64.S:75
 ffi_call (cif=cif@entry=0x7fffb0c596f0, fn=fn@entry=0x7f9f42d01600 <gtk_style_context_get_color>, rvalue=<optimized out>, rvalue@entry=0x7fffb0c596d0, avalue=<optimized out>, avalue@entry=0x7fffb0c595f0) at ../src/x86/ffi64.c:486

I can reproduce this in testdrive with today's quantal CD image:
- select Try Ubuntu
- open terminal with Ctrl+Alt+T (qemu tablet mouse doesn't work for me in quantal)
- sudo software-properties-gtk: enable universe
- sudo apt-get update
- sudo apt-get install gtimelog
- gtimelog

It crashes on startup after printing a couple of error messages:

    (gtimelog:9287): Gtk-CRITICAL **: gtk_style_context_get_property: assertion `priv->widget != NULL || priv->widget_path != NULL' failed
    /usr/lib/python2.7/dist-packages/gi/types.py:47: Warning: /build/buildd/glib2.0-2.33.2/./gobject/gtype.c:4206: type id `0' is invalid
      return info.invoke(*args, **kwargs)
    /usr/lib/python2.7/dist-packages/gi/types.py:47: Warning: can't peek value table for type `<invalid>' which is not currently referenced
      return info.invoke(*args, **kwargs)
    Segmentation fault (core dumped)

lp:gtimelog trunk crashes in the same way

Running gtimelog with python -m trace --trace ./gtimelog tells me that the last line of code executed inside gtimelog itself is main.py:1116, which reads

    color = style.get_color(gtk.StateFlags.NORMAL)

Looks like my panel background color detection hack is broken.

I can reproduce the segfault by doing this:

    $ python
    >>> import gi
    >>> from gi.repository import Gtk
    >>> Gtk.MenuBar().get_style_context().get_color(Gtk.StateFlags.NORMAL)

As a quick workaround edit ~/.gtimelog/gtimelogrc and set show_tray_icon to False.

Filed upstream as https://bugzilla.gnome.org/show_bug.cgi?id=678607

Simple workaround:

--- src/gtimelog/main.py
+++ src/gtimelog/main.py
@@ -1054,7 +1054,8 @@
         # not necessarily the case! this logic works for, say,
         # Ambiance/Radiance, but it gets New Wave and Dark Room wrong.
         if toolkit == 'gi':
- style = gtk.MenuBar().get_style_context()
+ m = gtk.MenuBar()
+ style = m.get_style_context()
             color = style.get_color(gtk.StateFlags.NORMAL)
             value = (color.red + color.green + color.blue) / 3
         else:

pitti's suggested workaround is in lp:gtimelog trunk now and it works fine with today's quantal CD image.

On Jun 22, 2012, at 11:24 AM, Martin Pitt wrote:

>--- src/gtimelog/main.py
>+++ src/gtimelog/main.py
>@@ -1054,7 +1054,8 @@
> # not necessarily the case! this logic works for, say,
> # Ambiance/Radiance, but it gets New Wave and Dark Room wrong.
> if toolkit == 'gi':
>- style = gtk.MenuBar().get_style_context()
>+ m = gtk.MenuBar()
>+ style = m.get_style_context()
> color = style.get_color(gtk.StateFlags.NORMAL)
> value = (color.red + color.green + color.blue) / 3
> else:

That's gotta be a reference counting bug in pygi.

This bug was fixed in the package gtimelog - 0.7.1-0ubuntu2

---------------
gtimelog (0.7.1-0ubuntu2) quantal; urgency=low

  * Apply upstream patch to work around gobject menu reference counting
    bug. (LP: #1016212)
 -- Barry Warsaw <email address hidden> Mon, 13 Aug 2012 13:30:21 -0400

Fixed in 0.8.0.