Panda: adb over usb broken on panda-ics-gcc47-tilt-tracking-blob/#build=101"

Observed on Linaro Android image with Panda 4430:

https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=105

No any related log shows when plug in & plug out USB cable.

Observed on Panda 4430 with image:

https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=111

(adding Vishal)

Notice that in omap4plus_defconfig, we now build musb support as a module.

This is done because the one kernel also supports PandaBoard 5, which does not have mUSB.

By default then, if you don't insert the mUSB related module(s), you won't get anything coming on the OTG socket / ADB.

Andy I have enabled usb_G_ANDROID in the kernel and rebuilt it. After booting I have loaded musb_hdrc driver and then tried to enable android adb functionality by following commands :

echo "adb" > /sys/class/android_usb/android0/functions
echo 1 > /sys/class/android_usb/android0/enable

but it doesn't seem to work. attached is the kernel config . Am I missing something here ?

Jassi's going to try to reproduce... about USB_G_ANDROID though isn't that taken care of by the Android config fragment? If it isn't it should be I guess.

Andy : OMAP5 uses DWC3, while OMAP4 MUSB. I see no problem with both stacks built into the kernel. Only the one which has the relevant platform device populated (based upon which platform is it), would spring to life. The other shouldn't make any difference. BTW, I couldn't find Panda-omap5 even initializing USB gadget side.

Vishal : The following changes to your omap4plus_defconfig above, should get it working.

167c167
< CONFIG_USB_DWC3=m
---
> CONFIG_USB_DWC3=y
170,171c170,171
< CONFIG_USB_MUSB_HDRC=m
< CONFIG_USB_MUSB_OMAP2PLUS=m
---
> CONFIG_USB_MUSB_HDRC=y
> CONFIG_USB_MUSB_OMAP2PLUS=y
176,178c176
< CONFIG_USB_GADGET_MUSB_HDRC=m
< CONFIG_USB_ZERO=m
< CONFIG_USB_MASS_STORAGE=m
---
> CONFIG_USB_GADGET_MUSB_HDRC=y

Thanks Jassi... I was trying to have them modular so we don't have the footprint of the one that is not needed (dwc3 on OMAP4, musb on OMAP5) taking up RAM. But, it's more of an optimization compared to stuff not working so this sounds like a good way.

Observed on Panda 4430 board with Linaro Android image:

https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=116

Jassi,

It is still not working. Here is the uppdated config.Let me know if I am missing something

Vishal, Botao,
   I still think it's you doing config wrong somehow.
 I just checked out @1010fcd of build-116 and compiled with the attached .config. Could you please do the same and report the result ?
Thanks.

Jassi,

There is a problem with the configs. With the config https://bugs.launchpad.net/linaro-android/+bug/1017438/+attachment/3224646/+files/omap4plus_defconfig, config set is wrongly as "CONFIG_USB_MUSB_OMAP2PLUS=m" .I have to manually need to set to "CONFIG_USB_MUSB_OMAP2PLUS=y" .

The problem is choice "Platform Glue Layer" in drivers/usb/musb/Kconfig which is getting selected as a module.

Let me know if I am doing it wrong.

observed on panda 4460

https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=123

Vishal if I go look at the link for the attachment, I see in there

CONFIG_USB_MUSB_OMAP2PLUS=y
CONFIG_USB_GADGET_MUSB_HDRC=y

are there more steps you are doing to generate the bad config that makes the problem? Can you outline these extra steps if there are any so we can try to understand why we get different results?

Andy,

I am only using this config to build against the kernel.Here is what I did:
1. Copied the config to arch/arm/configs.
2. make ARCH=arm omap4plus_defconfig
3. make ARCH=arm menuconfig
4. Checked the configuration for "USB_MUSB_OMAP2PLUS" shown below.

 Symbol: USB_MUSB_OMAP2PLUS [=m] │
  │ Type : tristate │
  │ Prompt: OMAP2430 and onwards │
  │ Defined at drivers/usb/musb/Kconfig:49 │
  │ Depends on: <choice> && ARCH_OMAP2PLUS [=y] │
  │ Location: │
  │ -> Device Drivers │
  │ -> USB support (USB_SUPPORT [=y]) │
  │ -> Inventra Highspeed Dual Role Controller (TI, ADI, ...) (USB_MUSB_HDRC [=y]) │
  │ -> Platform Glue Layer (<choice> [=m]) │

The choice state for "Platform Glue Layer" is not reflecting the right configuration.

Vishal, Could you please tell the release for which the config worked as you expect ?

Jassi,

I have tried on https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob-12.07-release/

and also on the tilt kernel 12.07 release tag:
http://git.linaro.org/gitweb?p=landing-teams/working/ti/kernel.git;a=shortlog;h=refs/tags/android-release-2012-07

Vishal, I am asking for some release that worked fine for you :)

Here is a build for 3.2 kernel where it was working fine:
https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-stable-blob/#build=86

Hi Vishal, The attached change to omap4plus_defconfig should get it working.

exists on panda board build
https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob-12.07-release/#build=3

on panda 4430 build
https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=142

on panda 4460
https://android-build.linaro.org/builds/~linaro-android/panda-ics-gcc47-tilt-tracking-blob/#build=142

Thanks Jassi the patch https://bugs.launchpad.net/linaro-android/+bug/1017438/+attachment/3234418/+files/omap4plus_defconfig.patch gets adb working.

submitted to gerrit:
http://review.android.git.linaro.org/#change,2530