OpenStack Compute (nova)

pep8 HACKING checks should exclude openstack-common files

Bug #1020792 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Dan Prince
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Nova pep8 HACKING checks currently fail on openstack-common:

./nova/openstack/common/gettextutils.py:32:7: NOVA N701: Empty localization string
def _(msg):
      ^

Given that openstack-common is copied into Nova for now we should exclude it from Nova specific pep8 HACKING checks.

Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/9372

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/9403

Changed in nova:
assignee: Dan Prince (dan-prince) → Sean Dague (sdague-b)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/9403
Committed: http://github.com/openstack/nova/commit/7b43eaa9d8075c3d05fd17d19de12793a9c09692
Submitter: Jenkins
Branch: master

commit 7b43eaa9d8075c3d05fd17d19de12793a9c09692
Author: Sean Dague <email address hidden>
Date: Thu Jul 5 16:36:34 2012 -0400

    modify hacking.py to not choke on the def of _()

    recent openstack-common brought in it's own def of _() which trips
    up our checking that all _ calls contain a message string.

    This explicitly excludes the definition of this in function from
    that check.

    Fixes LP Bug #1020792.

    Change-Id: If647d77a5ae5560935bb2e032331c34b896b8614

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Dan Prince (dan-prince) wrote :

Even though Sean's branch fixed the hacking violation in gettextutils.py we should still exclude openstack-common from Nova's pep8 checks.

Openstack common can have its own pep8 rules/version and that should cause errors in Nova.

Changed in nova:
assignee: Sean Dague (sdague-b) → Dan Prince (dan-prince)
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/9779

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/9779
Committed: http://github.com/openstack/nova/commit/1ef88fdd5bdab4a83c011277c6693c9ed500c0b7
Submitter: Jenkins
Branch: master

commit 1ef88fdd5bdab4a83c011277c6693c9ed500c0b7
Author: Dan Prince <email address hidden>
Date: Fri Jul 13 13:47:10 2012 -0400

    Exclude openstack-common from pep8 checks.

    Updates tox.ini and run_tests.sh to exclude openstack-common code
    from pep8 checks.

    Fixes LP Bug #1020792

    Change-Id: I6bb9747f86f7677f0e9c4169c04d6f3fbd4b3480

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.