Lucid to Precise upgrade test failed: User settings are not preserved on upgrade

Bug #1022864 reported by Victor Zhou
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gsettings-desktop-schemas (Ubuntu)
New
High
Unassigned
Precise
Invalid
High
Canonical Desktop Team
Quantal
Won't Fix
High
Unassigned

Bug Description

Automated desktop upgrade test from Oneiric to Precise failed in Jenkins, due to user settings are not preserved on upgrade.

 Traceback (you can find more in the attached bootstrap.log):
 File "/tmp/test_lts_upgrade_user.py", line 45, in test_gtk_theme
     self.assertEqual(iface_settings.get_string('gtk-theme'), 'Radiance')
    AssertionError: 'Ambiance' != 'Radiance'

Link to the 1 of the failed jobs:
https://jenkins.qa.ubuntu.com/view/Precise/view/Upgrade%20Testing%20Dashboard/job/precise-upgrade-lucid-desktop/169/ARCH=i386,LTS=lts,PROFILE=ubuntu,label=upgrade-test/

Revision history for this message
Victor Zhou (victor.zhou) wrote :
summary: - Oneiric to Precise upgrade failed: User settings are not preserved on
- upgrade
+ Oneiric to Precise upgrade test failed: User settings are not preserved
+ on upgrade
Revision history for this message
Victor Zhou (victor.zhou) wrote : Re: Oneiric to Precise upgrade test failed: User settings are not preserved on upgrade

Lucid 2 Precise upgrade test failed on the same reason as this bug.

Changed in ubuntu-release-upgrader (Ubuntu Precise):
importance: Undecided → Critical
Changed in ubuntu-release-upgrader (Ubuntu Quantal):
importance: Undecided → High
Revision history for this message
Colin Watson (cjwatson) wrote :

The release upgrader doesn't deal with this. As a first guess, I'm going to go with gsettings-desktop-schemas, since that ships the gsettings schema in question.

Changed in ubuntu-release-upgrader (Ubuntu Precise):
importance: Critical → High
affects: ubuntu-release-upgrader (Ubuntu Precise) → gsettings-desktop-schemas (Ubuntu Precise)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the report, could you give details on what /tmp/test_lts_upgrade_user.py is and maybe provide the function that is hitting the error and give some details on the context?

Changed in gsettings-desktop-schemas (Ubuntu Precise):
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
Revision history for this message
Victor Zhou (victor.zhou) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

that test doesn't really make sense to me, how is the 10.04 config set and how do you migrate it? the default theme in Ubuntu is "Ambiance", shouldn't the test check for that? Or do you change the test, upgrade, reboot and run that check?

description: updated
summary: - Oneiric to Precise upgrade test failed: User settings are not preserved
+ Lucid to Precise upgrade test failed: User settings are not preserved
on upgrade
tags: added: lucid2precise
removed: oneiric2precise
Revision history for this message
Martin Pitt (pitti) wrote :

That's just the second half of the test. The first half is setting up some user config in 10.04:

http://bazaar.launchpad.net/~auto-upgrade-testing-dev/auto-upgrade-testing/trunk/view/head:/share/scripts/prepare_lts_user

There is also a corresponding pair of prepare_lts_desktop / test_lts_upgrade_system.py scripts for some system-level configuration migration (gdm -> lightdm), but it seems this is succeeding.

Victor, where in the logs does it show the call of the prepare_lts_user script? This needs to be run before starting the dist-upgrade, i. e. in the 10.04 installation.

tags: removed: rls-q-incoming
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

I ran the following test manually:
1. On lucid up-to-date, set the theme to 'Radiance' from the "appearance" dialog.
2. Upgrade to Precise
3. Verify of the theme after upgrade:

- Visually the theme of windows decoration is 'Radiance' but the theme of the top panel is 'Ambiance'
- gconftool -g /desktop/gnome/interface/gtk_theme returns Radiance (which was set before the upgrade)
- Querying interface settings through gio returns 'Ambiance'
>>> from gi.repository import Gio
>>> iface_settings = Gio.Settings('org.gnome.desktop.interface')
>>> iface_settings.get_string('gtk-theme')
'Ambiance'

Changed in gsettings-desktop-schemas (Ubuntu Precise):
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

@jibel: thanks

- Did you reboot after the upgrade? can you add your .xsession-errors after the first login to the bug?

you can use the command line gsettings tool rather than python there btw:
"gsettings get org.gnome.desktop.interface gtk-theme"

can you also run "gsettings-data-convert --dry-run --verbose" and copy the log here?

Changed in gsettings-desktop-schemas (Ubuntu Precise):
status: Confirmed → Incomplete
Changed in gsettings-desktop-schemas (Ubuntu Quantal):
status: New → Won't Fix
Revision history for this message
Sebastien Bacher (seb128) wrote :

settings wontfix for quantal, we don't support < precise to quantal updates, and there is nothing to migrate when going from precise to quantal

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Yes, I rebooted after upgrade. I attached .xsession-errors file from the first login after upgrade.

Here is the output of gsettings get:
$ gsettings get org.gnome.desktop.interface gtk-theme
'Ambiance'

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

And the output of gsettings-data-convert:

$ gsettings-data-convert --dry-run --verbose
Directory '/usr/share/ubuntu-2d/GConf/gsettings' does not exist, nothing to do
Directory '/usr/share/gnome/GConf/gsettings' does not exist, nothing to do
Directory '/usr/local/share/GConf/gsettings' does not exist, nothing to do
Directory '/usr/share/GConf/gsettings' all uptodate, nothing to do

Changed in gsettings-desktop-schemas (Ubuntu Precise):
status: Incomplete → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

could you add your ~/.local/share/gsettings-data-convert to the bug?

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

oh, sorry, looking through details that's not a bug:

changelog extract:

" * dont_reset_themes.patch: Do not migrate the themes, as many are not
    available in the GTK 3 world any more. Just keep the font and color
    schema, as these are still fully available. (LP: #969569)"

Changed in gsettings-desktop-schemas (Ubuntu Precise):
status: Confirmed → Invalid
Revision history for this message
Sebastien Bacher (seb128) wrote :

we don't have a smart way to migrate only the default theme, the way the migration system work is either we migrate the key value or not ... there were hundred of gtk2 themes out there and an UI to set those so lot of users have a custom theme, upgrading the theme has no equivalent for gtk3 and migrating the value would create issues, it's safer to reset the theme

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.