The "enabled" field is not type-safe nor is it normalized

Bug #1023544 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Adam Young

Bug Description

Marking a user or tenant enabled using the keystone admin API (with at least the SQL backend) by doing this:

POST /users/<USER_ID>/enabled

with these payloads:

{'enabled': 'TRUE'}
{'enabled': 'True'}
{'enabled': true}

results in completely different results. This is because enabled is not a real column, as it's locked away in a JSON BLOB.

One ramification of this is that the enabled column in Horizon's users and tenants views shows different cases for the word True or False.

Joseph Heck (heckj)
Changed in keystone:
status: New → Triaged
importance: Undecided → Low
Adam Young (ayoung)
Changed in keystone:
assignee: nobody → Adam Young (ayoung)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16322

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/16322
Committed: http://github.com/openstack/keystone/commit/1012bd42df5906bca67a82663f23b5c8a4eafe68
Submitter: Jenkins
Branch: master

commit 1012bd42df5906bca67a82663f23b5c8a4eafe68
Author: Adam Young <email address hidden>
Date: Tue Nov 6 17:16:56 2012 -0500

    normalize identity

    modify tables by adding columns, and modify entities
    by adding attributes for password, description and enabled

    update tests to deal with change from 'False' and 'True' to the
    python values False and True

    Added a Text type from SQL Alchemy

    Bug 1070351
    Bug 1023544

    Change-Id: I066c788b5d08a8f42a9b5412ea9e29e4fe9ba205

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.