Fix Quantum Rootwrap

Bug #1037815 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
john dunning

Bug Description

nova-rootwrap has significantly evolved over the Folsom cycle. Quantum forked it around Essex time. Since then it looks very abandoned (lots of missing filters), while Quantum grew some adherence to using root_helper=sudo.

Quantum rootwrap should therefore be fixed in order to be in sync with rootwrap modules for other openstack projects

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Gerrit topic: https://review.openstack.org/#q,topic:bp/quantum-remove-rootwrap,n,z

Addressed by: https://review.openstack.org/11026
    Remove non-functioning quantum-rootwrap

[8/15/12] I (jrd) have been testing a fix, and expect to upload it as a WIP patch in the next few hours. I'm hoping we can slide it in for the Folsom release, rather then ripping the facility out.

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
john dunning (jrd-q) wrote :

Patch uploaded.

 https://review.openstack.org/11524

Review solicited.

TIA!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/11524
Committed: http://github.com/openstack/quantum/commit/193d6997276d3efcfaf99e5fcca1354c8c8c4670
Submitter: Jenkins
Branch: master

commit 193d6997276d3efcfaf99e5fcca1354c8c8c4670
Author: John Dunning <email address hidden>
Date: Tue Aug 14 14:31:47 2012 -0400

    Update rootwrap; track changes in nova/cinder

    Fix bug 1037815

    Summary: Copy/paste the essential parts of the rootwrap
      mechanism from nova/cinder into quantum. This includes
      the core changes to filter.py and wrapper.py which deal
      with loading filters from files pointed to by
      rootwrap.conf
    Detailed changes:
      Transliterate the old rootwrap/*-agent.py files to
      new format, and put the results in etc/quantum/rootwrap.d
      Delete the *-agent.py files.
      Add conf to point to etc/quantum/rootwrap.d
      Add a unit test cribbed from nova to exercise the filter
      mechanism
      Add a unit test to exercise the actual filtered execution
    Note that as written, this patch does not set the default
      execute mechanism (in the agent .ini files) to rootwrap,
      leaves it as sudo. That can be done in a followon
      change, or in distro specific packaging.
    Note also that there is still work to do around finishing
      and testing the filter specs themselves. We've decided
      that that is out of scope for this patch.

    Change-Id: I9aba6adc5ba40b6145be5fa38c5ece3b666ae5ca

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.