Percona Server moved to https://jira.percona.com/projects/PS

Buffer pool locking error on reads from tablespaces being deleted

Bug #1042640 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
High
Stewart Smith
Percona Server moved to https://jira.percona.com/projects/PS 5.5.28-29.1
5.1
Invalid
Undecided
Unassigned
5.5
Fix Released
High
Stewart Smith
Percona Server moved to https://jira.percona.com/projects/PS 5.5.28-29.1

Bug Description

Found by code analysis:

if buf_read_page_low() I/O requests returns DB_TABLESPACE_DELETED, an assertion crash will happen on debug build and buffer LRU list corruption will happen on release build. This is a new code introduced by upstream revision 0.16677.56 [1]. It was automerged to XtraDB, adding a new function buf_read_page_handle_error(), that acquires and releases the buffer pool mutex. It should be the LRU list mutex instead. That function calls buf_LRU_free_one_page(), adjusted to assert that it holds the buffer pool mutex, which in turn calls unchanged function buf_LRU_block_remove_hashed_page(), which asserts that it holds the LRU list mutex.

[1]
revno: 0.16677.56
committer: Yasufumi Kinoshita <email address hidden>
branch nick: mysql-5.5_test
timestamp: Fri 2012-06-29 12:04:44 +0900
message:
  Bug#14251529 : FIX FOR BUG 13704145 CREATES POSSIBLE RACE CONDITION
  make buf_read_page_low() to treat DB_TABLESPACE_DELETED error correctly
  rb#1129 approved by Inaam

Related branches

lp:~stewart/percona-server/5.5.28
Laurynas Biveinis (community): Needs Fixing
Alexey Kopytov (community): Approve
Diff: 7306 lines (+3362/-738)
131 files modified
Makefile (+2/-2)
Percona-Server/CMakeLists.txt (+3/-0)
Percona-Server/Docs/INSTALL-BINARY (+3/-3)
Percona-Server/VERSION (+1/-1)
Percona-Server/client/mysql.cc (+14/-6)
Percona-Server/client/mysql_upgrade.c (+2/-2)
Percona-Server/client/mysqladmin.cc (+4/-3)
Percona-Server/client/mysqlbinlog.cc (+13/-1)
Percona-Server/client/mysqlcheck.c (+2/-2)
Percona-Server/client/mysqldump.c (+5/-3)
Percona-Server/client/mysqlimport.c (+2/-4)
Percona-Server/client/mysqlshow.c (+2/-2)
Percona-Server/client/mysqlslap.c (+2/-2)
Percona-Server/client/mysqltest.cc (+1/-1)
Percona-Server/client/sql_string.h (+7/-3)
Percona-Server/cmake/ssl.cmake (+1/-1)
Percona-Server/extra/perror.c (+3/-2)
Percona-Server/extra/yassl/README (+10/-1)
Percona-Server/extra/yassl/include/lock.hpp (+5/-4)
Percona-Server/extra/yassl/include/openssl/ssl.h (+1/-1)
Percona-Server/extra/yassl/include/yassl_error.hpp (+1/-1)
Percona-Server/extra/yassl/src/cert_wrapper.cpp (+1/-2)
Percona-Server/extra/yassl/src/lock.cpp (+2/-2)
Percona-Server/extra/yassl/src/ssl.cpp (+2/-3)
Percona-Server/extra/yassl/src/yassl_error.cpp (+1/-6)
Percona-Server/extra/yassl/taocrypt/include/aes.hpp (+0/-1)
Percona-Server/extra/yassl/taocrypt/include/pwdbased.hpp (+3/-1)
Percona-Server/extra/yassl/taocrypt/src/asn.cpp (+3/-1)
Percona-Server/extra/yassl/taocrypt/src/coding.cpp (+21/-0)
Percona-Server/extra/yassl/taocrypt/src/crypto.cpp (+0/-37)
Percona-Server/extra/yassl/taocrypt/taocrypt.dsw (+16/-1)
Percona-Server/extra/yassl/taocrypt/test.dsp (+0/-102)
Percona-Server/extra/yassl/taocrypt/test/memory.cpp (+1/-1)
Percona-Server/extra/yassl/taocrypt/test/test.dsp (+102/-0)
Percona-Server/extra/yassl/yassl.dsw (+1/-4)
Percona-Server/include/mysql/thread_pool_priv.h (+6/-0)
Percona-Server/include/welcome_copyright_notice.h (+13/-8)
Percona-Server/libmysqld/lib_sql.cc (+1/-0)
Percona-Server/mysql-test/r/information_schema.result (+2/-0)
Percona-Server/mysql-test/r/log_state.result (+6/-6)
Percona-Server/mysql-test/r/mysqlshow.result (+10/-4)
Percona-Server/mysql-test/r/openssl_1.result (+3/-3)
Percona-Server/mysql-test/r/subselect.result (+0/-2)
Percona-Server/mysql-test/r/variables.result (+2/-2)
Percona-Server/mysql-test/suite/federated/federated.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_archive.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_bug_13118.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_bug_25714.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_bug_35333.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_debug.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_innodb.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_server.test (+2/-2)
Percona-Server/mysql-test/suite/federated/federated_transactions.test (+2/-2)
Percona-Server/mysql-test/suite/federated/include/federated.inc (+1/-1)
Percona-Server/mysql-test/suite/funcs_1/t/is_engines_federated.test (+1/-1)
Percona-Server/mysql-test/suite/innodb/r/innodb_information_schema_buffer.result (+130/-0)
Percona-Server/mysql-test/suite/innodb/r/percona_skip_innodb_i_s.result (+3/-0)
Percona-Server/mysql-test/suite/innodb/t/innodb_information_schema_buffer.test (+76/-0)
Percona-Server/mysql-test/suite/perfschema/t/disabled.def (+0/-1)
Percona-Server/mysql-test/suite/rpl/r/rpl_cant_read_event_incident.result (+3/-1)
Percona-Server/mysql-test/suite/rpl/t/rpl_bug41902.test (+2/-2)
Percona-Server/mysql-test/suite/rpl/t/rpl_cant_read_event_incident.test (+6/-1)
Percona-Server/mysql-test/suite/sys_vars/r/engine_condition_pushdown_basic.result (+28/-28)
Percona-Server/mysql-test/suite/sys_vars/r/log_basic.result (+3/-3)
Percona-Server/mysql-test/suite/sys_vars/r/log_slow_queries_basic.result (+9/-9)
Percona-Server/mysql-test/suite/sys_vars/r/rpl_recovery_rank_basic_32.result (+17/-17)
Percona-Server/mysql-test/suite/sys_vars/r/rpl_recovery_rank_basic_64.result (+17/-17)
Percona-Server/mysql-test/suite/sys_vars/r/sql_big_selects_func.result (+1/-1)
Percona-Server/mysql-test/suite/sys_vars/r/sql_max_join_size_basic.result (+5/-5)
Percona-Server/mysql-test/suite/sys_vars/r/sql_max_join_size_func.result (+7/-7)
Percona-Server/mysql-test/t/openssl_1.test (+6/-0)
Percona-Server/mysql-test/t/partition_federated.test (+1/-1)
Percona-Server/mysys/mf_iocache.c (+6/-1)
Percona-Server/mysys/my_getopt.c (+5/-0)
Percona-Server/scripts/mysql_secure_installation.pl.in (+7/-3)
Percona-Server/scripts/mysql_secure_installation.sh (+13/-5)
Percona-Server/scripts/mysqlhotcopy.sh (+71/-21)
Percona-Server/sql/filesort.cc (+2/-4)
Percona-Server/sql/gen_lex_hash.cc (+2/-2)
Percona-Server/sql/ha_partition.cc (+90/-43)
Percona-Server/sql/ha_partition.h (+2/-10)
Percona-Server/sql/handler.cc (+27/-2)
Percona-Server/sql/item.cc (+6/-1)
Percona-Server/sql/item.h (+1/-0)
Percona-Server/sql/item_strfunc.cc (+35/-18)
Percona-Server/sql/item_subselect.cc (+1/-1)
Percona-Server/sql/log.cc (+4/-4)
Percona-Server/sql/log_event.h (+1/-1)
Percona-Server/sql/mdl.cc (+112/-8)
Percona-Server/sql/mdl.h (+6/-0)
Percona-Server/sql/mysqld.cc (+16/-1)
Percona-Server/sql/opt_range.cc (+24/-16)
Percona-Server/sql/set_var.cc (+17/-20)
Percona-Server/sql/set_var.h (+2/-2)
Percona-Server/sql/share/charsets/Index.xml (+1/-1)
Percona-Server/sql/share/errmsg-utf8.txt (+2/-2)
Percona-Server/sql/spatial.cc (+6/-5)
Percona-Server/sql/spatial.h (+8/-0)
Percona-Server/sql/sql_base.cc (+15/-8)
Percona-Server/sql/sql_class.cc (+23/-0)
Percona-Server/sql/sql_list.h (+4/-0)
Percona-Server/sql/sql_plugin.cc (+3/-2)
Percona-Server/sql/sql_prepare.cc (+8/-0)
Percona-Server/sql/sql_select.cc (+35/-18)
Percona-Server/sql/sql_string.h (+7/-3)
Percona-Server/sql/sys_vars.cc (+6/-6)
Percona-Server/sql/sys_vars.h (+40/-40)
Percona-Server/storage/archive/ha_archive.cc (+3/-3)
Percona-Server/storage/federated/ha_federated.cc (+1/-1)
Percona-Server/storage/innobase/btr/btr0btr.c (+15/-6)
Percona-Server/storage/innobase/btr/btr0cur.c (+22/-17)
Percona-Server/storage/innobase/btr/btr0pcur.c (+31/-36)
Percona-Server/storage/innobase/buf/buf0buf.c (+1/-10)
Percona-Server/storage/innobase/buf/buf0lru.c (+1/-1)
Percona-Server/storage/innobase/buf/buf0rea.c (+2/-2)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+4/-1)
Percona-Server/storage/innobase/handler/i_s.cc (+1852/-2)
Percona-Server/storage/innobase/handler/i_s.h (+3/-0)
Percona-Server/storage/innobase/ibuf/ibuf0ibuf.c (+12/-5)
Percona-Server/storage/innobase/include/buf0buf.h (+31/-2)
Percona-Server/storage/innobase/include/buf0buf.ic (+19/-0)
Percona-Server/storage/innobase/include/fil0fil.h (+2/-0)
Percona-Server/storage/innobase/include/log0log.h (+3/-0)
Percona-Server/storage/innobase/page/page0page.c (+11/-10)
Percona-Server/storage/innobase/row/row0ins.c (+8/-1)
Percona-Server/storage/innobase/row/row0merge.c (+14/-0)
Percona-Server/storage/myisam/ha_myisam.cc (+2/-1)
Percona-Server/support-files/mysql.spec.sh (+28/-0)
Percona-Server/tests/mysql_client_fw.c (+11/-5)
Percona-Server/tests/mysql_client_test.c (+5/-2)
Percona-Server/vio/viosslfactories.c (+59/-41)
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-580

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.