neutron

Plugin test loads target plugin at each test setup but doesn't load according extensions

Bug #1043381 reported by MURAOKA Yusuke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
MURAOKA Yusuke
neutron 2012.2 "folsom"

Bug Description

PluginAwareExtensionManager caches extensions according testing plugin.
In db plugin tests, at each test setup, router is newly created, and the extension manager is also loaded.
So if a plugin conditional extension exists, it can not be loaded by testing order.
Because the extension manager caches extensions which for first loaded plugin.

See original description
Revision history for this message
MURAOKA Yusuke (yusuke) wrote :

Patch is here. https://review.openstack.org/#/c/12105/

dan wendlandt (danwent)
Changed in quantum:
status: New → In Progress
importance: Undecided → Medium
milestone: none → folsom-rc1
assignee: nobody → MURAOKA Yusuke (yusuke)
MURAOKA Yusuke (yusuke)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/12105
Committed: http://github.com/openstack/quantum/commit/19e553e1deeb8939decd1ed9554a3c6eb6770386
Submitter: Jenkins
Branch: master

commit 19e553e1deeb8939decd1ed9554a3c6eb6770386
Author: Yusuke Muraoka <email address hidden>
Date: Tue Aug 28 09:59:42 2012 +0000

    Plugin aware extensions should also be reset at each test setup

    PluginAwareExtensionManager caches extension according plugin.
    At each db plugin test setup, testing plugin and router are newly
    created.
    However, the extension manager held the extensions for first time
    loaded plugin. Because of their cache.

    So if a plugin conditional extension exists, it could not be loaded by
    testing order.

    Fixes bug 1043381.

    Change-Id: Ic994aab61c3d67aa9d422594484049f41ff8b321

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.