server response to 500 error is unhelpful

Bug #1048109 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
dan wendlandt

Bug Description

Currently, a 500 error on the server results in the server returning a message body that includes str(e), where e is the exception object. This can lead to leaking internal server details (bad), and very confusing messages. For example, when the server had an exception that was a "KeyError: 'id'", the server returned;

EBUG: quantumclient.client RESP BODY:{"QuantumError": "'id'"}

This results in very confusing output, for example, an attempt to create a floating IP which failed with the above message body appears to the user as:

nicira@com-dev:~/devstack$ quantum floatingip-create e7ad2c17-1cca-41fb-bb03-2e0b2b83703c --port_id e2b3a272-2bb7-486b-872b-38d11646d19b
'id'

That is, it just prints "id" and that's it.

dan wendlandt (danwent)
Changed in quantum:
status: New → In Progress
importance: Undecided → High
assignee: nobody → dan wendlandt (danwent)
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12667

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/12667
Committed: http://github.com/openstack/quantum/commit/fde632fc5cc95d5abceb0493d2cbdcf274c11043
Submitter: Jenkins
Branch: master

commit fde632fc5cc95d5abceb0493d2cbdcf274c11043
Author: Dan Wendlandt <email address hidden>
Date: Sat Sep 8 22:18:39 2012 -0700

    Give better error to client on server 500 error

    bug 1048109

    Change-Id: Iaaa187a7868ee6227315b9c3354b424fe7c42508

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.