Cinder

cinder admin based on hard-coded 'admin' role

Bug #1053181 reported by clayg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
clayg
Cinder 2013.1 "grizzly"

Bug Description

There are many places in the code (especially the database layer) that rely on checking context.is_admin. Unfortunately is_admin is still set from a hard coded role 'admin'. This should be changed to set it based on a policy check.

nova recently fixed a similar issue in bug 1037786

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13327

Changed in cinder:
assignee: nobody → clayg (clay-gerrard)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/13327
Committed: http://github.com/openstack/cinder/commit/bdee787cf79c359cc4583483e010ddf3d356cb18
Submitter: Jenkins
Branch: master

commit bdee787cf79c359cc4583483e010ddf3d356cb18
Author: Clay Gerrard <email address hidden>
Date: Mon Oct 1 11:33:25 2012 -0500

    Use policy based rule to define context.is_admin

    When creating a context set is_admin based on policy instead of
    hard coded requirement for a role named 'admin'.

    Fixes: bug# 1053181

    Change-Id: I9c05b8ecde887467557c4f01e074145b6a6372aa

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
tags: added: folsom-backport-potential
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.