Gtk2Reactor object has no attribute simulate
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Deluge |
Fix Released
|
Unknown
|
|||
deluge (Ubuntu) |
Fix Released
|
Medium
|
Andrew Starr-Bochicchio | ||
Precise |
Fix Released
|
Medium
|
Andrew Starr-Bochicchio |
Bug Description
[IMPACT]
Changes in Twisted cause Deluge's connection manager to not launch on start up. This is in Twisted 12 in quantal and also in precise as we backported the changes to Gtk2Reactor in a patch to Twisted 11.
This can cause confusion for users if they have disabled "classic" mode and need to start the daemon.
Traceback (most recent call last):
File "/usr/lib/
DeferredLis
File "/usr/lib/
callbackKey
File "/usr/lib/
self.
File "/usr/lib/
current.result = callback(
--- <exception caught here> ---
File "/usr/lib/
callable(*args, **kwargs)
File "/usr/lib/
self.
File "/usr/lib/
reactor.
exceptions.
[TESTCASE]
Make sure that "clasic" mode is not enabled in Preferences > Interface. Also make sure that "Do not show this dialog on startup" is _not_ checked in the Connection Manager dialog's options.
Launch "deluge" from the terminal. The version in precise will show you the above traceback. The verson that is in precise-proposed will launch without the traceback and the Connection Manager dialog will be shown
[Regression Potential]
There is not much regression potential as this patch backported fom upstream is simply a try/except statement:
@@ -373,7 +373,11 @@ Please see the details below for more information."), details=
if self.config[
# XXX: We need to call a simulate() here, but this could be a bug in twisted
- reactor.simulate()
+ try:
+ reactor._simulate()
+ except AttributeError:
+ # twisted < 12
+ reactor.simulate()
Changed in deluge (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Andrew Starr-Bochicchio (andrewsomething) |
Changed in deluge (Ubuntu Precise): | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Andrew Starr-Bochicchio (andrewsomething) |
description: | updated |
Changed in deluge: | |
status: | Unknown → Fix Released |
tags: |
added: verification-done removed: verification-needed |
Adding link to upstream commit as the diff get misformetted in the above discription:
http:// git.deluge- torrent. org/deluge/ commit/ ?h=1.3- stable& id=17cac01673d4 79ecb4f4dbbc16a 5c82bc19907e9