Known segfault in 1.1.19 (the current stable)

Bug #1065555 reported by Eugene Pimenov
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
nginx (Ubuntu)
Fix Released
High
Michael Lustfield
Precise
Fix Released
High
Unassigned

Bug Description

[IMPACT]

 * This bug has a severe impact on users running nginx.

 * This bug breaks the try_files directive, in that certain URIs and configurations will cause segfaults.

[TESTCASE]

 * The nginx forums post at http://forum.nginx.org/read.php?2,231787,231787#msg-231787 originally posted by Tom Vaughan (tvaughan) has sample configurations and sample tests. Use of those methods should reproduce this bug. This fix should prevent the unexpected closes (segfaults)

[Regression Potential]

 * This patch is extremely cherry-picked, and is a one-line change. Regression potential is near zero.

[Other Info]

 * This is a high priority bug. This was fixed in 1.2.0. Lack of an update in Precise to fix this bug will prevent the try_files directive from working correctly, which inhibits usage of nginx.

----------
----------

Original Bug Description:
-------

There's a known segfault in the "stable" version of nginx that is included in Ubuntu Precise.

The upstream bug report: http://trac.nginx.org/nginx/ticket/152
The fix committed in the following changeset: http://trac.nginx.org/nginx/changeset/4601/nginx

Could you backport the fix or release a new version?

Thank you.

Revision history for this message
Michael Lustfield (michaellustfield) wrote :

Could someone set the importance on this bug to High or higher? Thanks.

Changed in nginx (Ubuntu):
status: New → In Progress
assignee: nobody → Michael Lustfield (michaellustfield)
Thomas Ward (teward)
Changed in nginx (Ubuntu):
importance: Undecided → High
Revision history for this message
Tom Vaughan (tvaughan) wrote :
Revision history for this message
Thomas Ward (teward) wrote :

Marking fix released as this was fixed in upstream 1.2.0, and QUantal has a version newer than that.

Changed in nginx (Ubuntu Precise):
importance: Undecided → High
assignee: nobody → Michael Lustfield (michaellustfield)
status: New → In Progress
assignee: Michael Lustfield (michaellustfield) → Thomas Ward (trekcaptainusa-tw)
Changed in nginx (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Thomas Ward (teward) wrote :

Supplementary to Comment #3:

I will be cherrypicking the upstream patch and applying it to the Precise version, and will get this SRU'd.

Revision history for this message
Thomas Ward (teward) wrote :

This debdiff contains upstream code changes as part of a quilt patch. The patch was hand-made, as the upstream-generated diff would not apply, however the code changes are based in upstream.

The upstream code changes are located at http://trac.nginx.org/nginx/changeset/4601/nginx

Thomas Ward (teward)
description: updated
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Thomas, thanks for the debdiff, uploaded to precise-proposed where it will need to await SRU team approval (which may take a little while as the SRU/Release team are busy this week releasing 12.10)

Revision history for this message
Steven Williams (swilliams-sales) wrote : Re: [Bug 1065555] Re: Known segfault in 1.1.19 (the current stable)

Thanks for your help. I'm still trying to upload a browser? it says to
click on a new Browser and when I do the message still stays. I never get
away from the 3.6 one on my computer? How can I make the Browser download
stay and quit telling me to upgrade??

Steve Williams
713-992-0618 Cell
832-813-8332 Office
813-516-6289 FL
http://www.swsalesandconsulting.com

On Mon, Oct 15, 2012 at 5:11 PM, Thomas Ward <email address hidden> wrote:

> This debdiff contains upstream code changes as part of a quilt patch.
> The patch was hand-made, as the upstream-generated diff would not apply,
> however the code changes are based in upstream.
>
> The upstream code changes are located at
> http://trac.nginx.org/nginx/changeset/4601/nginx
>
> ** Patch added: "Debdiff for Precise"
>
> https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1065555/+attachment/3399483/+files/lp106555.debdiff
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1065555
>
> Title:
> Known segfault in 1.1.19 (the current stable)
>
> Status in “nginx” package in Ubuntu:
> Fix Released
> Status in “nginx” source package in Precise:
> In Progress
>
> Bug description:
> [IMPACT]
>
> * This bug has a severe impact on users running nginx.
>
> * This bug breaks the try_files directive, in that certain URIs and
> configurations will cause segfaults.
>
> [TESTCASE]
>
> * The nginx forums post at
> http://forum.nginx.org/read.php?2,231787,231787#msg-231787 originally
> posted by Tom Vaughan (tvaughan) has sample configurations and sample
> tests. Use of those methods should reproduce this bug. This fix
> should prevent the unexpected closes (segfaults)
>
> [Regression Potential]
>
> * This patch is extremely cherry-picked, and is a one-line change.
> Regression potential is near zero.
>
> [Other Info]
>
> * This is a high priority bug. This was fixed in 1.2.0. Lack of an
> update in Precise to fix this bug will prevent the try_files directive from
> working correctly, which inhibits usage of nginx.
>
> ----------
> ----------
>
> Original Bug Description:
> -------
>
> There's a known segfault in the "stable" version of nginx that is
> included in Ubuntu Precise.
>
> The upstream bug report: http://trac.nginx.org/nginx/ticket/152
> The fix committed in the following changeset:
> http://trac.nginx.org/nginx/changeset/4601/nginx
>
> Could you backport the fix or release a new version?
>
> Thank you.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/nginx/+bug/1065555/+subscriptions
>

Revision history for this message
Thomas Ward (teward) wrote :

Oops, prior debdiff contained excess cruft (failed upstream diff file, which i later hand-made).

This one should contain a version that works. Resubscribed the sponsors team, because this'll need to replace the prior sponsored one.

Revision history for this message
Thomas Ward (teward) wrote :

Oops, failed attachment :/

This one should be the correct debdiff.

I'll resubscribe sponsors.

Revision history for this message
Micah Gersten (micahg) wrote :

Uploaded, waiting for SRU review

I removed the From line from the patch since you were not the author.

Changed in nginx (Ubuntu Precise):
assignee: Thomas Ward (trekcaptainusa-tw) → nobody
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Eugene, or anyone else affected,

Accepted nginx into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nginx/1.1.19-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Eugene Pimenov (9-eugene-b) wrote :

Seems to work fine.

Thanks!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nginx - 1.1.19-1ubuntu0.1

---------------
nginx (1.1.19-1ubuntu0.1) precise-proposed; urgency=low

  * Applies upstream bug fixes
    * Segfault with try_files when first URI is shorter than request URI
      (LP: #1065555)
 -- Thomas Ward <email address hidden> Fri, 19 Oct 2012 12:15:39 -0400

Changed in nginx (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.