Wrong bootarg for disk with label

Bug #1079185 reported by Tryum
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
flash-kernel (Ubuntu)
Fix Released
High
Oliver Grawert
Quantal
Fix Released
High
Adam Conrad
Raring
Fix Released
High
Oliver Grawert

Bug Description

[Impact]

Installation fails on a Pandaboard on Quantal for users who previously had a volume label on an existing partition.

[Test Case]

Create and label an existing partition (eg. using e2label). Then run the installer. On first reboot, if the bug still exists, the system will fail to mount the root filesystem.

[Regression Potential]

We're changing calls to blkid only by being specific that we want the UUID instead of assuming that the UUID is on the first line. This has been tested in d-i on Quantal. I can only see this regression if blkid doesn't work as expected in this specific mode in some obscure case that we haven't considered.

[Original Description]

I just installed Ubuntu 12.10 on a pandaboard.

At the installation, I selected an empty partition named "ubuntu2" et checked the box for formating.

After the installation process, at the first boot, rootfs couldn't be mounted : the bootarg was "root=UUID=ubuntu2"

So I changed the preEnv.txt on my computer to "root=LABEL=ubuntu2" but sill couldn't boot, as the label was erased during format process.

I fixed it thanks to busybox by putting back label "ubuntu2" to my /dev/sda2 partition.

Revision history for this message
Tryum (tryum) wrote :
Revision history for this message
Oliver Grawert (ogra) wrote :

hmm, i cant see any issues in the logs, flash-kernel-installer is supposed to use:

blkid -o value $(mount | grep "on /${1%/} " | tail -n1 | cut -d' ' -f1) | head -1

for setting root= at the very end of the install, this should actually return the proper UUID instead of a label.

Revision history for this message
Tryum (tryum) wrote : Re: [Bug 1079185] Re: Wrong bootarg for disk with label

I'm really no expert in command line in linux, but this command above
gives me the label of the drive.

If i skip the 'head -1',

this is what i get :

thibault@panda12-10:~$ sudo blkid -o value $(mount | grep "on /${1%/}
" | tail -n1 | cut -d' ' -f1)
ubuntu2
9888f422-c54a-418e-884f-8e9b26aacd2a
ext2

On Fri, Nov 16, 2012 at 1:35 PM, Oliver Grawert <email address hidden> wrote:
> hmm, i cant see any issues in the logs, flash-kernel-installer is
> supposed to use:
>
> blkid -o value $(mount | grep "on /${1%/} " | tail -n1 | cut -d' ' -f1)
> | head -1
>
> for setting root= at the very end of the install, this should actually
> return the proper UUID instead of a label.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1079185
>
> Title:
> Wrong bootarg for disk with label
>
> Status in “flash-kernel” package in Ubuntu:
> New
>
> Bug description:
> I just installed Ubuntu 12.10 on a pandaboard.
>
> At the installation, I selected an empty partition named "ubuntu2" et
> checked the box for formating.
>
> After the installation process, at the first boot, rootfs couldn't be
> mounted : the bootarg was "root=UUID=ubuntu2"
>
> So I changed the preEnv.txt on my computer to "root=LABEL=ubuntu2" but
> sill couldn't boot, as the label was erased during format process.
>
> I fixed it thanks to busybox by putting back label "ubuntu2" to my
> /dev/sda2 partition.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/flash-kernel/+bug/1079185/+subscriptions

--
Thibault Jochem
Software Engineer
EFREI Promo 2007

Revision history for this message
Oliver Grawert (ogra) wrote :

ah, that explains it, thanks , i'll work on a fix

Oliver Grawert (ogra)
Changed in flash-kernel (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Oliver Grawert (ogra)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package flash-kernel - 3.0~rc.4ubuntu28

---------------
flash-kernel (3.0~rc.4ubuntu28) raring; urgency=low

  * make sure blkid only gives us the UUID and not any other metadata like
    labels or filesystem (LP: #1079185)
 -- Oliver Grawert <email address hidden> Fri, 16 Nov 2012 15:40:21 +0100

Changed in flash-kernel (Ubuntu Raring):
status: Confirmed → Fix Released
Robie Basak (racb)
description: updated
Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Hello Tryum, or anyone else affected,

Accepted flash-kernel into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/flash-kernel/3.0~rc.4ubuntu27.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in flash-kernel (Ubuntu Quantal):
status: New → Fix Committed
tags: added: verification-needed
Adam Conrad (adconrad)
Changed in flash-kernel (Ubuntu Quantal):
assignee: nobody → Adam Conrad (adconrad)
importance: Undecided → High
Revision history for this message
Robie Basak (racb) wrote :

Despite spending a considerable amount of time trying, I have been unable to reproduce this bug in Quantal for verification of -proposed. This is currently blocking the resolution of bug 1084106 which I've just bumped to Critical.

I'd appreciate any help getting the fix for this bug verified so that we can land the fix for critical bug 1084106. I don't feel that there's anything more than I can do for this bug without assistance here.

If we can't get this verified very soon, I've proposed that we revert the fix for this bug in quantal-proposed in order to allow the SRU through for bug 1084106. In this case we'll have to defer the fix for this bug in Quantal until someone is ready verify it, and then put it through the SRU queue again.n

Revision history for this message
Adam Conrad (adconrad) wrote :

Verified that flash-kernel now behaves correctly on filesystems where blkid returns the label before the uuid. Of note, this won't fix the ubiquity-based installer, as flash-kernel-installer is built in to ubiquity (and thus the images), and we're not respinning quantal images, but this does fix this same bug in both the netboot installer and in userspace, post-install.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package flash-kernel - 3.0~rc.4ubuntu27.1

---------------
flash-kernel (3.0~rc.4ubuntu27.1) quantal; urgency=low

  * Ask blkid for UUID, fixes finding filesystems with labels (LP: #1079185)
  * Determine the latest installed kernel version from the target instead
    of assuming the version is the same as the running kernel (LP: #1084106)
 -- Adam Conrad <email address hidden> Mon, 10 Dec 2012 09:31:39 -0700

Changed in flash-kernel (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.