Quotas did not treat bulk creations

Bug #1093749 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Gary Kotton

Bug Description

The bulk creations did not have correct treatment when it comes to the quotas. For example:
- network quota limit is 10
- send a bulk network create with 500 entries
- 500 entries will be created
Thanks
Gary

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18653

Changed in quantum:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Gary Kotton (garyk)
tags: added: folsom-backport-potential
Changed in quantum:
milestone: none → grizzly-2
importance: Undecided → High
Revision history for this message
Zhongyue Luo (zyluo) wrote :

What is the cause of this behavior?

Revision history for this message
Gary Kotton (garyk) wrote :

The problem is due to the logic used to check the quotas. When a collection of objects is received the code just checked that 1 object was to be added and not n.
If you look at the review above you will see the problem.
Thanks
Gary

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/18653
Committed: http://github.com/openstack/quantum/commit/24baea50675cd30758478b8f2e93460399ec786d
Submitter: Jenkins
Branch: master

commit 24baea50675cd30758478b8f2e93460399ec786d
Author: Gary Kotton <email address hidden>
Date: Wed Dec 26 07:24:37 2012 +0000

    Ensure bulk creations have quota validations

    Fixes bug 1093749

    The patch set also returns a proper error instead of a internal server
    error when the quotas are reached.

    Change-Id: Ifc74ffa8b54faa70f5558bf5263830f5e71f58ae

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.