rt2500 configuration tool missing .desktop file

Bug #113054 reported by Cesare Tirabassi
4
Affects Status Importance Assigned to Milestone
rt2500 (Ubuntu)
Fix Released
Medium
Emmet Hikory

Bug Description

Binary package hint: rt2500

A desktop file for the RT2500 configuration tool package is attached.

Tags: desktop-file
Changed in rt2500:
assignee: nobody → norsetto
status: Unconfirmed → In Progress
Revision history for this message
Cesare Tirabassi (norsetto) wrote :
Changed in rt2500:
assignee: norsetto → nobody
status: In Progress → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Corrected exec from su-to-root to gksu.

William Grant (wgrant)
Changed in rt2500:
importance: Undecided → Wishlist
Revision history for this message
Emmet Hikory (persia) wrote :

Thanks for your patch. Please remove the absolute path for the Icon (should be Icon=RaConfig2500.xpm), and upload a new debdiff. Also, Please consider filing a bug against the Debian rt2500 package, including the .desktop file, so that it may be used there as well (Debian doesn't need a debdiff, just the file).

Changed in rt2500:
assignee: nobody → norsetto
status: Confirmed → Needs Info
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Corrected patch with no absolute path for the icon.

Revision history for this message
Emmet Hikory (persia) wrote :

This patch doesn't compile for me on gutsy today. Firstly, the version of the package is different, and secondly, there are symbol problems with IFNAMSIZ in /usr/include/linux/wireless.h. I've unsubscribed ubuntu-universe-sponsors, as the patch cannot be uploaded in the current state. Please retest the patch and compilation against the current development environment, and resubscribe ubuntu-universe-sponsors when you would like to again request an upload. Thank you.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

The problem is not with the patch. The gutsy source (unpatched) doesn't compile as well, this is why the gutsy binary is the same as feisty, and this is why my patch doesn't apply to the gutsy source, but to the feisty source.
Infact, it compiles without any problem in feisty.

Now, you can patch and build for feisty, and upload both binaries or just patch the feisty source and upload it to gutsy (the latter is what my patch is supposedly doing).

Or you can patch the compilation bug and make the gutsy source compilable in gutsy.

Thanks.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Just in case, since the compilation problem is caused by the linux library wireless.h header file, if a new version of it fixes it here is the patch to add the .desktop file.
Of course this is only valid for the current rt2500 source package (rt2500_1.1.0-b4-3).

Revision history for this message
Emmet Hikory (persia) wrote :

Thank you very much. I'm not permitted to upload things that I know won't compile, but I'll keep this on my watch list, and try again for the next version of the kernel libraries. Separately, the addition of a .desktop file is not considered sufficient requirement for upload in a released distribution, so this will only be released in gutsy.

Changed in rt2500:
status: Needs Info → Confirmed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Andy Price raised the failed compiling as a bug.
See bug #120301 for details.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Thanks to Andy Price suggestion this now compiles.
All occurrrences of linux/wireless.h are now changed to iwlib.h

rt2500 (1:1.1.0-b4-3ubuntu1) gutsy; urgency=low

  * Add .desktop file (LP: #113054)
  * Change Maintainer field
  * Fix failed compilation (LP: 120301) Thanks to Andrew Price

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

I'm glad to be able to include in the patch a fix for the compilation of the rt2500 module too.

Changed in rt2500:
assignee: norsetto → nobody
Revision history for this message
Daniel Holbach (dholbach) wrote :

Said to be a workaround to bug 118205.

Changed in rt2500:
importance: Wishlist → Medium
Emmet Hikory (persia)
Changed in rt2500:
assignee: nobody → persia
status: Confirmed → In Progress
Revision history for this message
Emmet Hikory (persia) wrote :

Thank you for chasing this. Uploaded.

Changed in rt2500:
status: In Progress → Fix Committed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

rt2500 (1:1.1.0-b4-3ubuntu1) gutsy; urgency=low

  * Add .desktop file (LP: #113054)
  * Change Maintainer field
  * Fix failed compilation (LP: #120301) Thanks to Andrew Price
  * Fix rt2500 module compilation

 -- Cesare Tirabassi <email address hidden> Mon, 7 May 2007 14:19:35 +0200

Changed in rt2500:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.