[6.1]openerp-cron-worker crash

Bug #1182778 reported by David Lefever @ Taktik
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Medium
OpenERP Publisher's Warranty Team

Bug Description

I noticed a bug when launching the openerp-cron-worker.
After the first execution, it raises an exception :

Traceback (most recent call last):
  File "/usr/local/openerp/openobject-server/openerp-cron-worker", line 109, in <module>
    openerp.addons.base.ir.ir_cron.ir_cron._run(db_names)
  File "/usr/local/openerp/openobject-server/openerp/addons/base/ir/ir_cron.py", line 412, in _run
    openerp.wsgi.core.post_request(worker, 'dummy', 'dummy')
TypeError: post_request() takes exactly 2 arguments (3 given)

Indeed, the post_request method from wsgi.core takes only 3 arguments, but the ir_cron.py calls with 3 arguments.

Edit : after checking the code, it seems that it executes the faulty code only when the cpu time limit parameter is not 60, for instance when launching the openerp-cron-worker with --cpu-time-limit 300.

Tags: maintenance
Revision history for this message
Twinkle Christian(OpenERP) (tch-openerp) wrote :

Hello David,

I have checked your issue. But its working fine with this. I am not facing any kind of error with this. I have tried it with 4 workers, and I did the same which you had given in you bug description. but its working fine.

So, would you please check it again with and correct me I did any wrong.

Thanks & waiting for your answer.

Changed in openobject-server:
status: New → Incomplete
Revision history for this message
David Lefever @ Taktik (dl-taktik) wrote :

Hello,

after checking the code, it seems that it executes the faulty code only when the cpu time limit parameter is not 60.
Can you try to launch the openerp-cron-worker with --cpu-time-limit 300 for instance?

description: updated
Revision history for this message
Twinkle Christian(OpenERP) (tch-openerp) wrote :

Hello David,

Currently, This issue is only in V6.1. Also the same thing working fine with the trunk as well as V7.0 (last version issue). Also this is not a blocking point.

So, if support and maintenance contract. Then you can contact our OPW team at <email address hidden>. They will definitely helps .

I hope now you can understand :)

Thank you.

Changed in openobject-server:
status: Incomplete → Won't Fix
summary: - openerp-cron-worker crash
+ [6.1]openerp-cron-worker crash
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Dears,

This will be a wrong decision if we don't go for the fix.

This is Really a blocking point and Should go fixed even there was no OPW, or a bug reported.

Imagine I cannot use the cpu timeout more than 60 as a limit!

The fix is quite obvious and 100% risk-free.

For a better reference, kindly take a look at the commit which introduced this bug, but was hidden under the carpet.
http://bazaar.launchpad.net/~openerp/openobject-server/6.1/revision/4127.1.7

Lets thank David Lefever for noticing this and bringing this up.

Thank you for understanding.

Regards,
Serpent Consulting Services.

Revision history for this message
Fabrice (OpenERP) (fhe) wrote :

Dear Serpent Consulting Services,
I would be very interested to hear your suggestion for this new business model that requires OpenERP SA to fix bugs of past versions for free. Make sure to write it down, publish it, and go collect your Nobel Prize in economy.

No OpenERP Enterprise = No bugfix
If you want everything for free, deal with the consequences.

Revision history for this message
Cristian Salamea (ovnicraft) wrote :

@Fabrice, first of all what you answering here is not technical and you are kidding us with you text.

So why do you did test it before release it ? so i can understand you wont fix it if nobody pays you but here a tech question:

Tests in OpenERP are for dummies or for Enterprise (take the word from OpenERP Enterprise Warranty) ?
There is any spec wrote before for developers to know future risks ?

You must know this is caused by you, OpenERP SA wrote the code and explict wrote 60 (in code as limit) and you are doing a bad use of your libraries (post_request accepts diff args what you pass).

As you says "If you want everything for free, deal with the consequences.", i am agree with you but each OSS project in the world has a good documentation or spec to read or improve and everybody can manage future risks in software.

You clearly lets us know hear everything about here is the business model not quality for this great project, BTW we can fix it.

Best regards, (least one)

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Fabrice,

You took wrong way, my thought was very positive. Nothing in against to any policy.

I simply meant to correct the answer given in previous comment that its not blocking.

Hope you understand.

Thanks.

Revision history for this message
Cristian Salamea (ovnicraft) wrote :

@Serpent so revno what introduce the bug need fix it or MP fix it ?

Regards,

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :
Revision history for this message
Mario Arias (the-clone-master) wrote :

Serpent CS, my friend... please add this to OCB branches...

Bugs and bug fixes are welcomed there !!

I really don't know what will it be of "official" branches if OpenERP S.A. keeps pushing away people from collaborating...

Way to go, OpenERP S.A. !!!

-Mario

Revision history for this message
David Lefever @ Taktik (dl-taktik) wrote :

Hello,

thank you for your help and support.

Concerning the answer from OpenERP, I can understand the position, but not the manner.
I hate to say this, but as a Gold partner that's not the way we expect to be helped.
The comment was off-topic and childish.

Anyway, I sent a request to the support, with an OPW, so that other people not aware of OCB branches will not have the problem.

Thanks again,

David.

Changed in openobject-server:
assignee: nobody → OpenERP Publisher's Warranty Team (openerp-opw)
status: Won't Fix → New
tags: added: maintenance
Changed in openobject-server:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hi All,

The fix has landed on stable 6.1 at 4351 <email address hidden>

Regards,
Naresh Soni,
OpenERP Enterprise Services

Changed in openobject-server:
status: Confirmed → Fix Released
Revision history for this message
Anaël Closson (openerp) (acl-openerp) wrote :

First of all, thank you for reporting this bug and the attached fix.

The problem spotted here is that we currently don't have the resource needed to handle non OPW bugs. That's why we focus on OPW bug solving as it's thanks to those contracts that OpenERP can stay alive.

Though, we're trying to stay aware of really problematic bugs reported for stable, and if there is a real need for a fix to be merged into stable, we are not opposed to review and merge it.

But as you're OPW allowed it's better to report bugs on the OPW mailing list as we can't assure it will be fixed if it's on launchpad.

Kind regards,

Anaël

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Thanks You all!

This is a real teamwork!

Have a good going.

Changed in openobject-server:
milestone: none → 7.0
Changed in openobject-server:
milestone: 7.0 → 6.1
Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Ah Sorry Naresh for bad choice!
Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.