dm-multipath not autoloaded causes multipath to fail

Fixed in gutsy... fehhh LP is confusing :)

That looks weird. You attempt a modprobe on each and every block device addition/change? That's going to be a lot, and is certainly unnecessary.

Why not just add/remove it from /etc/modules in postinst/prerm?

Approved after discussion in #ubuntu-devel.

<Keybuk> pitti: *shrug* we attempt a modprobe on each and every device change, pretty much <g>

Package uploaded in feisty-proposed.

Fabio

Accepted into feisty-proposed, please go ahead with QA testing.

multipath-tools (0.4.7-1.1ubuntu3.1) feisty-proposed; urgency=low

  * Fix udev rule to modprobe dm-multipath.

  (Closes LP: #120177)

 -- <email address hidden> (Fabio M. Di Nitto) Wed, 13 Jun 2007 12:26:24 +0200

It's just in proposed, not yet in -updates.

Please add detailled instructions how to reproduce the bug. These should allow someone who is not familiar with the affected package to reproduce the bug and verify that the updated package fixes the problem.

Thanks,
 Michael

I did a sru verfication based on the above instructions.

I installed multipath-tools on a fesh feisty install. The package installed and ps ax|grep multipathd showed no daemon runing. I can installed the package from feisty-proposed. The installation failed with the following error:

[..]
Preparing to replace multipath-tools 0.4.7-1.1ubuntu3 (using .../multipath-tools_0.4.7-1.1ubuntu3.1_i386.deb) ...
Stopping multipath daemoninvoke-rc.d: initscript multipath-tools, action "stop" failed.
dpkg: warning - old pre-removal script returned error exit status 1
dpkg - trying script from the new package instead ...
Stopping multipath daemoninvoke-rc.d: initscript multipath-tools, action "stop" failed.
dpkg: error processing /var/cache/apt/archives/multipath-tools_0.4.7-1.1ubuntu3.1_i386.deb (--unpack):
 subprocess new pre-removal script returned error exit status 1
Starting multipath daemon.
Errors were encountered while processing:
 /var/cache/apt/archives/multipath-tools_0.4.7-1.1ubuntu3.1_i386.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)
egon@egon-desktop:~$

I think we need to fix this issue before this can go into -updates.

I can confirm that when no prior multipath-tools package is installed the version from feisty-proposed works as expected.

New debdiff (feisty -> feisty-proposed) in attachment that addresses all the corner cases spotted by Michael.

Also uploaded to feisty-proposed pending review/approval.

Fabio

Fabio,

shouldn't you use lt-nl instead of lt? Otherwise you'll run the special case instead of #DEBHELPER# on a fresh installation.

Accepted into feisty-proposed, please test.

multipath-tools (0.4.7-1.1ubuntu3.2) feisty-proposed; urgency=low

  * Fix preinst script to modprobe dm-multipath. This will make sure
    that multipathd will be able to start.

  * Fix init script not to die on stop if multipathd is not running.

  * Add prerm script to not fail when upgrading from a broken version of
    multipathd.

  (Closes LP: #120177)

 -- <email address hidden> (Fabio M. Di Nitto) Fri, 10 Aug 2007 13:03:39 +0200

Martin,

just for the record (as we discussed on IRC) the lt-nl is pointless because on fresh install prerm is not executed. Even if it was executed, the special case would do the rigth thing by checking if the init script is there and executable (it's not) and that the daemon is not running so the stop action will fail properly.

Fabio

Packages from -proposed were also tested at the time.

Fabio

Copied to feisty-updates. Thanks!

Please note that now the package will fail to install on (hardy) when the dm-multipath module is not available, for example on a monolithing kernel.