Launchpad itself

ftpmaster-tools code reoganization

Bug #121784 reported by Celso Providelo
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Celso Providelo

Bug Description

Soyuz ftpmaster-tools needs code reorganization:

 * some code is still leaving in the *wrong* place (scripts/ftpmaster-tools/), they should be encapsulated and moved to launchpad/scripts/
 * some code doesn't follow LP standards (style problems and obsolete variable names)
 * RF copies are obsolete (sync-source.py, for instance, also we have to incorporate backport-source.py mentioned in bug 66836
 * we lack proper tests for them (some already have end2end slow doctests, which should be refactored.)

this task is related with bug 75621.

Revision history for this message
Celso Providelo (cprov) wrote :

proposing to 1.1.7

Changed in soyuz:
assignee: nobody → cprov
status: New → Confirmed
Revision history for this message
Colin Watson (cjwatson) wrote :

You may want to clean this diff up a bit; I disabled the auto-remove features of both archive-cruft-check variants with a fairly large hammer.

Celso Providelo (cprov)
Changed in soyuz:
importance: Undecided → High
status: Confirmed → In Progress
Revision history for this message
Celso Providelo (cprov) wrote :

The renaming issues will be addressed and the other bits related to ftpmaster-tools will be controlled with a new bug-tag:

https://launchpad.net/soyuz/+bugs?field.tag=soyuz-ftpmaster-tools

That was agreed with reviewers and it's the best we can do for 1.1.7.

Revision history for this message
Celso Providelo (cprov) wrote :

RF 4519

Changed in soyuz:
status: In Progress → Fix Committed
Celso Providelo (cprov)
Changed in soyuz:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.