runstat has a carry bug

Bug #1218129 reported by Andrew Pollock
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cronutils (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned
Quantal
Won't Fix
Undecided
Unassigned
Raring
Won't Fix
Undecided
Unassigned
Saucy
Fix Released
Undecided
Unassigned

Bug Description

runstat has a carry bug where it will sometimes report the elapsed time as something like 10.-814381950

It was fixed upstream in https://code.google.com/p/cronutils/source/detail?r=30a2aa9e7755ca0bb43889d4b796b00be5da27f5 and the fix is in Debian unstable in version 1.5-1

Revision history for this message
Andrew Pollock (apollock) wrote :

It's been some time since I've prepared an SRU, so please be gentle.

[Impact]

 * runstats produces output that is not a valid number (e.g. 10.-814381950) when the nanosecond of the start time is less than the nanosecond of the end time.

 * Justification: Allow runstats to provide correctly formatted output

 * This upload fixes the bug by backporting the fix from upstream. (The fix simply handles the case where the value is negative)

[Test Case]

 * Due to the precise timing issues that trigger this bug, it is difficult to come up with a trivial test case to reproduce the bug.

[Regression Potential]

 * I do not see any potential for regression based on the patch applied.

tags: added: patch
Revision history for this message
Scott Kitterman (kitterman) wrote :

Fixed in saucy as it has 1.5.

Changed in cronutils (Ubuntu Saucy):
status: New → Fix Released
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the debdiff. ACK.

I've uploaded it to precise for processing by the SRU team.

Thanks!

Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted cronutils into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/cronutils/1.1-3ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in cronutils (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Andrew Pollock (apollock) wrote :

I've actually found a pretty good way to reproduce the bug:

runstat sleep 0.9; cat /tmp/cronutils-$LOGNAME/sleep.stat | grep elapsed
sleep,elapsed_time,1.-098452563,s

seems to be doing it very reliably, so now I have a good verification for the proposed update fixing it.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Andrew Pollock (apollock) wrote :

Yes, this looks good with the new version:

$ dpkg-query -W cronutils
cronutils 1.1-3ubuntu1

$ runstat sleep 0.9; cat /tmp/cronutils-$LOGNAME/sleep.stat | grep elapsed
sleep,elapsed_time,0.901556495,s

Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cronutils - 1.1-3ubuntu1

---------------
cronutils (1.1-3ubuntu1) precise; urgency=low

  * Backport fix from upstream for carry bug (LP: #1218129)
 -- Andrew Pollock <email address hidden> Thu, 29 Aug 2013 10:53:49 +1000

Changed in cronutils (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".

Changed in cronutils (Ubuntu Quantal):
status: New → Won't Fix
Revision history for this message
Rolf Leggewie (r0lf) wrote :

raring has seen the end of its life and is no longer receiving any updates. Marking the raring task for this ticket as "Won't Fix".

Changed in cronutils (Ubuntu Raring):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.