click hook tries to use ${id} in Exec

Bug #1220591 reported by Colin Watson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Application Launcher
Fix Released
Undecided
Unassigned
upstart-app-launch (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

upstart-app-launch's click hook tries to use the app ID in Exec, passing it as ${id}. However, ${id} is not substituted in Exec.

As it turns out, desktop-hook doesn't actually use this; indeed it exits with an error if it's passed any arguments. You get away with this because Exec is passed through the shell and the shell expands ${id} to the empty string; but you shouldn't rely on this.

=== modified file 'upstart-app-launch-desktop.click-hook.in'
--- upstart-app-launch-desktop.click-hook.in 2013-08-07 01:55:31 +0000
+++ upstart-app-launch-desktop.click-hook.in 2013-09-04 08:52:33 +0000
@@ -1,4 +1,4 @@
 Pattern: ${home}/.cache/upstart-app-launch/desktop/${id}.desktop
-Exec: @pkglibexecdir@/desktop-hook ${id}
+Exec: @pkglibexecdir@/desktop-hook
 User-Level: yes
 Hook-Name: desktop

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package upstart-app-launch - 0.3+14.04.20140213-0ubuntu1

---------------
upstart-app-launch (0.3+14.04.20140213-0ubuntu1) trusty; urgency=low

  [ Ted Gould ]
  * Unregister for Unity's Resume signal
  * Function to get the log file for the application
  * Add GIR support to libual
  * Remove an invalid substitution that we weren't using (LP: #1220591)
 -- Ubuntu daily release <email address hidden> Thu, 13 Feb 2014 13:14:51 +0000

Changed in upstart-app-launch (Ubuntu):
status: New → Fix Released
Ted Gould (ted)
Changed in upstart-app-launch:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.