Having "pkgdir" in the manifest info would be useful
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| click (Ubuntu) |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
The touch system-settings need to list the installed clicks with their icons [1]
To do that we call "click list --manifest". The manifest gives us an icon path relative to the package directory though, which means that we need to call "click pkgdir <name>" for each entry.
That works fine, but the command takes some ~0.1s (on a i5 laptop with ssd drive), which leads to quite some latency in the UI if you have a non trivial number of packages installed.
We can make the system-settings code async, and display icons progressively, but that would mean more complex code, and UI flackering (icons would be first a placeholder and replaced by the real ones as the info come). It would be handy if the manifest was including the pkgdir since it would remove most of the overhead we have...
Related branches
- Colin Watson: Approve
- Ubuntu CI managed package branches: Pending requested
-
Diff: 485 lines (+269/-70)11 files modifiedREADME (+1/-0)
click/build.py (+10/-22)
click/framework.py (+138/-0)
click/install.py (+8/-28)
click/paths.py.in (+1/-0)
click/tests/helpers.py (+29/-0)
click/tests/test_build.py (+39/-5)
click/tests/test_install.py (+2/-4)
debian/changelog (+8/-0)
doc/file-format.rst (+1/-2)
doc/index.rst (+32/-9)
| Changed in click (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in click (Ubuntu): | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Colin Watson (cjwatson) |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in click (Ubuntu): | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package click - 0.4.4
---------------
click (0.4.4) saucy; urgency=low
* Amend "click help install" to recommend using "pkcon install-local".
* Run hooks when removing a per-user package registration.
* Adjust usage lines for "click help verify" and "click help pkgdir" to
indicate that options are allowed.
* Add a click(1) manual page.
* Use json.dump and json.load in most places rather than json.dumps and
json.loads (which unnecessarily construct strings).
* Add "click unregister", which unregisters a package for a user and
removes it from disk if it is not being used.
* Add RemovePackage support to the PackageKit plugin, mapped to "click
unregister".
* Attempt to remove the old version of a package after installing or
registering a new one.
* Remove code supporting PackageKit 0.7 API, and instead arrange to
disable the PackageKit plugin if the new API is not available, since we
don't need to build it on Ubuntu 12.04 LTS.
* Report errors from click subprocesses in PackageKit plugin
(LP: #1218483).
* Implement PackageKit search by name and by details.
* Reserve manifest keys starting with an underscore for use as dynamic
properties of installed packages.
* Add the dynamic key "_directory" to "click list --manifest" output,
showing the directory where each package is unpacked (LP: #1221760).
* Add the dynamic key "_removable" to "click list --manifest" output,
which is 1 if a package is unpacked in a location from which it can be
removed, otherwise 0.
-- Colin Watson <email address hidden> Mon, 09 Sep 2013 13:37:39 +0100