fails to load UTF-8 manifests when not in a UTF-8 locale
Bug #1245677 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| click-apparmor (Ubuntu) |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
PackageKit runs its plugins with a very limited environment, which in particular does not include any locale keys. aa-clickhook does not force any particular encoding when opening manifest files, which means that Python assumes the system encoding (ASCII in this situation). This fails when, for example, the package maintainer's name contains non-ASCII characters.
Related branches
lp:~cjwatson/click-apparmor/unicode-manifest
- Ubuntu Security Team: Pending requested
-
Diff: 111 lines (+21/-12)3 files modifiedapparmor/click.py (+2/-2)
debian/changelog (+6/-0)
test-clicktool.py (+13/-10)
| Changed in click-apparmor (Ubuntu): | |
| status: | New → Fix Committed |
| importance: | Undecided → High |
| Changed in click-apparmor (Ubuntu): | |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #1 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in click-apparmor (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I finally finished the CI tests for click-apparmor which use pkcon. The tests are setup to run automatically now too. Added a test specifically for this bug since it was difficult to test the failure condition in unittest. Landing ask added-- just waiting on the landing team for upload.