Mahara

Feedback form should use focus management

Bug #1259764 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 1.9.0

Bug Description

When placing feedback on a page, the feedback form appears without reloading the page. For screen reader users this can be confusing, so the 'Message' text box should be explicitly focused when the "Place feedback" link is activated.

Related: If feedback is a block on the page, the feedback form is still added to the footer (rather than to the block). Adding it after the "Place feedback" link would make the page order more logical to screen reader users.

Affects latest master (using Orca 3.4.2)

See original description
Jono M (jonom)
Changed in mahara:
importance: Undecided → Medium
Jono M (jonom)
description: updated
Jono M (jonom)
Changed in mahara:
assignee: nobody → Jono Mingard (mingard)
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/2890

Jono M (jonom)
Changed in mahara:
milestone: none → 1.9.0
Revision history for this message
Steven (stevens-q) wrote :

==== Bug #1259764 Feedback form should use focus management ====

please check that everything still works when looking at it as sighted person

==== Test Plan ====
1. log in as an authenticated user
2. browse to any portfolio page
3. scroll to the bottom of the page and click the place feedback link
4. confirm that a field opens to allow a user to place feedback
5. confirm that a user can also add multiple files as part of the feedback
6. confirm that there are buttons to place feedback and to cancel

==== Test Results ====
4. confirm that a field opens to allow a user to place feedback ✔
5. confirm that a user can also add multiple files as part of the feedback ✔
6. confirm that there are buttons to place feedback and to cancel ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2890
Committed: http://gitorious.org/mahara/mahara/commit/65e0743218cf3d53a11b4d90d7698636abfb7dc3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 65e0743218cf3d53a11b4d90d7698636abfb7dc3
Author: Jono Mingard <email address hidden>
Date: Wed Jan 8 14:24:19 2014 +1300

Use focus management in Feedback form (Bug #1259764)

"Place feedback" button should now focus the Message input of the Feedback
form. Also, if the Feedback block is used on a page, the feedback form is
moved so that it's under the "Place feedback" button in the HTML - this
means that the document stays in a logical order for screen reader users.

Change-Id: Ieeb71bc7b25e48b7b69683173c01cf1659e4144d
Signed-off-by: Jono Mingard <email address hidden>

Jono M (jonom)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.