Ubuntu
ubuntu-system-settings package

battery indicator and brightness settings should have brightness slider; battery settings shouldn't

Bug #1289470 reported by Matthew Paul Thomas
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
indicator-power (Ubuntu)
Fix Released
High
Charles Kerr
ubuntu-system-settings (Ubuntu)
Fix Released
Medium
Ken VanDine

Bug Description

The current phone design has three brightness sliders that do exactly the same thing:
* System Settings > "Brightness"
* System Settings > "Battery"
* the Battery menu.

This is kind of ridiculous. We should get rid of one or two.

<https://wiki.ubuntu.com/Power#Settings>: "'Display brightness' should navigate to a mirror of the 'Brightness' screen."

<https://wiki.ubuntu.com/Power#menu-mobile>: "The brightness slider should exactly mirror the one in the Brightness settings panel."

See original description

Related branches

lp:~laney/indicator-power/phone-no-slider
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 87 lines (+11/-26)
3 files modified
debian/control (+1/-1)
debian/rules (+9/-0)
src/service.c (+1/-25)
lp:ubuntu/utopic-proposed/indicator-power
lp:~ken-vandine/ubuntu-system-settings/brightness_slider
PS Jenkins bot: Approve (continuous-integration)
Sebastien Bacher (community): Approve
Diff: 176 lines (+38/-105)
3 files modified
plugins/brightness/BrightnessSlider.qml (+0/-103)
plugins/brightness/CMakeLists.txt (+0/-1)
plugins/brightness/PageComponent.qml (+38/-1)
lp:ubuntu/utopic-proposed/ubuntu-system-settings
lp:~charlesk/indicator-power/lp-1289470-restore-brightness-slider
Ted Gould (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 1499 lines (+763/-561)
9 files modified
src/CMakeLists.txt (+1/-2)
src/brightness.c (+509/-0)
src/brightness.h (+67/-0)
src/ib-brightness-control.c (+0/-156)
src/ib-brightness-control.h (+0/-33)
src/ib-brightness-uscreen-control.c (+0/-202)
src/ib-brightness-uscreen-control.h (+0/-43)
src/service.c (+109/-96)
tests/manual (+77/-29)
Matthew Paul Thomas (mpt)
Changed in indicator-power (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/Power#Phone_and_tablet> As agreed with Shruti Kapur, the battery menu should no longer contain a brightness slider.

It's possible that a brightness slider may return in a future indicator design, and in that case we'd have to tackle the System Settings side.

Changed in indicator-power (Ubuntu):
status: New → In Progress
importance: Undecided → Low
assignee: Matthew Paul Thomas (mpt) → nobody
status: In Progress → Triaged
Iain Lane (laney)
Changed in indicator-power (Ubuntu):
assignee: nobody → Iain Lane (laney)
Revision history for this message
Charles Kerr (charlesk) wrote :

mpt, do you want to leave both brightness sliders in u-s-s as well?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-power - 12.10.6+14.10.20140611-0ubuntu1

---------------
indicator-power (12.10.6+14.10.20140611-0ubuntu1) utopic; urgency=low

  [ Charles Kerr ]
  * Prefer the 'battery-XXX-charging' (eg, 'battery-020-charging') icons
    over the 'battery-low-charging' ones because the former are more
    precise and likely closer to the actual battery level. (LP:
    #1186181)

  [ Iain Lane ]
  * Remove the brightness slider from the phone menu. (LP: #1289470)
 -- Ubuntu daily release <email address hidden> Wed, 11 Jun 2014 17:21:30 +0000

Changed in indicator-power (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Seb has persuaded me that the indicator slider is the wrong one to get rid of.

Instead let's replace the slider in the "Battery" panel with a page stack item that navigates to the Brightness panel. That way, starting from the Battery panel, you can still change the brightness, but there'll be only two sliders overall.

Changed in indicator-power (Ubuntu):
assignee: Iain Lane (laney) → Matthew Paul Thomas (mpt)
status: Fix Released → Confirmed
importance: Low → High
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → High
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Specification updated. <https://wiki.ubuntu.com/Power?action=diff&rev2=67&rev1=66>

Changed in ubuntu-system-settings (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → nobody
status: New → Triaged
importance: High → Medium
Changed in indicator-power (Ubuntu):
importance: High → Medium
status: Confirmed → Triaged
assignee: Matthew Paul Thomas (mpt) → nobody
description: updated
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

assign to charles to restore the slide in the indicator

Changed in indicator-power (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
Ken VanDine (ken-vandine)
Changed in ubuntu-system-settings (Ubuntu):
assignee: Jonas G. Drange (jonas-drange) → Ken VanDine (ken-vandine)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+14.10.20140812.3-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140812.3-0ubuntu1) utopic; urgency=low

  [ Ken VanDine ]
  * [battery] Updated based on latest designs, switching from brightness
    slider to progression which loads the brightness plugin.
    [brightness] Moved BrightnessSlider component to brightness plugin,
    since it's now only used in one place. (LP: #1289470)

  [ Sebastien Bacher ]
  * system-update: tweaks to the "no update available" label (LP:
    #1348568)

  [ William Hua ]
  * Use gsettings-qt in language panel.
  * Add auto-punctuation and keyboard vibration options. Also fix auto-
    completion to be auto-correction per spec. (LP: #1352398)

  [ Michael Terry ]
  * Implement a lock security page in the wizard. This page is super
    ugly right now and just the bare bones functionality needed to set a
    passcode or otherwise. Design is working on final visual design and
    we will update later. (LP: #1348362)

  [ jonas-drange ]
  * [cellular] uis for default SIM settings
  * [cellular] use expandable to show/hide sim editor and put the sim
    editor in a Loader element to optimize single sim setups
 -- Ubuntu daily release <email address hidden> Tue, 12 Aug 2014 19:23:51 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Charles I'd say we need this for rtm

Changed in indicator-power (Ubuntu):
importance: Medium → High
tags: added: rtm14
Charles Kerr (charlesk)
Changed in indicator-power (Ubuntu):
status: Triaged → In Progress
tags: added: touch-2014-09-25
Revision history for this message
Charles Kerr (charlesk) wrote :

I've rephrased the bug title to reflect mpt's summary in comment #4 and to clarify what the TODO item is for indicator-power.

summary: - The phone has three brightness sliders
+ battery indicator and brightness settings should have brightness slider;
+ battery settings shouldn't
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-power - 12.10.6+14.10.20140912-0ubuntu1

---------------
indicator-power (12.10.6+14.10.20140912-0ubuntu1) utopic; urgency=low

  [ Charles Kerr ]
  * Restore the the brightness slider and have the brightness setting
    persist between reboots. (LP: #1289470)
 -- Ubuntu daily release <email address hidden> Fri, 12 Sep 2014 18:49:45 +0000

Changed in indicator-power (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.