Let tree descriptions use the same size scheme as buildings

Bug #1289586 reported by Hans Joachim Desserud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

The different worlds each have a conf-file which lists the different immovable types which may be placed. Among these are the trees, for instance:
tree4_m=_Maple (medium)
tree4_s=_Maple (small)
tree4_t=_Maple (tiny)

I've always found these sizes a bit odd since medium is usually the middle value and there is no large/big/huge/etc trees. Is there a reason why this scheme was chosen? I wonder if it would be better to reuse the small/medium/large scheme which is already in place for buildings and would be instantly recognizable.

I have noticed this a long time ago, but I haven't filed it before now because it is a minor issue and it would require to redo lots of translations for trees in all languages. However, we have recently done some major changes to translations which basically require to re-add a lot of translations, so this might be an opportunity to change this. ;)

Related branches

Revision history for this message
SirVer (sirver) wrote :

well, using the same description would be confusing as well. From an engine point of view, all trees are either of immovable size none (i.e. can be destroyed by placing a flag) or small (i.e. the size of a flag or a small building). The tree descriptions could be changed to young, older, old or so, but I think it is probably not worth the effort.

+1 for won't fix. But I think gunchleoc should speak on this as it is a language issue.

@gun: feel free to unassign after you said your opinion. I realized I did not mention this before, but getting a bug assigned is like pinging here. It does not mean you need to fix it - if you do not plan it, unassign yourself :)

Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
status: New → Incomplete
Revision history for this message
GunChleoc (gunchleoc) wrote :

Well, since we already broke tons of stuff anyway, I won't mind changing this, and it has been bugging me a bit as well.

So, +1 for changing these.

How about:

sapling
young
mature

I take it that trees are only ready to be cut down in the third stage?

Revision history for this message
GunChleoc (gunchleoc) wrote :

OK, I did some digging. The system works like this:

tree4_t=_Maple (tiny) gets seeded, grows into
tree4_s=_Maple (small), which grows into
tree4_m=_Maple (medium), which can also seed tree4_t and grows into
tree4=_Maple, which has a falling animation and can also seed tree4_t.

http://www.gardenplansireland.com/forum/about163.html

> The life cycles of trees, especially conifers, are divided into the
> following stages in forestry for survey and documentation purposes,
> though the boundaries between stages vary among gardeners and foresters:
>
> 1. Seed
> 2. Seedling: the above-ground part of the embryo that sprouts from the seed
> 3. Sapling: After the seedling reaches 1 m tall, and until it reaches 7 cm in stem diameter
> 4. Pole: young trees from 7-30 cm diameter
> 5. Mature tree: over 30 cm diameter, reproductive years begin
> 6. Old tree: dominate old growth forest; height growth slows greatly, with majority of productivity in seed production
> 7. Overmature: dieback and decay become common
> 8. Snag: standing dead wood
> 9. Log/debris: fallen dead wood

So, I think we should use these stages:
tree4_t = 3. Sapling
tree4_s = 4. Pole
tree4_m = 5. Mature tree
tree4 = 6. Old tree

Changed in widelands:
status: Incomplete → In Progress
GunChleoc (gunchleoc)
tags: added: internationalization
Revision history for this message
SirVer (sirver) wrote :

I like the suggested changes. But please do not do them right now. I will give a merge nightmare when I bring the one_world branch in (still a few weeks off). Can this be postponed for a while?

Revision history for this message
SirVer (sirver) wrote :

nevermind, the change was much smaller than I anticipated (I thought we need to touch all conf files).

Changed in widelands:
status: In Progress → Fix Committed
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.