Sorting maps by name sort by original instead of translated name
Bug #1289698 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
When selecting a map for starting a new game, sorting the maps by name does not work with localized map names: The result is in the wrong oder.
Related branches
lp:~widelands-dev/widelands/i18nfixes
- SirVer: Approve
- TiborB: Approve
-
Diff: 7107 lines (+2206/-3249)96 files modifiedcampaigns/atl01.wmf/elemental (+1/-1)
campaigns/cconfig (+12/-9)
campaigns/dummy.wmf/elemental (+2/-1)
campaigns/emp01.wmf/elemental (+1/-1)
campaigns/emp02.wmf/elemental (+1/-1)
campaigns/t01.wmf/elemental (+1/-1)
campaigns/t02.wmf/elemental (+1/-1)
campaigns/t03.wmf/elemental (+2/-2)
campaigns/tutorial01.wmf/elemental (+1/-1)
maps/Atoll.wmf/elemental (+5/-1)
maps/Calvisson.wmf/elemental (+20/-1)
maps/Crossing the horizon.wmf/elemental (+0/-2)
maps/Desert Tournament.wmf/elemental (+5/-1)
maps/Elven Forests.wmf/elemental (+10/-1)
maps/Four Castles.wmf/elemental (+5/-1)
maps/Four Mountains.wmf/elemental (+10/-1)
maps/Long, long way.wmf/elemental (+25/-1)
maps/MP Scenarios/Smugglers.wmf/elemental (+7/-2)
maps/Plateau.wmf/elemental (+4/-1)
maps/Rendez-Vous.wmf/elemental (+0/-1)
maps/Swamp Monks.wmf/elemental (+5/-1)
maps/The Nile.wmf/elemental (+30/-1)
maps/Trident of Fire.wmf/elemental (+20/-0)
po/mp_scenario_together_we_re_strong.wmf/ar.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/ca.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/cs.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/de.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/en_GB.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/eo.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/es.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/eu.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/fi.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/fr.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/gd.po (+0/-47)
po/mp_scenario_together_we_re_strong.wmf/hr.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/hu.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/it.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/ja.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/la.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/lt.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/mp_scenario_together_we_re_strong.wmf.pot (+0/-46)
po/mp_scenario_together_we_re_strong.wmf/nb.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/nl.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/oc.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/pl.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/pt.po (+0/-74)
po/mp_scenario_together_we_re_strong.wmf/pt_BR.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/ru.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/sk.po (+0/-43)
po/mp_scenario_together_we_re_strong.wmf/sv.po (+0/-45)
po/mp_scenario_together_we_re_strong.wmf/tr.po (+0/-44)
po/mp_scenario_together_we_re_strong.wmf/zh_TW.po (+0/-43)
src/ai/defaultai.cc (+2/-3)
src/base/i18n.cc (+11/-4)
src/base/i18n.h (+1/-1)
src/base/time_string.cc (+59/-32)
src/base/time_string.h (+1/-4)
src/editor/tools/editor_info_tool.cc (+2/-2)
src/editor/ui_menus/editor_main_menu_load_map.cc (+3/-2)
src/editor/ui_menus/editor_main_menu_map_options.cc (+4/-4)
src/editor/ui_menus/editor_main_menu_save_map.cc (+2/-2)
src/game_io/game_preload_packet.cc (+2/-14)
src/game_io/game_preload_packet.h (+2/-10)
src/logic/game.cc (+1/-0)
src/logic/map.cc (+36/-35)
src/logic/map.h (+28/-20)
src/map_io/map_elemental_packet.cc (+44/-1)
src/map_io/map_loader.h (+1/-1)
src/map_io/s2map.cc (+3/-3)
src/map_io/s2map.h (+1/-1)
src/network/nethost.cc (+12/-14)
src/scripting/lua_game.cc (+6/-6)
src/ui_basic/multilinetextarea.cc (+5/-0)
src/ui_basic/multilinetextarea.h (+1/-0)
src/ui_basic/table.cc (+1/-1)
src/ui_basic/table.h (+1/-1)
src/ui_fsmenu/CMakeLists.txt (+4/-4)
src/ui_fsmenu/campaign_select.cc (+305/-263)
src/ui_fsmenu/campaign_select.h (+71/-44)
src/ui_fsmenu/editor_mapselect.cc (+0/-264)
src/ui_fsmenu/editor_mapselect.h (+0/-62)
src/ui_fsmenu/launch_mpg.cc (+32/-16)
src/ui_fsmenu/launch_mpg.h (+9/-1)
src/ui_fsmenu/launch_spg.cc (+1/-1)
src/ui_fsmenu/load_map_or_game.cc (+98/-0)
src/ui_fsmenu/load_map_or_game.h (+120/-0)
src/ui_fsmenu/loadgame.cc (+424/-286)
src/ui_fsmenu/loadgame.h (+63/-41)
src/ui_fsmenu/loadreplay.cc (+0/-340)
src/ui_fsmenu/loadreplay.h (+0/-69)
src/ui_fsmenu/mapselect.cc (+416/-305)
src/ui_fsmenu/mapselect.h (+58/-39)
src/ui_fsmenu/suggested_teams_box.cc (+136/-0)
src/ui_fsmenu/suggested_teams_box.h (+60/-0)
src/wlapplication.cc (+10/-8)
src/wui/buildingwindow.cc (+2/-2)
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #1 |
| Changed in widelands: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| tags: | added: i18n internationalization ui |
Revision history for this message
| SirVer (sirver) wrote | #2 |
| Changed in widelands: | |
| status: | Confirmed → Incomplete |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #3 |
| Changed in widelands: | |
| status: | Incomplete → Confirmed |
| summary: |
- Sorting maps by name does not work + Sorting maps by name sort by original instead of translated name |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| status: | Confirmed → Fix Committed |
| status: | Fix Committed → In Progress |
| assignee: | nobody → GunChleoc (gunchleoc) |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| assignee: | GunChleoc (gunchleoc) → nobody |
| tags: | removed: i18n |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #4 |
To post a comment you must log in.
Yes, it seems to sort based on the original name.
(I was fairly sure I had reported this one before, but didn't find a report to mark this as a duplicate)