Result screen not shown in loaded game when a player was already defeated in saved game.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Steps to reproduce:
1) Start a game with the win condition autocrat and (at least) two other players.
2) Save the game, but continue playing.
3) Defeat one of the other players.
4) Save the game, but continue playing.
5) Defeat the last player. You will get a congratulation message and the result screen is shown.
6) Load the savegame from step 4 and defeat the last player. You get the congratulation message, but no result screen.
7) Load the savegame from step 2 and defeat both players. The result screen will be shown.
Conclusion:
Saving and loading the game works only fine before any of the players has been defeated. When some players have been defeated and the game is loaded, then the remaining players are defeated, the result screen is not shown.
Related branches
- Miroslav Remák: Approve (code)
- GunChleoc: Needs Resubmitting
- Klaus Halfmann: Approve (compile, test, code review)
-
Diff: 118 lines (+48/-6)3 files modifiedsrc/game_io/game_player_info_packet.cc (+31/-3)
src/logic/playersmanager.cc (+12/-3)
src/logic/playersmanager.h (+5/-0)
Changed in widelands: | |
status: | Incomplete → In Progress |
assignee: | cghislai (charlyghislain) → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
I attach the savegame from step 2 for easier repoduction. You just have to attack - the computerplayer has very few soldiers.