Ubuntu
dosfstools package

[precise] dosfsck is unable to repair FS

Bug #1322976 reported by Pali
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
dosfstools (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Medium
Unassigned

Bug Description

[Impact]

dosfsck is unable to repair FS and kernel show this warning:

FAT-fs (sdc1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.

This problem happends when 3.8+ kernel does not properly umount fat partion. For fixing this problem dosfstools v3.0.14+ is needed. See: https://lkml.org/lkml/2013/5/6/342

Because in precise is only version 3.0.12-1ubuntu1.1, it cannot repair these FS. So please update in precise dosfsck to at least version v3.0.14 which can properly fix fat32 partitions.

Upstream patch: http://daniel-baumann.ch/gitweb/?p=software/dosfstools.git;a=commitdiff;h=ce2f8dc349a8a6b2c26d1b3892cc9b5f0408bd34

[Test Case]

Mount some FAT partition in R/W mode and stop/crash kernel. Next time run fsck on that partition and dosfsck should properly clean dirty bit. Kernel should not show message "Volume was not properly unmounted".

[Regression Potential]

Low/None. Mentioned patch which fix this problem is already included in upstream dosfstools version.

See original description
Revision history for this message
Pali (pali) wrote :

This upstream patch fix this bug: http://daniel-baumann.ch/gitweb/?p=software/dosfstools.git;a=commitdiff;h=ce2f8dc349a8a6b2c26d1b3892cc9b5f0408bd34

tags: added: patch
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in 14.04 and later, only affects 12.04 (precise).

Changed in dosfstools (Ubuntu):
status: New → Fix Released
Changed in dosfstools (Ubuntu Precise):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Pali (pali) wrote :

Ping. Any news about fixing this bug? Patch is already available.

Revision history for this message
Pali (pali) wrote :

Its still not fixed so fsck for FAT32 partitions is broken for last ubuntu precise release!

description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

I uploaded a precise backport of that patch to the SRU review queue. Can you please prepare the bug for an SRU accordingly, in particular add a Test Case? See https://wiki.ubuntu.com/StableReleaseUpdates.

Thanks!

Changed in dosfstools (Ubuntu Precise):
status: Triaged → In Progress
Revision history for this message
Pali (pali) wrote :

I updated description.

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Pali, or anyone else affected,

Accepted dosfstools into precise-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dosfstools/3.0.12-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dosfstools (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Pali (pali) wrote :

Tested and new version automatically clean & fix FAT fs. No more error messages in kernel.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dosfstools - 3.0.12-1ubuntu1.2

---------------
dosfstools (3.0.12-1ubuntu1.2) precise; urgency=medium

  * Add git-check-dirty-bit.patch: Check boot sector for dirty bit, to allow
    dosfsck to repair partitions which didn't get unmounted properly.
    (LP: #1322976)
 -- Martin Pitt <email address hidden> Tue, 07 Apr 2015 12:19:39 +0200

Changed in dosfstools (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of the Stable Release Update for dosfstools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.