Build race between gtest/gmock and tests can cause build to fail
Bug #1362646 reported by
Alexandros Frantzis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alexandros Frantzis | ||
0.7 |
Fix Released
|
Medium
|
Alexandros Frantzis | ||
mir (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
mir (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Steps to reproduce:
1. make -j4
2. In build directory do "rm -rf gmock/"
3. make -j4
Expected result: Second build succeeds
Actual result: Second build fails with "make[2]: *** No rule to make target 'gmock/
The problem is that there is no explicit dependency between gmock/gtest and our tests. Linking with the gtest/gmock libraries is not enough, since GMock is an external CMake project, and CMake doesn't seem to track such cross-project dependencies.
Also seen in https:/
Related branches
lp:~afrantzis/mir/fix-1362646-gmock-build-dep
- Daniel van Vugt: Approve
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 80 lines (+15/-0)6 files modifiedtests/acceptance-tests/CMakeLists.txt (+3/-0)
tests/integration-tests/CMakeLists.txt (+2/-0)
tests/mir_test_doubles/CMakeLists.txt (+3/-0)
tests/mir_test_framework/CMakeLists.txt (+3/-0)
tests/performance-tests/CMakeLists.txt (+2/-0)
tests/unit-tests/CMakeLists.txt (+2/-0)
Changed in mir: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Alexandros Frantzis (afrantzis) |
milestone: | none → 0.8.0 |
Changed in mir: | |
milestone: | 0.8.0 → 0.7.0 |
Changed in mir: | |
milestone: | 0.7.0 → 0.8.0 |
Changed in mir: | |
milestone: | 0.8.0 → none |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir/devel at revision None, scheduled for release in mir, milestone Unknown