Title: Custom prefix/postfix to the generated click chroots
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| click (Ubuntu) |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
Testing the click chroot operations are the part of the Ubuntu SDK test plan.
According to the test plan we should be able to create, use and destroy click chroots on the host without conflicting with the already set up and used click croots. Also the tests should use clean click chroots as the existing chroots might be outdated or modified.
For that we need a CLICK_CHROOT_SUFFIX variable. The click tools should use that suffix for all click chroot operation.
For example when the CLICK_CHROOT_
$ click chroot -a armhf -f ubuntu-sdk-14.10 create
command should create /var/lib/
$ click chroot -a armhf -f ubuntu-sdk-14.10 run
command should use the /var/lib/
With this feature the Ubuntu SDK test suite just need to set the CLICK_CHROOT_
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Michael Vogt: Approve
-
Diff: 201 lines (+52/-34)3 files modifiedclick/commands/chroot.py (+19/-9)
click/tests/integration/test_chroot.py (+31/-25)
debian/changelog (+2/-0)
| Colin Watson (cjwatson) wrote | #1 |
| Changed in click (Ubuntu): | |
| status: | New → Incomplete |
| importance: | Undecided → High |
| Colin Watson (cjwatson) wrote | #2 |
| Changed in click (Ubuntu): | |
| status: | Incomplete → Triaged |
| Changed in click (Ubuntu): | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
| Changed in click (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in click (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Looking through the code for click chroot, I see that the ClickChroot class constructor already takes a name= keyword argument, which defaults to "click", and is used to form the first part of the full chroot name. Right now this is unused, but it could easily be exposed by way of a new command-line option. I would prefer this over creating a new mechanism.
Would you be content if "click chroot -a armhf -f ubuntu-sdk-14.10 --name test1234 create" etc. worked? You could then make your scripts that call "click chroot" honour an environment variable if that's easier to coordinate at the top level.