No Wi-Fi on Nexus 4 (org::ofono::Interface::NetworkRegistration::str2status(std::string): Unknown status '')

This is about ofono setting an invalid value to the NetworkRegistration Status property.

The reason why indicator-network seems to crash here is that I'm intentionally throwing an exception that nobody will catch and cause the service to generate an apport report so that:
 - A) if the indicator is not handling all the valid values coming from ofono we need to know about it
 - B) to catch exactly these kind of API violations coming from our ofono implementation.

@Matthew I have an idea of what might be happening, but I need traces to confirm. Please do as follows (I assume we are talking about Nexus 4 here):

$ phablet-shell
$ sudo su
# stop ofono
# export OFONO_RIL_HEX_TRACE=""
# export OFONO_RIL_TRACE=""
# ofonod -n -d -P stktest,provision,sap,udev,dun,smart,hfp > /tmp/ofono_log.txt

- Make sure that the problem is happening (use list-modems and check that "Status" property is empty)

- Stop ofono (ctrl+c) and please attach ofono_log.txt

This PR contains a fix for ofono:

https://github.com/rilmodem/ofono/pull/87

With the fix "Status" is now "denied", as can be seen in list-modems output from Matthew:

https://pastebin.canonical.com/117079/

However, Matthew still sees issues with the WiFi indicator, but indicator-network does not crash. So the PR fixes as a minimum part of the problem, but maybe not the whole lot.

I'm not sure I fully understand the problem.

From the bug description which includes:

org::ofono::Interface::NetworkRegistration::str2status(std::string): Unknown status

It seems like the indicator is throwing an error if NetworkRegistration's 'Status' property is "unknown"? Or are we never setting 'Status' at all if the RIL reply specifies the registration state as unknown ( 4 )?

@Tony, the crash was because "Status" property was an empty string (it was not "unknown" or anything else), which is wrong as specified by ofono/doc/network-api.txt. And it was an actual ofono bug, as we were getting a value for state from rild that was not valid for ofono core.

This bug was fixed in the package ofono - 1.12.bzr6878+14.10.20140926-0ubuntu1

---------------
ofono (1.12.bzr6878+14.10.20140926-0ubuntu1) 14.09; urgency=medium

  [ Alfonso Sanchez-Beato ]
  * include, plugins/mtk.c, src/modem.c,sim.c: Fix PUK crash (LP: #1365481)
    If the SIM gets locked in particular sequence, ofono will crash
    while trying to free the list of SIM SPN watch events ( which
    have already been freed ). MTK fix is a bit more involved than
    the stanard RIL logic.

  * plugins/mtk.c,ril.c: Show emergency numbers in flight-mode (LP: #1366188)
    Modify plugin logic to create the SimManager interface even if
    no SIM is present.

  * gril, unit: fix indicator-network crash (LP: #1368675)
    RIL defines a set of network registration states for emergency
    calling that don't map directly to ofono's states. This results
    in NetworkRegistration Status not being set at all, which in
    turn crashes the indicator.

  * rilmodem/gprs.c: fix crash due to stale timer event (LP: # 1373351)
    A 5s timer is set to retry a STATUS request to RIL, however if
    FlightMode is enabled, the gprs atom is destroyed, and the pending
    timer callback has a stale gprs reference. Now the timer id is
    stored, and when the atom destroyed, the timer event is cancelled.

  * mtkmodem/radio-setttings.c: fix RadioSettings creation (LP: #1374029 )
    If the MTK modem returns a RADIO_NOT_AVAIL error in response
    to a FastDormany RIL request, the RadioSetting initialization
    callback sequence is broken, and thus the RadioSettings interface
    isn't created. This in turn prevents powerd from enabling
    FastDorancy whenever the screen is turned off, and also has
    implications for system-settings too.

  [ Tony Espy ]
  * plugins/ubuntu-apndb.c: allow MMS APNs w/out proxy (LP: #1362008)
    Prior to this change, MMS APNs w/out a proxy were skipped.
    Now APNs are skipped if message center is missing, which makes
    more sense.

  [ Ubuntu daily release ]
  * New rebuild forced

ofono (1.12.bzr6876+14.10.20140904-0ubuntu1) utopic; urgency=medium

  [ Jussi Kangas ]
  * src/gprs.c: Fix to allow MMS properties to be set (LP: #1362068)

  [ Tony Espy ]
  * rilmodem/sim.c: Fix EnterPIN logic (LP: #1363413)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Fri, 26 Sep 2014 17:34:10 +0000

Same version landed in RTM.