widelands crashed with SIGSEGV in LuaGame::LuaPlayer::get_buildings()

Bug #1402392 reported by LAZA
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned

Bug Description

widelands 1:18-ppa0-bzr7319-201412120801~ubuntu14.04.1 [origin: LP-PPA-widelands-dev-widelands-daily]

Barbarian Scenario 2
Event triggered after first building was conquered: kill all enemies.

Game crashes reproducible.

Attatched is the Ubuntu bug report (57 MB!).

Related branches

Revision history for this message
LAZA (laza74) wrote :
description: updated
Revision history for this message
LAZA (laza74) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

I launched the replay and can reproduce the crash.

Changed in widelands:
status: New → Confirmed
milestone: none → build19-rc1
tags: added: barbarians campaign crash replay
Revision history for this message
SirVer (sirver) wrote :

replay does not crash for me on mac os x.

Revision history for this message
SirVer (sirver) wrote :

I stand corrected - it crashed after resuming. :(

Changed in widelands:
importance: Undecided → High
assignee: nobody → SirVer (sirver)
Revision history for this message
SirVer (sirver) wrote :

I fixed the crash in r7326.

 However, something makes me very suspicious about this. I could not find the regression - i.e. the breaking commit. And I am not sure why the behavior has changed. The only thing that comes to mind is that the Player is not getting updates about lost buildings.

Could somebody verify that this is indeed fixed by playing through this campaign again and checking that the building statistics is updated with lost and gains of buildings? Military wise and others.

Changed in widelands:
status: Confirmed → Fix Committed
assignee: SirVer (sirver) → nobody
Revision history for this message
LAZA (laza74) wrote :

I will - but atm the daily builds fail to build!
If this problem is solved, i will check and double-check all campaigns in the holidays.

btw: I often used the new DISMANTLE feature, it works glad as an babys a... :-)

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

>I will - but atm the daily builds fail to build!

It's working again now [1]. Refresh your package list to get the lastest build. :)

[https://code.launchpad.net/~widelands-dev/+recipe/widelands-daily]

Revision history for this message
SirVer (sirver) wrote :

Has somebody verified this fix?

Revision history for this message
LAZA (laza74) wrote :

Yes, i did a December 29th:
Worked with daily-ppa 73.. (sorry, didn't write down the number)

But the game was playable till the end.
--> the enemies (where is number 3 gone??) give up to fast!

Revision history for this message
SirVer (sirver) wrote :

great - thanks for the feedback!

Revision history for this message
LAZA (laza74) wrote :

Okay, can confirm the fix works in bzr7343 from ppa-daily.

GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.